[GitHub] [iceberg] openinx commented on a change in pull request #1956: upgrade flink version from 1.11.0 to 1.12.0

[GitBox <gi...@apache.org>]

openinx commented on a change in pull request #1956:
URL: https://github.com/apache/iceberg/pull/1956#discussion_r546530572



##########
File path: flink/src/main/java/org/apache/iceberg/flink/sink/FlinkSink.java
##########
@@ -91,7 +91,7 @@ public static Builder forRow(DataStream<Row> input, TableSchema tableSchema) {
     DataType[] fieldDataTypes = tableSchema.getFieldDataTypes();
 
     DataFormatConverters.RowConverter rowConverter = new DataFormatConverters.RowConverter(fieldDataTypes);
-    return builderFor(input, rowConverter::toInternal, RowDataTypeInfo.of(rowType))
+    return builderFor(input, rowConverter::toInternal, InternalTypeInfo.of(rowType))

Review comment:
       I checked the flink codebase,  all the `RowData`'s TypeSerializer related classes are not expose to be `public`, they are marked as `Internal`.  The only way I can think of is:  Use a compactbility utility to load `InternalTypeInfo`  or `RowDataTypeInfo` class if there's exist one.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org