You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "zhengruifeng (via GitHub)" <gi...@apache.org> on 2023/10/04 08:12:23 UTC

[PR] Revert "[SPARK-45088][PYTHON][CONNECT] Make `getitem` work with duplicated column" [spark]

zhengruifeng opened a new pull request, #43211:
URL: https://github.com/apache/spark/pull/43211

   ### What changes were proposed in this pull request?
   This reverts commit 73d3c49c97ae1be3f9f96fbc86be1c91cd17a656.
   
   
   
   ### Why are the changes needed?
   to address https://github.com/apache/spark/pull/42828#discussion_r1338141627 and https://github.com/apache/spark/pull/43115#discussion_r1338097284, we should not use `GetColumnByOrdinal` in this case.
   
   Need to find another approach, but let's revert it first.
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   ### How was this patch tested?
   CI
   
   
   ### Was this patch authored or co-authored using generative AI tooling?
   No


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] Revert "[SPARK-45088][PYTHON][CONNECT] Make `getitem` work with duplicated column" [spark]

Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng closed pull request #43211: Revert "[SPARK-45088][PYTHON][CONNECT] Make `getitem` work with duplicated column"
URL: https://github.com/apache/spark/pull/43211


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] Revert "[SPARK-45088][PYTHON][CONNECT] Make `getitem` work with duplicated column" [spark]

Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #43211:
URL: https://github.com/apache/spark/pull/43211#issuecomment-1746687022

   thank you, merged to master


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org