[jira] [Comment Edited] (SLING-5726) Allow ValueMapInjector and ResourcePathInjector to act directly on SlingHttpServletRequest

["Konrad Windszus (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-5726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15282628#comment-15282628 ] 

Konrad Windszus edited comment on SLING-5726 at 5/13/16 11:40 AM:
------------------------------------------------------------------

Reverted with [r1743654|https://svn.apache.org/r1743654] as [~justinedelson] did not agree with that change. See the discussion at http://www.mail-archive.com/dev@sling.apache.org/msg56010.html.


was (Author: kwin):
Reverted with [r1743654|https://svn.apache.org/r1743654] as [~justinedelson] did not agree with that change. See the discussion athttp://www.mail-archive.com/dev@sling.apache.org/msg56010.html.

> Allow ValueMapInjector and ResourcePathInjector to act directly on SlingHttpServletRequest
> ------------------------------------------------------------------------------------------
>
>                 Key: SLING-5726
>                 URL: https://issues.apache.org/jira/browse/SLING-5726
>             Project: Sling
>          Issue Type: Bug
>          Components: Extensions
>    Affects Versions: Sling Models Impl 1.2.8
>            Reporter: Konrad Windszus
>            Assignee: Konrad Windszus
>
> Currently both injectors only work correctly on objects being adaptable to a {{ValueMap}}. For {{ValueMapInjector}} this is documented but for {{ResourcePathInjector}} it is not (http://sling.apache.org/documentation/bundles/models.html#available-injectors), although for the latter it does only matter if the path is given through a resource property and not in a static way.
> This should be relaxed that both also work with {{SlingHttpServletRequest}} as that always carries the current resource from which the {{ValueMap}} can be easily retrieved.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)