You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "John Russell (Code Review)" <ge...@cloudera.org> on 2017/03/15 22:45:30 UTC

[Impala-ASF-CR] [DOCS] Pare down ODBC info

John Russell has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/6409

Change subject: [DOCS] Pare down ODBC info
......................................................................

[DOCS] Pare down ODBC info

Remove the Cloudera-specific portion of the
Impala + ODBC page, leaving just the background
info about why to use ODBC. Defer to third parties
who supply ODBC drivers.

Change-Id: I302d23432d348aa0c9c2837c0f42bc4f2844f9b8
---
M docs/topics/impala_odbc.xml
1 file changed, 5 insertions(+), 174 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/09/6409/1
-- 
To view, visit http://gerrit.cloudera.org:8080/6409
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I302d23432d348aa0c9c2837c0f42bc4f2844f9b8
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>

[Impala-ASF-CR] [DOCS] Pare down ODBC info

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.

Change subject: [DOCS] Pare down ODBC info
......................................................................


Patch Set 2: Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/6409
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I302d23432d348aa0c9c2837c0f42bc4f2844f9b8
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] [DOCS] Pare down ODBC info

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.

Change subject: [DOCS] Pare down ODBC info
......................................................................


[DOCS] Pare down ODBC info

Remove the Cloudera-specific portion of the
Impala + ODBC page, leaving just the background
info about why to use ODBC. Defer to third parties
who supply ODBC drivers.

Change-Id: I302d23432d348aa0c9c2837c0f42bc4f2844f9b8
Reviewed-on: http://gerrit.cloudera.org:8080/6409
Reviewed-by: Jim Apple <jb...@apache.org>
Tested-by: Impala Public Jenkins
---
M docs/topics/impala_odbc.xml
1 file changed, 6 insertions(+), 174 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Jim Apple: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/6409
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I302d23432d348aa0c9c2837c0f42bc4f2844f9b8
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>

[Impala-ASF-CR] [DOCS] Pare down ODBC info

Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.

Change subject: [DOCS] Pare down ODBC info
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/6409/1/docs/topics/impala_odbc.xml
File docs/topics/impala_odbc.xml:

PS1, Line 39: can be integrate
> "can be integrated"
Done


PS1, Line 42: all been approved
> by whom?
Since this formerly was always in the context of CDH, I'll add an item to this list about the Hadoop distribution, and then leave the "whom" open-ended, i.e. "the appropriate suppliers". Because it could equally involve going to Tableau or Splunk and inquiring if a configuration is supported (which could involve pure Apache Impala), or asking Cloudera, MapR, Amazon, etc.


-- 
To view, visit http://gerrit.cloudera.org:8080/6409
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I302d23432d348aa0c9c2837c0f42bc4f2844f9b8
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: Yes

[Impala-ASF-CR] [DOCS] Pare down ODBC info

Posted by "Greg Rahn (Code Review)" <ge...@cloudera.org>.
Greg Rahn has posted comments on this change.

Change subject: [DOCS] Pare down ODBC info
......................................................................


Patch Set 1: Code-Review+1

-- 
To view, visit http://gerrit.cloudera.org:8080/6409
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I302d23432d348aa0c9c2837c0f42bc4f2844f9b8
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] [DOCS] Pare down ODBC info

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.

Change subject: [DOCS] Pare down ODBC info
......................................................................


Patch Set 2:

Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/102/

-- 
To view, visit http://gerrit.cloudera.org:8080/6409
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I302d23432d348aa0c9c2837c0f42bc4f2844f9b8
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] [DOCS] Pare down ODBC info

Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.

Change subject: [DOCS] Pare down ODBC info
......................................................................


Patch Set 2: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/6409
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I302d23432d348aa0c9c2837c0f42bc4f2844f9b8
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] [DOCS] Pare down ODBC info

Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
Hello Greg Rahn,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/6409

to look at the new patch set (#2).

Change subject: [DOCS] Pare down ODBC info
......................................................................

[DOCS] Pare down ODBC info

Remove the Cloudera-specific portion of the
Impala + ODBC page, leaving just the background
info about why to use ODBC. Defer to third parties
who supply ODBC drivers.

Change-Id: I302d23432d348aa0c9c2837c0f42bc4f2844f9b8
---
M docs/topics/impala_odbc.xml
1 file changed, 6 insertions(+), 174 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/09/6409/2
-- 
To view, visit http://gerrit.cloudera.org:8080/6409
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I302d23432d348aa0c9c2837c0f42bc4f2844f9b8
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>

[Impala-ASF-CR] [DOCS] Pare down ODBC info

Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.

Change subject: [DOCS] Pare down ODBC info
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/6409/1/docs/topics/impala_odbc.xml
File docs/topics/impala_odbc.xml:

PS1, Line 39: can be integrate
"can be integrated"


PS1, Line 42: all been approved
by whom?


-- 
To view, visit http://gerrit.cloudera.org:8080/6409
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I302d23432d348aa0c9c2837c0f42bc4f2844f9b8
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-HasComments: Yes