You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "innerpeacez (via GitHub)" <gi...@apache.org> on 2023/03/21 07:02:09 UTC
[GitHub] [skywalking] innerpeacez commented on a diff in pull request #10568: fix: k8s service name cache(podServiceMap) wrong
innerpeacez commented on code in PR #10568:
URL: https://github.com/apache/skywalking/pull/10568#discussion_r1142956310
##########
oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/k8s/K8sInfoRegistry.java:
##########
@@ -96,6 +98,8 @@ private K8sInfoRegistry() {
.filter(it -> it.getMetadata() != null)
.filter(it -> it.getSpec() != null)
.filter(it -> requireNonNull(it.getSpec()).getSelector() != null)
+ .filter(it -> it.getMetadata().getNamespace() != null
+ && it.getMetadata().getNamespace().equals(pod.get().getMetadata().getNamespace()))
Review Comment:
Do you mean so?
![image](https://user-images.githubusercontent.com/37059529/226537364-b6e0c131-5daf-4c56-a359-b7b7677e72b1.png)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org