[jira] [Commented] (AIRFLOW-3733) raise NameError if hql result had no record

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-3733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16747396#comment-16747396 ] 

ASF GitHub Bot commented on AIRFLOW-3733:
-----------------------------------------

zhongjiajie commented on pull request #4560: [AIRFLOW-3733] init variable `i` ensure not raise NameError in hive_hooks to_csv function
URL: https://github.com/apache/airflow/pull/4560
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-3733
     - In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
   
   ### Description
   
   - [x] before write record to csv file, init variable `i` to avoid `NameError` in [log part](https://github.com/apache/airflow/blob/31318ba8eb5b136277fc1672813cb57e68989abf/airflow/hooks/hive_hooks.py#L903), while hql query result return NO record.
   
   ### Tests
   
   - [x] My PR does not need testing for this extremely good reason: exist unittest could test it
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use it.
     - When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
   
   ### Code Quality
   
   - [x] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> raise NameError if hql result had no record
> -------------------------------------------
>
>                 Key: AIRFLOW-3733
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3733
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: hive_hooks
>    Affects Versions: 1.10.1
>            Reporter: zhongjiajie
>            Assignee: zhongjiajie
>            Priority: Major
>              Labels: easyfix
>
> [to_csv|https://github.com/apache/airflow/blob/233f6c750c543a669c5319c7167a68a1f5b33c16/airflow/hooks/hive_hooks.py#L881-L903] function will raise `NameError` while hql result had not record,  we should init variable i like  [oracle_hooks|https://github.com/apache/airflow/blob/233f6c750c543a669c5319c7167a68a1f5b33c16/airflow/hooks/oracle_hook.py#L92-L124]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)