You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2020/02/13 03:29:55 UTC
[GitHub] [servicecomb-kie] GuoYL123 opened a new pull request #94: #79
record polling history
GuoYL123 opened a new pull request #94: #79 record polling history
URL: https://github.com/apache/servicecomb-kie/pull/94
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-kie] tianxiaoliang commented on a change in pull
request #94: #79 record polling history
Posted by GitBox <gi...@apache.org>.
tianxiaoliang commented on a change in pull request #94: #79 record polling history
URL: https://github.com/apache/servicecomb-kie/pull/94#discussion_r378887822
##########
File path: server/resource/v1/kv_resource.go
##########
@@ -108,13 +111,14 @@ func (r *KVResource) GetByKey(rctx *restful.Context) {
WriteErrResponse(rctx, http.StatusBadRequest, err.Error(), common.ContentTypeText)
return
}
+ insID := rctx.ReadHeader("instanceID")
Review comment:
变量名叫sessionID
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-kie] tianxiaoliang commented on a change in pull
request #94: #79 record polling history
Posted by GitBox <gi...@apache.org>.
tianxiaoliang commented on a change in pull request #94: #79 record polling history
URL: https://github.com/apache/servicecomb-kie/pull/94#discussion_r378887615
##########
File path: pkg/model/kv.go
##########
@@ -52,3 +52,17 @@ type ViewResponse struct {
Total int `json:"total,omitempty"`
Data []*ViewDoc `json:"data,omitempty"`
}
+
+//PollingDetail record operation history
+type PollingDetail struct {
+ ID string `json:"id,omitempty" yaml:"id,omitempty"`
+ SessionID string `json:"session_id,omitempty" yaml:"session_id,omitempty"`
+ Domain string `json:"domain,omitempty" yaml:"domain,omitempty"`
+ PollingData map[string]interface{} `json:"polling_data,omitempty" yaml:"polling_data,omitempty"`
Review comment:
PollingData叫params更合适
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-kie] tianxiaoliang merged pull request #94: #79 record
polling history
Posted by GitBox <gi...@apache.org>.
tianxiaoliang merged pull request #94: #79 record polling history
URL: https://github.com/apache/servicecomb-kie/pull/94
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-kie] GuoYL123 commented on a change in pull request
#94: #79 record polling history
Posted by GitBox <gi...@apache.org>.
GuoYL123 commented on a change in pull request #94: #79 record polling history
URL: https://github.com/apache/servicecomb-kie/pull/94#discussion_r379205440
##########
File path: pkg/model/kv.go
##########
@@ -52,3 +52,17 @@ type ViewResponse struct {
Total int `json:"total,omitempty"`
Data []*ViewDoc `json:"data,omitempty"`
}
+
+//PollingDetail record operation history
+type PollingDetail struct {
+ ID string `json:"id,omitempty" yaml:"id,omitempty"`
+ SessionID string `json:"session_id,omitempty" yaml:"session_id,omitempty"`
+ Domain string `json:"domain,omitempty" yaml:"domain,omitempty"`
+ PollingData map[string]interface{} `json:"polling_data,omitempty" yaml:"polling_data,omitempty"`
+ IP string `json:"ip,omitempty" yaml:"ip,omitempty"`
+ UserAgent string `json:"user_agent,omitempty" yaml:"user_agent,omitempty"`
+ URLPath string `json:"url_path,omitempty" yaml:"url_path,omitempty"`
+ ResponseBody interface{} `json:"response_body,omitempty" yaml:"response_body,omitempty"`
Review comment:
这里不考虑有新的接口需要记录数据吗？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-kie] GuoYL123 commented on a change in pull request
#94: #79 record polling history
Posted by GitBox <gi...@apache.org>.
GuoYL123 commented on a change in pull request #94: #79 record polling history
URL: https://github.com/apache/servicecomb-kie/pull/94#discussion_r379206450
##########
File path: server/resource/v1/kv_resource.go
##########
@@ -108,13 +111,14 @@ func (r *KVResource) GetByKey(rctx *restful.Context) {
WriteErrResponse(rctx, http.StatusBadRequest, err.Error(), common.ContentTypeText)
return
}
+ insID := rctx.ReadHeader("instanceID")
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-kie] GuoYL123 commented on a change in pull request
#94: #79 record polling history
Posted by GitBox <gi...@apache.org>.
GuoYL123 commented on a change in pull request #94: #79 record polling history
URL: https://github.com/apache/servicecomb-kie/pull/94#discussion_r379206438
##########
File path: pkg/model/kv.go
##########
@@ -52,3 +52,17 @@ type ViewResponse struct {
Total int `json:"total,omitempty"`
Data []*ViewDoc `json:"data,omitempty"`
}
+
+//PollingDetail record operation history
+type PollingDetail struct {
+ ID string `json:"id,omitempty" yaml:"id,omitempty"`
+ SessionID string `json:"session_id,omitempty" yaml:"session_id,omitempty"`
+ Domain string `json:"domain,omitempty" yaml:"domain,omitempty"`
+ PollingData map[string]interface{} `json:"polling_data,omitempty" yaml:"polling_data,omitempty"`
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-kie] tianxiaoliang commented on a change in pull
request #94: #79 record polling history
Posted by GitBox <gi...@apache.org>.
tianxiaoliang commented on a change in pull request #94: #79 record polling history
URL: https://github.com/apache/servicecomb-kie/pull/94#discussion_r379362002
##########
File path: deployments/db.js
##########
@@ -96,11 +96,53 @@ db.createCollection( "view", {
}
} }
} );
+
+db.createCollection( "polling_detail", {
+ validator: { $jsonSchema: {
+ bsonType: "object",
+ required: [ "id","params","ip","user_agent","url_path","response_body","response_header" ],
Review comment:
user agent， ip非必须
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-kie] tianxiaoliang commented on a change in pull
request #94: #79 record polling history
Posted by GitBox <gi...@apache.org>.
tianxiaoliang commented on a change in pull request #94: #79 record polling history
URL: https://github.com/apache/servicecomb-kie/pull/94#discussion_r379221817
##########
File path: pkg/model/kv.go
##########
@@ -52,3 +52,17 @@ type ViewResponse struct {
Total int `json:"total,omitempty"`
Data []*ViewDoc `json:"data,omitempty"`
}
+
+//PollingDetail record operation history
+type PollingDetail struct {
+ ID string `json:"id,omitempty" yaml:"id,omitempty"`
+ SessionID string `json:"session_id,omitempty" yaml:"session_id,omitempty"`
+ Domain string `json:"domain,omitempty" yaml:"domain,omitempty"`
+ PollingData map[string]interface{} `json:"polling_data,omitempty" yaml:"polling_data,omitempty"`
+ IP string `json:"ip,omitempty" yaml:"ip,omitempty"`
+ UserAgent string `json:"user_agent,omitempty" yaml:"user_agent,omitempty"`
+ URLPath string `json:"url_path,omitempty" yaml:"url_path,omitempty"`
+ ResponseBody interface{} `json:"response_body,omitempty" yaml:"response_body,omitempty"`
Review comment:
那保持吧
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-kie] GuoYL123 commented on a change in pull request
#94: #79 record polling history
Posted by GitBox <gi...@apache.org>.
GuoYL123 commented on a change in pull request #94: #79 record polling history
URL: https://github.com/apache/servicecomb-kie/pull/94#discussion_r379953803
##########
File path: deployments/db.js
##########
@@ -96,11 +96,53 @@ db.createCollection( "view", {
}
} }
} );
+
+db.createCollection( "polling_detail", {
+ validator: { $jsonSchema: {
+ bsonType: "object",
+ required: [ "id","params","ip","user_agent","url_path","response_body","response_header" ],
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-kie] tianxiaoliang commented on a change in pull
request #94: #79 record polling history
Posted by GitBox <gi...@apache.org>.
tianxiaoliang commented on a change in pull request #94: #79 record polling history
URL: https://github.com/apache/servicecomb-kie/pull/94#discussion_r379353902
##########
File path: deployments/db.js
##########
@@ -96,11 +96,53 @@ db.createCollection( "view", {
}
} }
} );
+
+db.createCollection( "polling_detail", {
+ validator: { $jsonSchema: {
+ bsonType: "object",
+ required: [ "id","params","ip","user_agent","url_path","response_body","response_header" ],
Review comment:
session id也应该是不可或缺的
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-kie] GuoYL123 commented on a change in pull request
#94: #79 record polling history
Posted by GitBox <gi...@apache.org>.
GuoYL123 commented on a change in pull request #94: #79 record polling history
URL: https://github.com/apache/servicecomb-kie/pull/94#discussion_r379953843
##########
File path: server/resource/v1/kv_resource.go
##########
@@ -138,18 +142,22 @@ func (r *KVResource) List(rctx *restful.Context) {
WriteErrResponse(rctx, http.StatusBadRequest, err.Error(), common.ContentTypeText)
return
}
+ insID := rctx.ReadHeader("sessionID")
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-kie] tianxiaoliang commented on a change in pull
request #94: #79 record polling history
Posted by GitBox <gi...@apache.org>.
tianxiaoliang commented on a change in pull request #94: #79 record polling history
URL: https://github.com/apache/servicecomb-kie/pull/94#discussion_r379355684
##########
File path: server/resource/v1/kv_resource.go
##########
@@ -138,18 +142,22 @@ func (r *KVResource) List(rctx *restful.Context) {
WriteErrResponse(rctx, http.StatusBadRequest, err.Error(), common.ContentTypeText)
return
}
+ insID := rctx.ReadHeader("sessionID")
Review comment:
insID 变量名也要改
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-kie] tianxiaoliang commented on a change in pull
request #94: #79 record polling history
Posted by GitBox <gi...@apache.org>.
tianxiaoliang commented on a change in pull request #94: #79 record polling history
URL: https://github.com/apache/servicecomb-kie/pull/94#discussion_r378886500
##########
File path: pkg/model/kv.go
##########
@@ -52,3 +52,17 @@ type ViewResponse struct {
Total int `json:"total,omitempty"`
Data []*ViewDoc `json:"data,omitempty"`
}
+
+//PollingDetail record operation history
+type PollingDetail struct {
+ ID string `json:"id,omitempty" yaml:"id,omitempty"`
+ SessionID string `json:"session_id,omitempty" yaml:"session_id,omitempty"`
+ Domain string `json:"domain,omitempty" yaml:"domain,omitempty"`
+ PollingData map[string]interface{} `json:"polling_data,omitempty" yaml:"polling_data,omitempty"`
+ IP string `json:"ip,omitempty" yaml:"ip,omitempty"`
+ UserAgent string `json:"user_agent,omitempty" yaml:"user_agent,omitempty"`
+ URLPath string `json:"url_path,omitempty" yaml:"url_path,omitempty"`
+ ResponseBody interface{} `json:"response_body,omitempty" yaml:"response_body,omitempty"`
Review comment:
别必要用interface 结构体明确就是KVResponse
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services