You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2017/12/08 22:50:34 UTC

Review Request 64470: Clarified comments in the allocator.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64470/
-----------------------------------------------------------

Review request for mesos, Benjamin Mahler and Michael Park.


Repository: mesos


Description
-------

Clarified comments in the allocator.


Diffs
-----

  src/master/allocator/mesos/hierarchical.hpp 41801eb4567b0bbd6c189c03e27a43cc06bc0407 


Diff: https://reviews.apache.org/r/64470/diff/1/


Testing
-------


Thanks,

Meng Zhu

Re: Review Request 64470: Clarified comments in the allocator.

Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64470/#review193285
-----------------------------------------------------------


Ship it!





src/master/allocator/mesos/hierarchical.hpp
Line 513 (original), 516-517 (patched)
<https://reviews.apache.org/r/64470/#comment271837>

    Ditto here:
    
    ```
    Since only non-revocable resources are available for quota, the total cluster non-revocableresoures are used as the resource pool.
    ```



src/master/allocator/mesos/hierarchical.hpp
Line 530 (original), 534-536 (patched)
<https://reviews.apache.org/r/64470/#comment271836>

    Maybe we should explain why it's like this? i.e.
    
    ```
    Since frameworks are sharing the resources allocated to a role, the role's allocation is used as the resource pool for each role specific framework sorter.
    ```


- Benjamin Mahler


On Dec. 8, 2017, 10:50 p.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64470/
> -----------------------------------------------------------
> 
> (Updated Dec. 8, 2017, 10:50 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Clarified comments in the allocator.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.hpp 41801eb4567b0bbd6c189c03e27a43cc06bc0407 
> 
> 
> Diff: https://reviews.apache.org/r/64470/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>