You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by Christian Geisert <ch...@isu-gmbh.de> on 2007/01/25 11:57:26 UTC
Wrong line endings for ant
Hi,
I just noticed that ant has wrong line endings.
Seems this happened with the ASL header patch yesterday as ant is
missing the svn:eol-style property.
Christian
Re: Wrong line endings for ant
Posted by Jacques Le Roux <ja...@les7arts.com>.
Thanks Christian,
I will check it soon.
Jacques
> Hi,
>
> I just noticed that ant has wrong line endings.
> Seems this happened with the ASL header patch yesterday as ant is
> missing the svn:eol-style property.
>
> Christian
Re: Wrong line endings for ant
Posted by "David E. Jones" <jo...@hotwaxmedia.com>.
This is the "ant" file which is a shell script for Linux/Unix. It
isn't part of Ant itself.
-David
On Jan 25, 2007, at 1:19 PM, Adrian Crum wrote:
> Are you saying that ant doesn't support cr/lf line endings?
>
> Jacques Le Roux wrote:
>
>> This is my comment from commit log
>> ========================================
>> EOL was wrong since ASL2 headers change yesterday. Thanks to
>> Christian Gesisert who noticed it.
>> I also forced svn:eol-style=LF for this file. Maybe this change
>> should be better made in svn config file ?
>> I will check other files
>> ========================================
>> I have checked some other files, at least 12 files are concerned
>> (in root).
>> I guess that this files have seen there EOL changed because of the
>> svn:eol-style set to native in svn config file.
>> for instance sh is
>> *.sh = svn:eol-
>> style=native;svn:executable;svn:keywords="Date Rev Author URL Id"
>> I'm mostly working on XP and this commit was from an XP machine
>> hence the result. This may reappears later so I propose that we
>> change svn:eol-style to LF where they are now native.
>> The only drawback I see in this change is for people using not
>> smart Windows editors. Notice this files had an Unix EOL style before
>> and nobody complained.
>> What do you think ?
>> I have also a problem with Oxygen in Eclipse on Windows and I did
>> no find a turnaroud yet but
>> http://www.oxygenxml.com/pipermail/oxygen-user/2006-September/
>> 000924.html wich is not very satisfactory because I have to use the
>> Eclipse "Convert Line Delimiters" each time I modify an xml file !
>> Any idea for this one ?
>> Thanks
>> Jacques
>> ----- Original Message ----- From: "Christian Geisert"
>> <ch...@isu-gmbh.de>
>> To: <de...@ofbiz.apache.org>
>> Sent: Thursday, January 25, 2007 11:57 AM
>> Subject: Wrong line endings for ant
>>> Hi,
>>>
>>> I just noticed that ant has wrong line endings.
>>> Seems this happened with the ASL header patch yesterday as ant is
>>> missing the svn:eol-style property.
>>>
>>> Christian
Re: Wrong line endings for ant
Posted by Adrian Crum <ad...@hlmksw.com>.
Are you saying that ant doesn't support cr/lf line endings?
Jacques Le Roux wrote:
> This is my comment from commit log
>
> ========================================
> EOL was wrong since ASL2 headers change yesterday. Thanks to Christian Gesisert who noticed it.
> I also forced svn:eol-style=LF for this file. Maybe this change should be better made in svn config file ?
> I will check other files
> ========================================
>
> I have checked some other files, at least 12 files are concerned (in root).
> I guess that this files have seen there EOL changed because of the svn:eol-style set to native in svn config file.
> for instance sh is
> *.sh = svn:eol-style=native;svn:executable;svn:keywords="Date Rev Author URL Id"
>
> I'm mostly working on XP and this commit was from an XP machine hence the result. This may reappears later so I propose that we
> change svn:eol-style to LF where they are now native.
> The only drawback I see in this change is for people using not smart Windows editors. Notice this files had an Unix EOL style before
> and nobody complained.
>
> What do you think ?
>
> I have also a problem with Oxygen in Eclipse on Windows and I did no find a turnaroud yet but
> http://www.oxygenxml.com/pipermail/oxygen-user/2006-September/000924.html wich is not very satisfactory because I have to use the
> Eclipse "Convert Line Delimiters" each time I modify an xml file ! Any idea for this one ?
>
> Thanks
>
> Jacques
>
>
>
> ----- Original Message -----
> From: "Christian Geisert" <ch...@isu-gmbh.de>
> To: <de...@ofbiz.apache.org>
> Sent: Thursday, January 25, 2007 11:57 AM
> Subject: Wrong line endings for ant
>
>
>
>>Hi,
>>
>>I just noticed that ant has wrong line endings.
>>Seems this happened with the ASL header patch yesterday as ant is
>>missing the svn:eol-style property.
>>
>>Christian
>
>
>
Re: Wrong line endings for ant
Posted by "David E. Jones" <jo...@hotwaxmedia.com>.
Jacques,
Please don't do any more manual line ending stuff then!!!!
The "native" thing is meant to convert line endings to the ones
native to the platform the _client_ is running on.
This means the files on your XP machine should always have the
windows line endings.
So, NO! We don't want to change anything here! We want people on
Windows to have Windows line endings, and people on Linux/Unix to
have Linux/Unix line endings.
-David
On Jan 25, 2007, at 12:00 PM, Jacques Le Roux wrote:
> This is my comment from commit log
>
> ========================================
> EOL was wrong since ASL2 headers change yesterday. Thanks to
> Christian Gesisert who noticed it.
> I also forced svn:eol-style=LF for this file. Maybe this change
> should be better made in svn config file ?
> I will check other files
> ========================================
>
> I have checked some other files, at least 12 files are concerned
> (in root).
> I guess that this files have seen there EOL changed because of the
> svn:eol-style set to native in svn config file.
> for instance sh is
> *.sh = svn:eol-
> style=native;svn:executable;svn:keywords="Date Rev Author URL Id"
>
> I'm mostly working on XP and this commit was from an XP machine
> hence the result. This may reappears later so I propose that we
> change svn:eol-style to LF where they are now native.
> The only drawback I see in this change is for people using not
> smart Windows editors. Notice this files had an Unix EOL style before
> and nobody complained.
>
> What do you think ?
>
> I have also a problem with Oxygen in Eclipse on Windows and I did
> no find a turnaroud yet but
> http://www.oxygenxml.com/pipermail/oxygen-user/2006-September/
> 000924.html wich is not very satisfactory because I have to use the
> Eclipse "Convert Line Delimiters" each time I modify an xml file !
> Any idea for this one ?
>
> Thanks
>
> Jacques
>
>
>
> ----- Original Message -----
> From: "Christian Geisert" <ch...@isu-gmbh.de>
> To: <de...@ofbiz.apache.org>
> Sent: Thursday, January 25, 2007 11:57 AM
> Subject: Wrong line endings for ant
>
>
>> Hi,
>>
>> I just noticed that ant has wrong line endings.
>> Seems this happened with the ASL header patch yesterday as ant is
>> missing the svn:eol-style property.
>>
>> Christian
>
Re: Wrong line endings for ant
Posted by Jacques Le Roux <ja...@les7arts.com>.
This is my comment from commit log
========================================
EOL was wrong since ASL2 headers change yesterday. Thanks to Christian Gesisert who noticed it.
I also forced svn:eol-style=LF for this file. Maybe this change should be better made in svn config file ?
I will check other files
========================================
I have checked some other files, at least 12 files are concerned (in root).
I guess that this files have seen there EOL changed because of the svn:eol-style set to native in svn config file.
for instance sh is
*.sh = svn:eol-style=native;svn:executable;svn:keywords="Date Rev Author URL Id"
I'm mostly working on XP and this commit was from an XP machine hence the result. This may reappears later so I propose that we
change svn:eol-style to LF where they are now native.
The only drawback I see in this change is for people using not smart Windows editors. Notice this files had an Unix EOL style before
and nobody complained.
What do you think ?
I have also a problem with Oxygen in Eclipse on Windows and I did no find a turnaroud yet but
http://www.oxygenxml.com/pipermail/oxygen-user/2006-September/000924.html wich is not very satisfactory because I have to use the
Eclipse "Convert Line Delimiters" each time I modify an xml file ! Any idea for this one ?
Thanks
Jacques
----- Original Message -----
From: "Christian Geisert" <ch...@isu-gmbh.de>
To: <de...@ofbiz.apache.org>
Sent: Thursday, January 25, 2007 11:57 AM
Subject: Wrong line endings for ant
> Hi,
>
> I just noticed that ant has wrong line endings.
> Seems this happened with the ASL header patch yesterday as ant is
> missing the svn:eol-style property.
>
> Christian