[GitHub] [incubator-iotdb] jt2594838 commented on a change in pull request #486: [IOTDB-271] Add configuration for HDFS HA

[GitBox <gi...@apache.org>]

jt2594838 commented on a change in pull request #486: [IOTDB-271] Add configuration for HDFS HA
URL: https://github.com/apache/incubator-iotdb/pull/486#discussion_r339934739
 
 

 ##########
 File path: tsfile/src/main/java/org/apache/iotdb/tsfile/common/conf/TSFileConfig.java
 ##########
 @@ -292,6 +292,26 @@ public void setEndian(String endian) {
    */
   private String hdfsPort = "9000";
 
+  /**
+   * Default DFS NameServices is hdfsnamespace
+   */
+  private String dfsNameServices = "hdfsnamespace";
+
+  /**
+   * Default DFS HA name nodes are nn1 and nn2
+   */
+  private String dfsHaNamenodes = "nn1,nn2";
+
+  /**
+   * Default DFS HA automatic failover is enabled
+   */
+  private boolean dfsHaAutomaticFailoverEnabled = true;
+
+  /**
+   * Default DFS client failover proxy provider is "org.apache.hadoop.hdfs.server.namenode.ha.ConfiguredFailoverProxyProvider"
+   */
+  private String dfsClientFailoverProxyProvider = "org.apache.hadoop.hdfs.server.namenode.ha.ConfiguredFailoverProxyProvider";
 
 Review comment:
   I think HDFS related configurations are better in another file.
   How do you think? @qiaojialin 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services