[GitHub] cloudstack pull request: CLOUDSTACK-9297 - Reworked logic in Stora...

[rafaelweingartner <gi...@git.apache.org>]

Github user rafaelweingartner commented on the pull request:

    https://github.com/apache/cloudstack/pull/1441#issuecomment-197935023
  
    @mike-tutkowski thanks for the improvements on PR title and description. 
    I understand the point of throwing an exception and I really like that approach.
    
    About the suggested change on “canHandle” method, I still did not see the need to use the enum. If you were using more than 2 values as its returns, it would be something I would understand; but you only use two values that could be represented as a “true” or “false”.
    
    Could you elaborate a little bit more?
    I also did not understand this sentence:
    “I see returning true as your revert was successful and returning false as it failed (but it was OK for you to ask us to revert because canHandle properly told you that you could do so)”
    
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---