You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org> on 2012/05/03 01:21:53 UTC
[jira] [Commented] (OOZIE-818) CoordChangeXCommand deletes past
coordinator actions
[ https://issues.apache.org/jira/browse/OOZIE-818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13267012#comment-13267012 ]
jiraposter@reviews.apache.org commented on OOZIE-818:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4842/#review7490
-----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java
<https://reviews.apache.org/r/4842/#comment16585>
remove trailing tab/spaces
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java
<https://reviews.apache.org/r/4842/#comment16586>
we should not delete actions if it is already running, that one should stay. while extremely unlikely, we should do that check
- Alejandro
On 2012-04-23 08:07:07, shwethags wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4842/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-23 08:07:07)
bq.
bq.
bq. Review request for oozie.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. CoordChangeXCommand.processLookaheadActions() doesn't use coord timeunit while calculating the action times. So, if the frequency is non-minutes(hours, days, months), setting pause time can delete past coord actions
bq.
bq.
bq. This addresses bug OOZIE-818.
bq. https://issues.apache.org/jira/browse/OOZIE-818
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 1329080
bq. trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java 1329080
bq.
bq. Diff: https://reviews.apache.org/r/4842/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. UT - TestCoordChangeXCommand
bq.
bq.
bq. Thanks,
bq.
bq. shwethags
bq.
bq.
> CoordChangeXCommand deletes past coordinator actions
> ----------------------------------------------------
>
> Key: OOZIE-818
> URL: https://issues.apache.org/jira/browse/OOZIE-818
> Project: Oozie
> Issue Type: Bug
> Reporter: Shwetha G S
> Assignee: Shwetha G S
> Priority: Critical
>
> CoordChangeXCommand.processLookaheadActions() doesn't use coord timeunit while calculating the action times. So, if the frequency is non-minutes(hours, days, months...), setting pause time can delete past coord actions
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira