You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by prabhjyotsingh <gi...@git.apache.org> on 2016/09/20 08:46:47 UTC

[GitHub] zeppelin pull request #1442: ZEPPELIN-1459: Zeppelin JDBC URL properties man...

GitHub user prabhjyotsingh opened a pull request:

    https://github.com/apache/zeppelin/pull/1442

    ZEPPELIN-1459: Zeppelin JDBC URL properties mangled

    ### What is this PR for?
    While creating connection `DriverManager.getConnection(url, properties);` for JDBC interpreter, phoenix driver is modifying the properties that is passed as parameter, which in modifies propertiesMap.
    
    This all is resulting in, not able to execute any other paragraph with phoenix interpreter.
    
    This only happens if JDBC URI is "jdbc:phoenix:thin:url"
    
    ### What type of PR is it?
    [Bug Fix]
    
    ### Todos
    * [x] - Pass of copy of `properties` to `DriverManager.getConnection(url, properties)`
    
    ### What is the Jira issue?
    * [ZEPPELIN-1459](https://issues.apache.org/jira/browse/ZEPPELIN-1459)
    
    ### How should this be tested?
    Use the example setting below
    https://issues.apache.org/jira/browse/ZEPPELIN-1459?focusedCommentId=15505750&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15505750
    
    
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update? n/a
    * Is there breaking changes for older versions? n/a
    * Does this needs documentation? n/a
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-1459

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1442.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1442
    
----
commit 6d1ac9dcc49b388b4a5789ded544d27df45c3cb5
Author: Prabhjyot Singh <pr...@gmail.com>
Date:   2016-09-20T08:30:46Z

    ZEPPELIN-1459: Zeppelin JDBC URL properties mangled

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1442: ZEPPELIN-1459: Zeppelin JDBC URL properties man...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/1442


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1442: ZEPPELIN-1459: Zeppelin JDBC URL properties mangled

Posted by randerzander <gi...@git.apache.org>.

Github user randerzander commented on the issue:

    https://github.com/apache/zeppelin/pull/1442
  
    I tested the PR and it works as expected. Thanks @prabhjyotsingh!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1442: ZEPPELIN-1459: Zeppelin JDBC URL properties mangled

Posted by prabhjyotsingh <gi...@git.apache.org>.

Github user prabhjyotsingh commented on the issue:

    https://github.com/apache/zeppelin/pull/1442
  
    Thank you @randerzander, will merge this soon.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---