RE: [PATCH] fo.FOText - Bugfix for small-caps in static content b ecomes all-caps [1171]

[Kelly Campbell <ca...@channelpoint.com>]

I'll see if I can get this patch applied after Arved completes the release.

-Kelly

> -----Original Message-----
> From: Eric SCHAEFFER [mailto:e-schaeffer@wanadoo.fr]
> Sent: Monday, April 02, 2001 3:38 AM
> To: fop-dev@xml.apache.org
> Subject: Re: [PATCH] fo.FOText - Bugfix for small-caps in 
> static content
> becomes all-caps [1171]
> 
> 
> First, thank's for the patch. Second, sorry, but I won't have 
> time to really
> look at it.
> I don't see any limitation or bad effect in using a temporary 
> array. When I
> wrote the small caps code, I forgot the static content 
> particulary case... I
> think your patch is a good solution. The only other way to 
> solve the problem
> is to keep the small-capitalized text in the areas (with the 
> correct font
> sizes), and to have a flag saying that it is already 
> small-capitalized.
> 
> Eric.
> ______________________________
> 
> Eric SCHAEFFER
> eschaeffer@emahoo.com
> FOP, the first XSL:FO Processor
> http://xml.apache.org/fop
> 
> ----- Original Message -----
> From: "Daniel Bradby" <da...@bjs.com.au>
> To: <fo...@xml.apache.org>
> Sent: Monday, April 02, 2001 3:52 AM
> Subject: [PATCH] fo.FOText - Bugfix for small-caps in static 
> content becomes
> all-caps [1171]
> 
> 
> >
> > Maybe not an ideal solution, but it demonstrates the where 
> the problem
> > is. Maybe Eric could take a look at this.
> >
> > Basically the addText() method converts the data to all 
> upper case and
> > correctly sets the height. When this is data in 
> static-content and layed
> > out again (on the next page), the data is already caps so 
> isn't set to
> > the correct height.
> >
> > The patch creates a temp array to manipulate this data in. 
> But as Kelly
> > is trying to improve object allocation, maybe this isn't ideal.
> >
> > Daniel
> 
> 
> --------------------------------------------------------------
> --------------
> ----
> 
> 
> > Index: FOText.java
> > ===================================================================
> > RCS file: 
> /home/cvspublic/xml-fop/src/org/apache/fop/fo/FOText.java,v
> > retrieving revision 1.18
> > diff -r1.18 FOText.java
> > 216a217
> > >                               char tempData[] = new 
> char[data.length];
> > 227c228,230
> > <                                                       data[i] =
> java.lang.Char
> > acter.toUpperCase(c);
> > ---
> > >                                                       
> tempData[i] =
> java.lang.
> > Character.toUpperCase(c);
> > >                                               } else {
> > >                                                       
> tempData[i] = c;
> > 228a232
> > >
> > 240c244
> > <                                               
> whiteSpaceCollapse, data,
> caseSt
> > art, i, textState, vAlign);
> > ---
> > >                                               whiteSpaceCollapse,
> tempData, ca
> > seStart, i, textState, vAlign);
> >
> 
> 
> --------------------------------------------------------------
> --------------
> ----
> 
> 
> > 
> ---------------------------------------------------------------------
> > To unsubscribe, e-mail: fop-dev-unsubscribe@xml.apache.org
> > For additional commands, email: fop-dev-help@xml.apache.org
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: fop-dev-unsubscribe@xml.apache.org
> For additional commands, email: fop-dev-help@xml.apache.org
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: fop-dev-unsubscribe@xml.apache.org
For additional commands, email: fop-dev-help@xml.apache.org