You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Richard Zang <rz...@hortonworks.com> on 2016/03/11 02:20:13 UTC
Re: Review Request 44683: AMBARI-14556. Role based access control UX
fixes
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44683/
-----------------------------------------------------------
(Updated March 11, 2016, 1:20 a.m.)
Review request for Ambari and Xi Wang.
Summary (updated)
-----------------
AMBARI-14556. Role based access control UX fixes
Bugs: AMBARI-14556
https://issues.apache.org/jira/browse/AMBARI-14556
Repository: ambari
Description
-------
Role based access control UX fixes
Diffs
-----
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/clusters/ClustersManageAccessCtrl.js 45130f7
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/clusters/UserAccessListCtrl.js 50a2dab
ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js 2579a38
ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Cluster.js af77596
ambari-admin/src/main/resources/ui/admin-web/app/styles/main.css c435914
ambari-admin/src/main/resources/ui/admin-web/app/views/clusters/manageAccess.html c0e8f1e
ambari-admin/src/main/resources/ui/admin-web/app/views/clusters/userAccessList.html 8c12a25
ambari-admin/src/main/resources/ui/admin-web/app/views/leftNavbar.html 3bb89ba
ambari-admin/src/main/resources/ui/admin-web/test/unit/controllers/clusters/UserAccessListCtrl_test.js 8239653
Diff: https://reviews.apache.org/r/44683/diff/
Testing
-------
Manually tested on live cluster.
Skipped old ui test. Will add tests for new UI in furture.
Thanks,
Richard Zang
Re: Review Request 44683: AMBARI-14556. Role based access control UX
fixes
Posted by Xi Wang <xw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44683/#review123188
-----------------------------------------------------------
Ship it!
Ship It!
- Xi Wang
On March 10, 2016, 5:20 p.m., Richard Zang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44683/
> -----------------------------------------------------------
>
> (Updated March 10, 2016, 5:20 p.m.)
>
>
> Review request for Ambari and Xi Wang.
>
>
> Bugs: AMBARI-14556
> https://issues.apache.org/jira/browse/AMBARI-14556
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Role based access control UX fixes
>
>
> Diffs
> -----
>
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/clusters/ClustersManageAccessCtrl.js 45130f7
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/clusters/UserAccessListCtrl.js 50a2dab
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js 2579a38
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Cluster.js af77596
> ambari-admin/src/main/resources/ui/admin-web/app/styles/main.css c435914
> ambari-admin/src/main/resources/ui/admin-web/app/views/clusters/manageAccess.html c0e8f1e
> ambari-admin/src/main/resources/ui/admin-web/app/views/clusters/userAccessList.html 8c12a25
> ambari-admin/src/main/resources/ui/admin-web/app/views/leftNavbar.html 3bb89ba
> ambari-admin/src/main/resources/ui/admin-web/test/unit/controllers/clusters/UserAccessListCtrl_test.js 8239653
>
> Diff: https://reviews.apache.org/r/44683/diff/
>
>
> Testing
> -------
>
> Manually tested on live cluster.
> Skipped old ui test. Will add tests for new UI in furture.
>
>
> Thanks,
>
> Richard Zang
>
>