[GitHub] [solr] gerlowskija commented on a change in pull request #433: SOLR-15747: Convert /node v2 APIs to annotations

[GitBox <gi...@apache.org>]

gerlowskija commented on a change in pull request #433:
URL: https://github.com/apache/solr/pull/433#discussion_r762421467



##########
File path: solr/core/src/java/org/apache/solr/handler/admin/InfoHandler.java
##########
@@ -150,11 +156,6 @@ public SolrRequestHandler getSubHandler(String subPath) {
 
   @Override
   public Collection<Api> getApis() {
-    return singletonList(new ReqHandlerToApi(this, getSpec("node.Info")));
-  }
-
-  @Override
-  public Boolean registerV2() {
-    return Boolean.TRUE;
+    return Collections.emptyList();

Review comment:
       I've spent a bit of time trying to understand the `ApiSupport` interface and the `getApis` method here, and now think my initial take here was wrong.
   
   `getApis` preexists `ApiRegistrar` and is understood implicitly in some of the data structures used to register and hold RequestHandlers (e.g. `PluginBag`).  We should probably use `getApis` where possible going forward, and reserve `ApiRegistrar` for those APIs which don't have any RequestHandler equivalent.
   
   I'll update the PR to reflect this.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org