You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/07/12 23:38:59 UTC
[GitHub] codecov-io edited a comment on issue #5329: [Table Viz] Table
columns not match with group_by control
codecov-io edited a comment on issue #5329: [Table Viz] Table columns not match with group_by control
URL: https://github.com/apache/incubator-superset/pull/5329#issuecomment-402027826
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5329?src=pr&el=h1) Report
> Merging [#5329](https://codecov.io/gh/apache/incubator-superset/pull/5329?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/19ac6e1231c6ecedb651a83b60a151672e6abbe0?src=pr&el=desc) will **decrease** coverage by `15.77%`.
> The diff coverage is `28.57%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/5329?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5329 +/- ##
===========================================
- Coverage 77.15% 61.38% -15.78%
===========================================
Files 44 373 +329
Lines 8892 23527 +14635
Branches 0 2727 +2727
===========================================
+ Hits 6861 14441 +7580
- Misses 2031 9073 +7042
- Partials 0 13 +13
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5329?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/assets/src/explore/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5329/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbnRyb2xzLmpzeA==) | `47.32% <ø> (ø)` | |
| [superset/assets/src/explore/store.js](https://codecov.io/gh/apache/incubator-superset/pull/5329/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL3N0b3JlLmpz) | `22.36% <0%> (ø)` | |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/5329/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `81.35% <100%> (ø)` | :arrow_up: |
| [...src/explore/components/controls/MetricsControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5329/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvY29udHJvbHMvTWV0cmljc0NvbnRyb2wuanN4) | `79.59% <50%> (ø)` | |
| [...et/assets/src/explore/reducers/saveModalReducer.js](https://codecov.io/gh/apache/incubator-superset/pull/5329/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL3JlZHVjZXJzL3NhdmVNb2RhbFJlZHVjZXIuanM=) | `0% <0%> (ø)` | |
| [...erset/assets/src/dashboard/deprecated/v1/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5329/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvZGVwcmVjYXRlZC92MS9pbmRleC5qc3g=) | `0% <0%> (ø)` | |
| [superset/assets/src/components/CachedLabel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5329/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0NhY2hlZExhYmVsLmpzeA==) | `70.37% <0%> (ø)` | |
| [superset/assets/src/components/TooltipWrapper.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5329/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL1Rvb2x0aXBXcmFwcGVyLmpzeA==) | `100% <0%> (ø)` | |
| [...et/assets/src/dashboard/deprecated/chart/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5329/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvZGVwcmVjYXRlZC9jaGFydC9DaGFydC5qc3g=) | `0% <0%> (ø)` | |
| [superset/assets/src/dashboard/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/5329/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvcmVkdWNlcnMvaW5kZXguanM=) | `100% <0%> (ø)` | |
| ... and [323 more](https://codecov.io/gh/apache/incubator-superset/pull/5329/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5329?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5329?src=pr&el=footer). Last update [19ac6e1...a0f386f](https://codecov.io/gh/apache/incubator-superset/pull/5329?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org