You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/11 03:22:08 UTC

[GitHub] [spark] HyukjinKwon commented on a change in pull request #26319: [SPARK-29594][SQL] Create a Dataset from a Sequence of Case class where…

HyukjinKwon commented on a change in pull request #26319: [SPARK-29594][SQL] Create a Dataset from a Sequence of Case class where…
URL: https://github.com/apache/spark/pull/26319#discussion_r390726359
 
 

 ##########
 File path: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala
 ##########
 @@ -1901,6 +1909,7 @@ case class NestedStruct(f: ClassData)
 case class DeepNestedStruct(f: NestedStruct)
 
 case class InvalidInJava(`abstract`: Int)
+private[sql] case class InvalidInJavaForNumber(`1something`: String)
 
 Review comment:
   I think you can just remove `private[sql] ` or use `private`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org