You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/07/15 09:45:56 UTC
[GitHub] [cordova-electron] erisu opened a new pull request #158: fix(build): format top-level key for nsis-web
erisu opened a new pull request #158:
URL: https://github.com/apache/cordova-electron/pull/158
### Motivation, Context & Description
Some build targets has configurations and are stored in a top-level key.
For example: if the target `dmg` is set, there is a `top-level` node in the configuration structure called `dmg` which contains its configurations.
Not all `top-level` keys match the `target` key.
For example: `nsis-web` target key actually has a top-level key of `nsisWeb`
This PR adds a target key to top-level key mapping. If the target key exists in this mapping, it will use the defined top-level key else fall back to the target key.
### Testing
- `npm t`
- `cordova platform add`
- `cordova build electron`
### Checklist
- [x] I've run the tests to see all new and existing tests pass
- [x] I added automated test coverage as appropriate for this change
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-electron] erisu merged pull request #158: fix(build): format top-level key for nsis-web
Posted by GitBox <gi...@apache.org>.
erisu merged pull request #158:
URL: https://github.com/apache/cordova-electron/pull/158
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-electron] codecov-commenter commented on pull request #158: fix(build): format top-level key for nsis-web
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #158:
URL: https://github.com/apache/cordova-electron/pull/158#issuecomment-658669388
# [Codecov](https://codecov.io/gh/apache/cordova-electron/pull/158?src=pr&el=h1) Report
> Merging [#158](https://codecov.io/gh/apache/cordova-electron/pull/158?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-electron/commit/cc03aff0541487c5c6ef0fc85c89bb2073c19a24&el=desc) will **not change** coverage.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/cordova-electron/pull/158?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #158 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 14 14
Lines 610 612 +2
=========================================
+ Hits 610 612 +2
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-electron/pull/158?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [lib/build.js](https://codecov.io/gh/apache/cordova-electron/pull/158/diff?src=pr&el=tree#diff-bGliL2J1aWxkLmpz) | `100.00% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-electron/pull/158?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-electron/pull/158?src=pr&el=footer). Last update [cc03aff...5fef88f](https://codecov.io/gh/apache/cordova-electron/pull/158?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-electron] codecov-commenter edited a comment on pull request #158: fix(build): format top-level key for nsis-web
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #158:
URL: https://github.com/apache/cordova-electron/pull/158#issuecomment-658669388
# [Codecov](https://codecov.io/gh/apache/cordova-electron/pull/158?src=pr&el=h1) Report
> Merging [#158](https://codecov.io/gh/apache/cordova-electron/pull/158?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-electron/commit/cc03aff0541487c5c6ef0fc85c89bb2073c19a24&el=desc) will **not change** coverage.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/cordova-electron/pull/158?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #158 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 14 14
Lines 610 612 +2
=========================================
+ Hits 610 612 +2
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-electron/pull/158?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [lib/build.js](https://codecov.io/gh/apache/cordova-electron/pull/158/diff?src=pr&el=tree#diff-bGliL2J1aWxkLmpz) | `100.00% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-electron/pull/158?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-electron/pull/158?src=pr&el=footer). Last update [cc03aff...5fef88f](https://codecov.io/gh/apache/cordova-electron/pull/158?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org