[superset] branch generate_screenshots_custom_width created (now dbbbdbc5b8)

[be...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

beto pushed a change to branch generate_screenshots_custom_width
in repository https://gitbox.apache.org/repos/asf/superset.git


      at dbbbdbc5b8 feat: screenshot reports with custom width

This branch includes the following new commits:

     new dbbbdbc5b8 feat: screenshot reports with custom width

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.

[superset] 01/01: feat: screenshot reports with custom width

[be...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

beto pushed a commit to branch generate_screenshots_custom_width
in repository https://gitbox.apache.org/repos/asf/superset.git

commit dbbbdbc5b89a70dc7c0c575d0d99c41e7d4a36bb
Author: Beto Dealmeida <ro...@dealmeida.net>
AuthorDate: Wed Jun 28 19:39:27 2023 -0700

    feat: screenshot reports with custom width
---
 superset/reports/commands/execute.py | 15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)

diff --git a/superset/reports/commands/execute.py b/superset/reports/commands/execute.py
index bb7c53ed5e..c499741b08 100644
--- a/superset/reports/commands/execute.py
+++ b/superset/reports/commands/execute.py
@@ -206,18 +206,29 @@ class BaseReportState:
             model=self._report_schedule,
         )
         user = security_manager.find_user(username)
+
         if self._report_schedule.chart:
+            window_width, window_height = app.config["WEBDRIVER_WINDOW"]["slice"]
+            window_size = (
+                self._report_schedule.custom_width or window_width,
+                self._report_schedule.custom_height or window_height,
+            )
             screenshot: Union[ChartScreenshot, DashboardScreenshot] = ChartScreenshot(
                 url,
                 self._report_schedule.chart.digest,
-                window_size=app.config["WEBDRIVER_WINDOW"]["slice"],
+                window_size=window_size,
                 thumb_size=app.config["WEBDRIVER_WINDOW"]["slice"],
             )
         else:
+            window_width, window_height = app.config["WEBDRIVER_WINDOW"]["dashboard"]
+            window_size = (
+                self._report_schedule.custom_width or window_width,
+                self._report_schedule.custom_height or window_height,
+            )
             screenshot = DashboardScreenshot(
                 url,
                 self._report_schedule.dashboard.digest,
-                window_size=app.config["WEBDRIVER_WINDOW"]["dashboard"],
+                window_size=window_size,
                 thumb_size=app.config["WEBDRIVER_WINDOW"]["dashboard"],
             )
         try: