You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@turbine.apache.org by Stephane Bailliez <st...@haht.com> on 2002/02/25 10:36:02 UTC
RE: cvs commit: jakarta-turbine-maven/src/java/org/apache/maven/j
rcs/rcs Archive.java
mmm ? I don't really understand what you imply here.
More simply why isn't this "$Header$" (okay this is compiled directly this
way) ? :)
If the original author can enlighten us about this part that would be nice,
I was ready to refactor all this in an ArchiveFormat.format() and
ArchiveFormat.clean() and move to Oro instead of gnu.regex but I'm kind of
lost about the substitution here. I'm 99% sure it is wrong but need feedback
to be sure at 100%.
> -----Original Message-----
> From: Jon Scott Stevens [mailto:jon@latchkey.com]
>
> Why isn't this ' instead of ":
>
> '$' + "Header" + '$'
>
> ??????
>
> on 2/24/02 5:52 AM, "sbailliez@apache.org"
> <sb...@apache.org> wrote:
>
> > sbailliez 02/02/24 05:52:28
> >
> > Modified: src/java/org/apache/maven/jrcs/rcs Archive.java
> > Log:
> > Fixed typo about 'RCSFile' instead of 'RCSfile'.
> > I don't understand how this part works about the
> > substitution since the sequential substitutes in the loop
> > actually never use the result of the preceding substitute call.
> >
> > Revision Changes Path
> > 1.6 +1 -1
> >
> jakarta-turbine-maven/src/java/org/apache/maven/jrcs/rcs/Archive.java
> >
> > Index: Archive.java
> > ===================================================================
> > RCS file:
> >
> /home/cvs/jakarta-turbine-maven/src/java/org/apache/maven/jrcs
> /rcs/Archive.jav
> > a,v
> > retrieving revision 1.5
> > retrieving revision 1.6
> > diff -u -r1.5 -r1.6
> > --- Archive.java 23 Feb 2002 13:48:35 -0000 1.5
> > +++ Archive.java 24 Feb 2002 13:52:28 -0000 1.6
> > @@ -832,7 +832,7 @@
> > result[i] = Id_re.substituteAll(text[i], "$" +
> "Id" + "$");
> > result[i] = Header_re.substituteAll(text[i],
> "$" + "Header" +
> > "$");
> > result[i] = Source_re.substituteAll(text[i],
> "$" + "Source" +
> > "$");
> > - result[i] = RCSfile_re.substituteAll(text[i],
> "$" + "RCSFile" +
> > "$");
> > + result[i] = RCSfile_re.substituteAll(text[i],
> "$" + "RCSfile" +
> > "$");
> > result[i] = Revision_re.substituteAll(text[i],
> "$" + "Revision" +
> > "$");
> > result[i] = Date_re.substituteAll(text[i], "$"
> + "Date" + "$");
> > result[i] = Author_re.substituteAll(text[i],
> "$" + "Author" +
> > "$");
> >
> >
> >
> >
> > --
> > To unsubscribe, e-mail:
<ma...@jakarta.apache.org>
> For additional commands, e-mail:
<ma...@jakarta.apache.org>
--
Standard rules apply: Ask any questions, and you get the job. ;-)
--
To unsubscribe, e-mail:
<ma...@jakarta.apache.org>
For additional commands, e-mail:
<ma...@jakarta.apache.org>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
[repost] Re: Unique Id Service
Posted by Kelvin Tan <ke...@relevanz.com>.
Posted this a couple days back. Trying my luck again..
----- Original Message -----
From: "Kelvin Tan" <ke...@relevanz.com>
To: "Turbine Developers List" <tu...@jakarta.apache.org>
Sent: Friday, March 01, 2002 10:11 AM
Subject: Re: Unique Id Service
>
> ----- Original Message -----
> From: "John McNally" <jm...@collab.net>
> To: "Turbine Developers List" <tu...@jakarta.apache.org>
> Sent: Friday, March 01, 2002 2:33 AM
> Subject: Re: Unique Id Service
>
>
> > Actually, I think Jason removed the service as being too simple and
> > really requiring a service implementation. There is a unique id
> > generator in torque, but it is unrelated to the service that was in 2.1.
> >
>
> Hmmm...would you or Jason like to elaborate on this? Is the algorithm for
> generating UUIDs too simple or did it require more robust lifecycle
> management functionalities (i.e a service impl)?
>
> If the algorithm too simple, perhaps someone could elaborate how so?
>
> Thanks
>
> Kelvin
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: Unique Id Service
Posted by Kelvin Tan <ke...@relevanz.com>.
----- Original Message -----
From: "John McNally" <jm...@collab.net>
To: "Turbine Developers List" <tu...@jakarta.apache.org>
Sent: Friday, March 01, 2002 2:33 AM
Subject: Re: Unique Id Service
> Actually, I think Jason removed the service as being too simple and
> really requiring a service implementation. There is a unique id
> generator in torque, but it is unrelated to the service that was in 2.1.
>
Hmmm...would you or Jason like to elaborate on this? Is the algorithm for
generating UUIDs too simple or did it require more robust lifecycle
management functionalities (i.e a service impl)?
If the algorithm too simple, perhaps someone could elaborate how so?
Thanks
Kelvin
> john mcnally
>
> Jon Scott Stevens wrote:
> >
> > on 2/28/02 8:47 AM, "James Coltman" <ja...@majorband.co.uk>
wrote:
> >
> > > What has happened to the unique id generation service that was in 2.1?
> > >
> > > Is it in Stratum, Fulcrum, or has it been removed?
> > >
> > > James
> >
> > It is in Torque.
> >
> > -jon
> >
> > --
> > To unsubscribe, e-mail:
<ma...@jakarta.apache.org>
> > For additional commands, e-mail:
<ma...@jakarta.apache.org>
>
> --
> To unsubscribe, e-mail:
<ma...@jakarta.apache.org>
> For additional commands, e-mail:
<ma...@jakarta.apache.org>
>
>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: Unique Id Service
Posted by Daniel Rall <dl...@finemaltcoding.com>.
There is a decent class for unique id generation in Commons Util
(historical note: the code dates all the way back to the early JServ
days).
John McNally <jm...@collab.net> writes:
> Actually, I think Jason removed the service as being too simple and
> really requiring a service implementation. There is a unique id
> generator in torque, but it is unrelated to the service that was in 2.1.
>
> john mcnally
>
> Jon Scott Stevens wrote:
> >
>> on 2/28/02 8:47 AM, "James Coltman" <ja...@majorband.co.uk> wrote:
>>
>> > What has happened to the unique id generation service that was in 2.1?
>> >
>> > Is it in Stratum, Fulcrum, or has it been removed?
>> >
>> > James
>>
>> It is in Torque.
>>
>> -jon
>>
>> --
>> To unsubscribe, e-mail: <ma...@jakarta.apache.org>
>> For additional commands, e-mail: <ma...@jakarta.apache.org>
>
> --
> To unsubscribe, e-mail: <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
RE: Unique Id Service
Posted by James Coltman <ja...@majorband.co.uk>.
That's what my research seemed to show. Is this something that might end up
in Stratum?
james
-----Original Message-----
From: jmcnally@localhost.localdomain
[mailto:jmcnally@localhost.localdomain]On Behalf Of John McNally
Sent: 28 February 2002 18:33
To: Turbine Developers List
Subject: Re: Unique Id Service
Actually, I think Jason removed the service as being too simple and
really requiring a service implementation. There is a unique id
generator in torque, but it is unrelated to the service that was in 2.1.
john mcnally
Jon Scott Stevens wrote:
>
> on 2/28/02 8:47 AM, "James Coltman" <ja...@majorband.co.uk> wrote:
>
> > What has happened to the unique id generation service that was in 2.1?
> >
> > Is it in Stratum, Fulcrum, or has it been removed?
> >
> > James
>
> It is in Torque.
>
> -jon
>
> --
> To unsubscribe, e-mail:
<ma...@jakarta.apache.org>
> For additional commands, e-mail:
<ma...@jakarta.apache.org>
--
To unsubscribe, e-mail:
<ma...@jakarta.apache.org>
For additional commands, e-mail:
<ma...@jakarta.apache.org>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: Unique Id Service
Posted by John McNally <jm...@collab.net>.
Actually, I think Jason removed the service as being too simple and
really requiring a service implementation. There is a unique id
generator in torque, but it is unrelated to the service that was in 2.1.
john mcnally
Jon Scott Stevens wrote:
>
> on 2/28/02 8:47 AM, "James Coltman" <ja...@majorband.co.uk> wrote:
>
> > What has happened to the unique id generation service that was in 2.1?
> >
> > Is it in Stratum, Fulcrum, or has it been removed?
> >
> > James
>
> It is in Torque.
>
> -jon
>
> --
> To unsubscribe, e-mail: <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: Unique Id Service
Posted by Jon Scott Stevens <jo...@latchkey.com>.
on 2/28/02 8:47 AM, "James Coltman" <ja...@majorband.co.uk> wrote:
> What has happened to the unique id generation service that was in 2.1?
>
> Is it in Stratum, Fulcrum, or has it been removed?
>
> James
It is in Torque.
-jon
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Unique Id Service
Posted by James Coltman <ja...@majorband.co.uk>.
What has happened to the unique id generation service that was in 2.1?
Is it in Stratum, Fulcrum, or has it been removed?
James
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
RE: [maven][jrcs] keyword substitution and regexps
Posted by Juancarlo A�ez <ju...@suigeneris.org>.
Dan,
Something else we could do is move them to an org.apache.maven.jrcs.tools package.
That would hint developers into their being tools and not entry points to the library. (I also have to write some HOW-TO documentation, of course).
Juanco
> -----Original Message-----
> From: dlr@despot.finemaltcoding.com
> [mailto:dlr@despot.finemaltcoding.com]On Behalf Of Daniel Rall
> Sent: Thursday, February 28, 2002 11:42 AM
> To: Turbine Developers List
> Subject: Re: [maven][jrcs] keyword substitution and regexps
>
>
> "Juancarlo Añez" <ju...@suigeneris.org> writes:
>
> >> JRCS.java. I'll save a copy in case someone ever needs them.
> >>
> >> Why not turn them into JUnit tests? They're half way there already.
> >
> > They currently require commandline input, and they do nothing
> that the JUnit test suite doesn't do.
> >
> > I think they're just a source of confusion.
>
> Got it, thanks for the explanation, Juanco.
>
> Dan
Re: [maven][jrcs] keyword substitution and regexps
Posted by Daniel Rall <dl...@finemaltcoding.com>.
"Juancarlo Añez" <ju...@suigeneris.org> writes:
>> JRCS.java. I'll save a copy in case someone ever needs them.
>>
>> Why not turn them into JUnit tests? They're half way there already.
>
> They currently require commandline input, and they do nothing that the JUnit test suite doesn't do.
>
> I think they're just a source of confusion.
Got it, thanks for the explanation, Juanco.
Dan
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
RE: [maven][jrcs] keyword substitution and regexps
Posted by Juancarlo A�ez <ju...@suigeneris.org>.
Daniel,
> JRCS.java. I'll save a copy in case someone ever needs them.
>
> Why not turn them into JUnit tests? They're half way there already.
They currently require commandline input, and they do nothing that the JUnit test suite doesn't do.
I think they're just a source of confusion.
Juanco
Re: [maven][jrcs] keyword substitution and regexps
Posted by Daniel Rall <dl...@finemaltcoding.com>.
"Juancarlo Añez" <ju...@suigeneris.org> writes:
> To avoid further confusions, I'd say we just remove JDiff.java and
> JRCS.java. I'll save a copy in case someone ever needs them.
Why not turn them into JUnit tests? They're half way there already.
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
RE: [maven][jrcs] keyword substitution and regexps
Posted by Juancarlo A�ez <ju...@suigeneris.org>.
> If it's just a test, can we move it to a JUnit test? Without really
> looking, I was under the impression that it was the main entry point
> to the JRCS functionality.
The main entry points to the library are .jrcs.diff.Diff for diffing functionality, and .jrcs.rcs.Archive for manipulation of RCS/CVS archives.
To avoid further confusions, I'd say we just remove JDiff.java and JRCS.java. I'll save a copy in case someone ever needs them.
Juanco
Re: [maven][jrcs] keyword substitution and regexps
Posted by Daniel Rall <dl...@finemaltcoding.com>.
"Juancarlo Añez" <ju...@suigeneris.org> writes:
>> Juanco, would you mind including this information in the JRCS.java
>> JavaDoc?
>
> Sure. But I think it should go into the package.html. JRCS.java is
> just a stub for testing the library, and so far does nothing useful.
If it's just a test, can we move it to a JUnit test? Without really
looking, I was under the impression that it was the main entry point
to the JRCS functionality.
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
RE: [maven][jrcs] keyword substitution and regexps
Posted by Juancarlo A�ez <ju...@suigeneris.org>.
Dan,
> Juanco, would you mind including this information in the JRCS.java
> JavaDoc?
Sure. But I think it should go into the package.html. JRCS.java is just a stub for testing the library, and so far does nothing useful.
Juanco
Re: [maven][jrcs] keyword substitution and regexps
Posted by Daniel Rall <dl...@finemaltcoding.com>.
"Juancarlo Añez" <ju...@suigeneris.org> writes:
> About JRCS: JRCS is a library that knows how to manipulate the archive files produced by RCS and CVS. JRCS is not intended to replace neither tool(its minuscule test suite should be a clue into that). JRCS was written to be able create archive analysis tools (identify hot spots in the source code, measure the contributions by each developer, assess how bugs make it in, and that kind of stuff). The reason why I added the ability to do check-ins to JRCS was to provide symmetry, and to simplify the writing of unit tests.
>
> CAVEAT UTILITOR: Do not make modifications to your archives with JRCS. There needs to be an important amount of additional testing before it's safe to do that.
Juanco, would you mind including this information in the JRCS.java
JavaDoc?
- Dan
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
[maven][jrcs] keyword substitution and regexps
Posted by Juancarlo A�ez <ju...@suigeneris.org>.
I just finished fixing the keyword substitution code in org.apache.maven.jrcs.rcs.Archive.
I added a JUnit test for it. Substitutions that involve dates are currently no_ being tested because I lacked the time to do it well right now (how do we handle TODOs?).
Check-ins of text with keywords substituted work correctly: Archive removes the keyword values before comparing the text to the head revision.
Jason already took care of removing GNU regexp.
About JRCS: JRCS is a library that knows how to manipulate the archive files produced by RCS and CVS. JRCS is not intended to replace neither tool(its minuscule test suite should be a clue into that). JRCS was written to be able create archive analysis tools (identify hot spots in the source code, measure the contributions by each developer, assess how bugs make it in, and that kind of stuff). The reason why I added the ability to do check-ins to JRCS was to provide symmetry, and to simplify the writing of unit tests.
CAVEAT UTILITOR: Do not make modifications to your archives with JRCS. There needs to be an important amount of additional testing before it's safe to do that.
Juanco
> -----Original Message-----
> From: Juancarlo Añez [mailto:juanca-l@suigeneris.org]
> Sent: Tuesday, February 26, 2002 9:30 AM
> To: Turbine Developers List
> Subject: CVS variable substitution in JRCS
>
>
>
> You guys are moving too fast for me. I haven't had the time to follow =
> the list yet.=20
>
> I offered Jason I'd replace the references to GNU regexp with ones to =
> Jakarta regexp (ORO is verkill). I can also take a look at the varable =
> substitution code, but I need some time.
>
> Juanco
> --
> Eng. Juancarlo A=F1ez
> mailto:juanca@suigeneris.org
> http://www.suigeneris.org/juanca/
> ---=20
>
> > -----Original Message-----
> > From: Stephane Bailliez [mailto:stephane.bailliez@haht.com]
> > Sent: Monday, February 25, 2002 5:36 AM
> > To: Turbine Developers List
> > Subject: RE: cvs commit:
> > jakarta-turbine-maven/src/java/org/apache/maven/jrcs/rcs Archive.java
> >=20
> >=20
> > mmm ? I don't really understand what you imply here.
> > More simply why isn't this "$Header$" (okay this is compiled directly =
> this
> > way) ? :)
> >=20
> > If the original author can enlighten us about this part that=20
> > would be nice,
> > I was ready to refactor all this in an ArchiveFormat.format() and
> > ArchiveFormat.clean() and move to Oro instead of gnu.regex but I'm =
> kind of
> > lost about the substitution here. I'm 99% sure it is wrong but=20
> > need feedback
> > to be sure at 100%.
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
CVS variable substitution in JRCS
Posted by Juancarlo A�ez <ju...@suigeneris.org>.
You guys are moving too fast for me. I haven't had the time to follow the list yet.
I offered Jason I'd replace the references to GNU regexp with ones to Jakarta regexp (ORO is verkill). I can also take a look at the varable substitution code, but I need some time.
Juanco
--
Eng. Juancarlo Añez
mailto:juanca@suigeneris.org
http://www.suigeneris.org/juanca/
---
> -----Original Message-----
> From: Stephane Bailliez [mailto:stephane.bailliez@haht.com]
> Sent: Monday, February 25, 2002 5:36 AM
> To: Turbine Developers List
> Subject: RE: cvs commit:
> jakarta-turbine-maven/src/java/org/apache/maven/jrcs/rcs Archive.java
>
>
> mmm ? I don't really understand what you imply here.
> More simply why isn't this "$Header$" (okay this is compiled directly this
> way) ? :)
>
> If the original author can enlighten us about this part that
> would be nice,
> I was ready to refactor all this in an ArchiveFormat.format() and
> ArchiveFormat.clean() and move to Oro instead of gnu.regex but I'm kind of
> lost about the substitution here. I'm 99% sure it is wrong but
> need feedback
> to be sure at 100%.
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>