You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metamodel.apache.org by rafaelgarrote <gi...@git.apache.org> on 2015/03/17 10:58:58 UTC

[GitHub] metamodel pull request: Delimiter in where clause in lowercase

GitHub user rafaelgarrote opened a pull request:

    https://github.com/apache/metamodel/pull/10

    Delimiter in where clause in lowercase

    I found de same problem lower/uppercase with delimiters and, or in where clause.
    I added a test that should fail without changes and pass with changes.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rafaelgarrote/metamodel master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/metamodel/pull/10.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #10
    
----
commit 78408c077d2f1a41e8a923c2264c63965deedf83
Author: Rafael Garrote <rg...@stratio.com>
Date:   2015-03-04T14:00:58Z

    updated findFilterItem method in order to find either upper and lowercase filter operator types

commit ec6b30bbb6fa6576d9ccf73383b3b537bda9b8a4
Author: Rafael Garrote <rg...@stratio.com>
Date:   2015-03-04T14:23:55Z

    updated findSelectItem method in order to find either upper and lowercase function types

commit fd851bfaa7c988ff7e10810a7c0084ef5e094f63
Author: Rafael Garrote <rg...@stratio.com>
Date:   2015-03-09T17:28:21Z

    updated parse method in order to use distinct in either upper and lower case

commit 52acb8cae92e82a51045021ade0bbc1bdbc04993
Author: Rafael Garrote <rg...@stratio.com>
Date:   2015-03-09T17:29:35Z

    Some test added to test IN, LIKE, DISTINCT, MIN, AVG... in lower case

commit 99bbcc380ff5711b13953553aedecc807027c1fe
Author: Rafael Garrote <rg...@stratio.com>
Date:   2015-03-11T16:24:04Z

    changes in DelimOcurrence to use delim either lower and upper case

commit ad3271ac36155b938aabbbdc3bbdc2fd2da0d0e2
Author: Rafael Garrote <rg...@stratio.com>
Date:   2015-03-11T17:11:54Z

    Merge branch 'master' of https://github.com/apache/metamodel

commit 0377d866baade0b54ff704a103b39f6014b936dc
Author: Rafael Garrote <rg...@stratio.com>
Date:   2015-03-17T09:55:03Z

    New test added to test Delim in where clause into lowercase

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] metamodel pull request: Delimiter in where clause in lowercase

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/metamodel/pull/10


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] metamodel pull request: Delimiter in where clause in lowercase

Posted by kaspersorensen <gi...@git.apache.org>.
Github user kaspersorensen commented on the pull request:

    https://github.com/apache/metamodel/pull/10#issuecomment-82789203
  
    Looks good to me.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---