You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2014/06/20 21:31:48 UTC
Review Request 22831: Refactored Subprocess to support execve style launch
and customized clone function.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22831/
-----------------------------------------------------------
Review request for mesos and Benjamin Hindman.
Repository: mesos-git
Description
-------
See summary.
Diffs
-----
3rdparty/libprocess/include/process/subprocess.hpp d6e2c1f
3rdparty/libprocess/src/subprocess.cpp 6ac7b5b
3rdparty/libprocess/src/tests/subprocess_tests.cpp 7dfa384
Diff: https://reviews.apache.org/r/22831/diff/
Testing
-------
make check
3rdparty/libprocess/tests --gtest_filter=*Subprocess* --gtest_repeat=100
Both Linux and Mac
Thanks,
Jie Yu
Re: Review Request 22831: Refactored Subprocess to support execve style
launch and customized clone function.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22831/
-----------------------------------------------------------
(Updated June 23, 2014, 11:33 p.m.)
Review request for mesos and Benjamin Hindman.
Changes
-------
Review comments.
Bugs: MESOS-1528
https://issues.apache.org/jira/browse/MESOS-1528
Repository: mesos-git
Description
-------
See summary.
Diffs (updated)
-----
3rdparty/libprocess/include/process/subprocess.hpp d6e2c1f
3rdparty/libprocess/src/subprocess.cpp 6ac7b5b
3rdparty/libprocess/src/tests/subprocess_tests.cpp 7dfa384
Diff: https://reviews.apache.org/r/22831/diff/
Testing
-------
make check
3rdparty/libprocess/tests --gtest_filter=*Subprocess* --gtest_repeat=100
Both Linux and Mac
Thanks,
Jie Yu
Re: Review Request 22831: Refactored Subprocess to support execve style
launch and customized clone function.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22831/#review46426
-----------------------------------------------------------
Ship it!
3rdparty/libprocess/src/subprocess.cpp
<https://reviews.apache.org/r/22831/#comment81812>
Feel free to not make this a const & and just do the copy up front.
3rdparty/libprocess/src/subprocess.cpp
<https://reviews.apache.org/r/22831/#comment81814>
Same here, feel free to do the copy up front.
- Benjamin Hindman
On June 21, 2014, 4:49 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22831/
> -----------------------------------------------------------
>
> (Updated June 21, 2014, 4:49 a.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Bugs: MESOS-1528
> https://issues.apache.org/jira/browse/MESOS-1528
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/subprocess.hpp d6e2c1f
> 3rdparty/libprocess/src/subprocess.cpp 6ac7b5b
> 3rdparty/libprocess/src/tests/subprocess_tests.cpp 7dfa384
>
> Diff: https://reviews.apache.org/r/22831/diff/
>
>
> Testing
> -------
>
> make check
> 3rdparty/libprocess/tests --gtest_filter=*Subprocess* --gtest_repeat=100
>
> Both Linux and Mac
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 22831: Refactored Subprocess to support execve style
launch and customized clone function.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22831/
-----------------------------------------------------------
(Updated June 21, 2014, 4:49 a.m.)
Review request for mesos and Benjamin Hindman.
Changes
-------
Changed "clone" function signature.
Bugs: MESOS-1528
https://issues.apache.org/jira/browse/MESOS-1528
Repository: mesos-git
Description
-------
See summary.
Diffs (updated)
-----
3rdparty/libprocess/include/process/subprocess.hpp d6e2c1f
3rdparty/libprocess/src/subprocess.cpp 6ac7b5b
3rdparty/libprocess/src/tests/subprocess_tests.cpp 7dfa384
Diff: https://reviews.apache.org/r/22831/diff/
Testing
-------
make check
3rdparty/libprocess/tests --gtest_filter=*Subprocess* --gtest_repeat=100
Both Linux and Mac
Thanks,
Jie Yu