You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/10/22 14:18:38 UTC
[GitHub] [incubator-superset] dpgaspar opened a new pull request #11391: feat: saved queries with execution info
dpgaspar opened a new pull request #11391:
URL: https://github.com/apache/incubator-superset/pull/11391
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11391: feat: saved queries with execution info
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11391:
URL: https://github.com/apache/incubator-superset/pull/11391#issuecomment-714562122
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=h1) Report
> Merging [#11391](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/73690397139440a509eda74740bfd5ac6ed596db?el=desc) will **decrease** coverage by `4.13%`.
> The diff coverage is `67.50%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11391 +/- ##
==========================================
- Coverage 65.75% 61.62% -4.14%
==========================================
Files 838 839 +1
Lines 39714 39940 +226
Branches 3613 3662 +49
==========================================
- Hits 26115 24612 -1503
- Misses 13498 15147 +1649
- Partials 101 181 +80
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.67% <ø> (+0.06%)` | :arrow_up: |
| #python | `60.99% <67.50%> (+0.07%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ons/585b0b1a7b18\_add\_exec\_info\_to\_saved\_queries.py](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy81ODViMGIxYTdiMThfYWRkX2V4ZWNfaW5mb190b19zYXZlZF9xdWVyaWVzLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <ø> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.57% <75.00%> (+0.10%)` | :arrow_up: |
| [superset/models/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF9sYWIucHk=) | `90.84% <92.30%> (+0.14%)` | :arrow_up: |
| [superset/queries/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9kYW8ucHk=) | `100.00% <100.00%> (+100.00%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [198 more](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=footer). Last update [7369039...6c176c3](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on pull request #11391: feat: saved queries with execution info
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #11391:
URL: https://github.com/apache/incubator-superset/pull/11391#issuecomment-714562122
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=h1) Report
> Merging [#11391](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/73690397139440a509eda74740bfd5ac6ed596db?el=desc) will **decrease** coverage by `5.62%`.
> The diff coverage is `65.85%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11391 +/- ##
==========================================
- Coverage 65.75% 60.13% -5.63%
==========================================
Files 838 395 -443
Lines 39714 25000 -14714
Branches 3613 0 -3613
==========================================
- Hits 26115 15033 -11082
+ Misses 13498 9967 -3531
+ Partials 101 0 -101
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `60.13% <65.85%> (-0.79%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ons/585b0b1a7b18\_add\_exec\_info\_to\_saved\_queries.py](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy81ODViMGIxYTdiMThfYWRkX2V4ZWNfaW5mb190b19zYXZlZF9xdWVyaWVzLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <ø> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `70.76% <80.00%> (-3.71%)` | :arrow_down: |
| [superset/models/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF9sYWIucHk=) | `90.14% <84.61%> (-0.56%)` | :arrow_down: |
| [superset/queries/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9kYW8ucHk=) | `100.00% <100.00%> (+100.00%)` | :arrow_up: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.30% <0.00%> (-25.14%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `82.97% <0.00%> (-8.52%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.65% <0.00%> (-8.43%)` | :arrow_down: |
| ... and [473 more](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=footer). Last update [7369039...db5cdde](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11391: feat: saved queries with execution info
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11391:
URL: https://github.com/apache/incubator-superset/pull/11391#issuecomment-714562122
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=h1) Report
> Merging [#11391](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/73690397139440a509eda74740bfd5ac6ed596db?el=desc) will **decrease** coverage by `5.08%`.
> The diff coverage is `65.85%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11391 +/- ##
==========================================
- Coverage 65.75% 60.66% -5.09%
==========================================
Files 838 395 -443
Lines 39714 25011 -14703
Branches 3613 0 -3613
==========================================
- Hits 26115 15174 -10941
+ Misses 13498 9837 -3661
+ Partials 101 0 -101
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `60.66% <65.85%> (-0.25%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ons/585b0b1a7b18\_add\_exec\_info\_to\_saved\_queries.py](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy81ODViMGIxYTdiMThfYWRkX2V4ZWNfaW5mb190b19zYXZlZF9xdWVyaWVzLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <ø> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `71.98% <80.00%> (-2.49%)` | :arrow_down: |
| [superset/models/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF9sYWIucHk=) | `90.14% <84.61%> (-0.56%)` | :arrow_down: |
| [superset/queries/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9kYW8ucHk=) | `100.00% <100.00%> (+100.00%)` | :arrow_up: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `82.97% <0.00%> (-8.52%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
| ... and [464 more](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=footer). Last update [7369039...db5cdde](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11391: feat: saved queries with execution info
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11391:
URL: https://github.com/apache/incubator-superset/pull/11391#issuecomment-714562122
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=h1) Report
> Merging [#11391](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/73690397139440a509eda74740bfd5ac6ed596db?el=desc) will **decrease** coverage by `4.12%`.
> The diff coverage is `67.50%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11391 +/- ##
==========================================
- Coverage 65.75% 61.62% -4.13%
==========================================
Files 838 839 +1
Lines 39714 39940 +226
Branches 3613 3662 +49
==========================================
- Hits 26115 24615 -1500
- Misses 13498 15144 +1646
- Partials 101 181 +80
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.67% <ø> (+0.06%)` | :arrow_up: |
| #python | `61.00% <67.50%> (+0.09%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ons/585b0b1a7b18\_add\_exec\_info\_to\_saved\_queries.py](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy81ODViMGIxYTdiMThfYWRkX2V4ZWNfaW5mb190b19zYXZlZF9xdWVyaWVzLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <ø> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.57% <75.00%> (+0.10%)` | :arrow_up: |
| [superset/models/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF9sYWIucHk=) | `90.84% <92.30%> (+0.14%)` | :arrow_up: |
| [superset/queries/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9kYW8ucHk=) | `100.00% <100.00%> (+100.00%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [197 more](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=footer). Last update [7369039...6c176c3](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on pull request #11391: feat: saved queries with execution info
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on pull request #11391:
URL: https://github.com/apache/incubator-superset/pull/11391#issuecomment-716476705
> Did we consider having this as a foreign key to the query table? There are probably pros/cons here.
@mistercrunch
I have considered using a custom SQLAlchemy relation on SavedQuery, but I think is not clean since there is no relation between savedqueries and queries, this is kind of an best effort. But more importantly using a relation on savedquery to join query is expensive (since query table grows a lot and we are joining by `sql` text field).
I think that this write approach is light and not too "evasive"
Thoughts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11391: feat: saved queries with execution info
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11391:
URL: https://github.com/apache/incubator-superset/pull/11391#issuecomment-714562122
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=h1) Report
> Merging [#11391](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/73690397139440a509eda74740bfd5ac6ed596db?el=desc) will **decrease** coverage by `10.54%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11391 +/- ##
===========================================
- Coverage 65.75% 55.21% -10.55%
===========================================
Files 838 406 -432
Lines 39714 13601 -26113
Branches 3613 3450 -163
===========================================
- Hits 26115 7510 -18605
+ Misses 13498 5913 -7585
- Partials 101 178 +77
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.21% <ø> (-1.20%)` | :arrow_down: |
| #javascript | `?` | |
| #python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/components/Menu/LanguagePicker.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9MYW5ndWFnZVBpY2tlci50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...d/src/views/CRUD/csstemplates/CssTemplatesList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY3NzdGVtcGxhdGVzL0Nzc1RlbXBsYXRlc0xpc3QudHN4) | `1.29% <0.00%> (-96.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...uperset-frontend/src/utils/getClientErrorObject.ts](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldENsaWVudEVycm9yT2JqZWN0LnRz) | `0.00% <0.00%> (-89.19%)` | :arrow_down: |
| [.../src/dashboard/components/FilterIndicatorGroup.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlckluZGljYXRvckdyb3VwLmpzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...c/explore/components/controls/withVerification.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy93aXRoVmVyaWZpY2F0aW9uLmpzeA==) | `9.09% <0.00%> (-87.88%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| ... and [652 more](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=footer). Last update [7369039...6c176c3](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11391: feat: saved queries with execution info
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11391:
URL: https://github.com/apache/incubator-superset/pull/11391#issuecomment-714562122
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=h1) Report
> Merging [#11391](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/73690397139440a509eda74740bfd5ac6ed596db?el=desc) will **decrease** coverage by `4.39%`.
> The diff coverage is `67.50%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11391 +/- ##
==========================================
- Coverage 65.75% 61.36% -4.40%
==========================================
Files 838 839 +1
Lines 39714 39940 +226
Branches 3613 3662 +49
==========================================
- Hits 26115 24510 -1605
- Misses 13498 15249 +1751
- Partials 101 181 +80
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.67% <ø> (+0.06%)` | :arrow_up: |
| #python | `60.58% <67.50%> (-0.33%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ons/585b0b1a7b18\_add\_exec\_info\_to\_saved\_queries.py](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy81ODViMGIxYTdiMThfYWRkX2V4ZWNfaW5mb190b19zYXZlZF9xdWVyaWVzLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <ø> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.57% <75.00%> (+0.10%)` | :arrow_up: |
| [superset/models/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF9sYWIucHk=) | `90.84% <92.30%> (+0.14%)` | :arrow_up: |
| [superset/queries/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9kYW8ucHk=) | `100.00% <100.00%> (+100.00%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [200 more](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=footer). Last update [7369039...6c176c3](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on pull request #11391: feat: saved queries with execution info
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on pull request #11391:
URL: https://github.com/apache/incubator-superset/pull/11391#issuecomment-715412144
Did we consider having this as a foreign key to the query table? There are probably pros/cons here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11391: feat: saved queries with execution info
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11391:
URL: https://github.com/apache/incubator-superset/pull/11391#issuecomment-714562122
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=h1) Report
> Merging [#11391](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/73690397139440a509eda74740bfd5ac6ed596db?el=desc) will **decrease** coverage by `3.08%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11391 +/- ##
==========================================
- Coverage 65.75% 62.67% -3.09%
==========================================
Files 838 444 -394
Lines 39714 14929 -24785
Branches 3613 3662 +49
==========================================
- Hits 26115 9357 -16758
+ Misses 13498 5391 -8107
- Partials 101 181 +80
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.67% <ø> (+0.06%)` | :arrow_up: |
| #python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupPluginsExtra.js](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwUGx1Z2luc0V4dHJhLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [568 more](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=footer). Last update [7369039...6c176c3](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11391: feat: saved queries with execution info
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11391:
URL: https://github.com/apache/incubator-superset/pull/11391#issuecomment-714562122
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=h1) Report
> Merging [#11391](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/73690397139440a509eda74740bfd5ac6ed596db?el=desc) will **decrease** coverage by `6.78%`.
> The diff coverage is `65.85%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11391 +/- ##
==========================================
- Coverage 65.75% 58.97% -6.79%
==========================================
Files 838 801 -37
Lines 39714 38612 -1102
Branches 3613 3450 -163
==========================================
- Hits 26115 22772 -3343
- Misses 13498 15670 +2172
- Partials 101 170 +69
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.86% <ø> (-0.55%)` | :arrow_down: |
| #javascript | `?` | |
| #python | `60.66% <65.85%> (-0.25%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ons/585b0b1a7b18\_add\_exec\_info\_to\_saved\_queries.py](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy81ODViMGIxYTdiMThfYWRkX2V4ZWNfaW5mb190b19zYXZlZF9xdWVyaWVzLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <ø> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `71.98% <80.00%> (-2.49%)` | :arrow_down: |
| [superset/models/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF9sYWIucHk=) | `90.14% <84.61%> (-0.56%)` | :arrow_down: |
| [superset/queries/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9kYW8ucHk=) | `100.00% <100.00%> (+100.00%)` | :arrow_up: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/components/Menu/LanguagePicker.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9MYW5ndWFnZVBpY2tlci50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...d/src/views/CRUD/csstemplates/CssTemplatesList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY3NzdGVtcGxhdGVzL0Nzc1RlbXBsYXRlc0xpc3QudHN4) | `1.29% <0.00%> (-96.00%)` | :arrow_down: |
| ... and [290 more](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=footer). Last update [7369039...db5cdde](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] willbarrett merged pull request #11391: feat: saved queries with execution info
Posted by GitBox <gi...@apache.org>.
willbarrett merged pull request #11391:
URL: https://github.com/apache/incubator-superset/pull/11391
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on a change in pull request #11391: feat: saved queries with execution info
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #11391:
URL: https://github.com/apache/incubator-superset/pull/11391#discussion_r511751340
##########
File path: tests/sqllab_tests.py
##########
@@ -71,6 +71,36 @@ def test_sql_json(self):
data = self.run_sql("SELECT * FROM unexistant_table", "2")
self.assertLess(0, len(data["error"]))
+ def test_sql_json_to_saved_query_info(self):
+ """
+ SQLLab: Test SQLLab query execution info propagation to saved queries
+ """
+ from freezegun import freeze_time
+
+ self.login("admin")
+
+ sql_statement = "SELECT * FROM birth_names LIMIT 10"
+ examples_db_id = get_example_database().id
+ saved_query = SavedQuery(db_id=examples_db_id, sql=sql_statement)
+ db.session.add(saved_query)
+ db.session.commit()
+
+ with freeze_time("2020-01-01T00:00:00Z"):
+ self.run_sql(sql_statement, "1")
+ saved_query_ = (
+ db.session.query(SavedQuery)
+ .filter(
+ SavedQuery.db_id == examples_db_id, SavedQuery.sql == sql_statement
+ )
+ .one_or_none()
+ )
+ assert saved_query_.rows is not None
+ assert saved_query_.last_run == datetime.now()
+
+ # Rollback changes
+ db.session.delete(saved_query_)
Review comment:
Nit: I wonder if it were cleaner to just do `db.session.add(SavedQuery(db_id=examples_db_id, sql=sql_statement))` in the beginning, and later name the the queried `SavedQuery` without the trailing underscore, as the original `saved_query` isn't really reused.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11391: feat: saved queries with execution info
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11391:
URL: https://github.com/apache/incubator-superset/pull/11391#issuecomment-714562122
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=h1) Report
> Merging [#11391](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/73690397139440a509eda74740bfd5ac6ed596db?el=desc) will **decrease** coverage by `4.58%`.
> The diff coverage is `67.50%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11391 +/- ##
==========================================
- Coverage 65.75% 61.17% -4.59%
==========================================
Files 838 839 +1
Lines 39714 39929 +215
Branches 3613 3662 +49
==========================================
- Hits 26115 24426 -1689
- Misses 13498 15322 +1824
- Partials 101 181 +80
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.67% <ø> (+0.06%)` | :arrow_up: |
| #python | `60.27% <67.50%> (-0.64%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ons/585b0b1a7b18\_add\_exec\_info\_to\_saved\_queries.py](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy81ODViMGIxYTdiMThfYWRkX2V4ZWNfaW5mb190b19zYXZlZF9xdWVyaWVzLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <ø> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.57% <75.00%> (+0.10%)` | :arrow_up: |
| [superset/models/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF9sYWIucHk=) | `90.84% <92.30%> (+0.14%)` | :arrow_up: |
| [superset/queries/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9kYW8ucHk=) | `100.00% <100.00%> (+100.00%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [210 more](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=footer). Last update [7369039...6c176c3](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11391: feat: saved queries with execution info
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11391:
URL: https://github.com/apache/incubator-superset/pull/11391#issuecomment-714562122
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=h1) Report
> Merging [#11391](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/73690397139440a509eda74740bfd5ac6ed596db?el=desc) will **decrease** coverage by `7.00%`.
> The diff coverage is `65.85%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11391 +/- ##
==========================================
- Coverage 65.75% 58.74% -7.01%
==========================================
Files 838 801 -37
Lines 39714 38612 -1102
Branches 3613 3450 -163
==========================================
- Hits 26115 22684 -3431
- Misses 13498 15750 +2252
- Partials 101 178 +77
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.21% <ø> (-1.20%)` | :arrow_down: |
| #javascript | `?` | |
| #python | `60.66% <65.85%> (-0.25%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ons/585b0b1a7b18\_add\_exec\_info\_to\_saved\_queries.py](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy81ODViMGIxYTdiMThfYWRkX2V4ZWNfaW5mb190b19zYXZlZF9xdWVyaWVzLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <ø> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `71.98% <80.00%> (-2.49%)` | :arrow_down: |
| [superset/models/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF9sYWIucHk=) | `90.14% <84.61%> (-0.56%)` | :arrow_down: |
| [superset/queries/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9kYW8ucHk=) | `100.00% <100.00%> (+100.00%)` | :arrow_up: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/components/Menu/LanguagePicker.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9MYW5ndWFnZVBpY2tlci50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...d/src/views/CRUD/csstemplates/CssTemplatesList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY3NzdGVtcGxhdGVzL0Nzc1RlbXBsYXRlc0xpc3QudHN4) | `1.29% <0.00%> (-96.00%)` | :arrow_down: |
| ... and [292 more](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=footer). Last update [7369039...db5cdde](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11391: feat: saved queries with execution info
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11391:
URL: https://github.com/apache/incubator-superset/pull/11391#issuecomment-714562122
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=h1) Report
> Merging [#11391](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/73690397139440a509eda74740bfd5ac6ed596db?el=desc) will **decrease** coverage by `4.41%`.
> The diff coverage is `67.50%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11391 +/- ##
==========================================
- Coverage 65.75% 61.34% -4.42%
==========================================
Files 838 839 +1
Lines 39714 39940 +226
Branches 3613 3662 +49
==========================================
- Hits 26115 24502 -1613
- Misses 13498 15257 +1759
- Partials 101 181 +80
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.67% <ø> (+0.06%)` | :arrow_up: |
| #python | `60.55% <67.50%> (-0.37%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ons/585b0b1a7b18\_add\_exec\_info\_to\_saved\_queries.py](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy81ODViMGIxYTdiMThfYWRkX2V4ZWNfaW5mb190b19zYXZlZF9xdWVyaWVzLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <ø> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.57% <75.00%> (+0.10%)` | :arrow_up: |
| [superset/models/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF9sYWIucHk=) | `90.84% <92.30%> (+0.14%)` | :arrow_up: |
| [superset/queries/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9kYW8ucHk=) | `100.00% <100.00%> (+100.00%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [204 more](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=footer). Last update [7369039...6c176c3](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11391: feat: saved queries with execution info
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11391:
URL: https://github.com/apache/incubator-superset/pull/11391#issuecomment-714562122
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=h1) Report
> Merging [#11391](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/73690397139440a509eda74740bfd5ac6ed596db?el=desc) will **decrease** coverage by `9.89%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11391 +/- ##
==========================================
- Coverage 65.75% 55.86% -9.90%
==========================================
Files 838 406 -432
Lines 39714 13601 -26113
Branches 3613 3450 -163
==========================================
- Hits 26115 7598 -18517
+ Misses 13498 5833 -7665
- Partials 101 170 +69
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.86% <ø> (-0.55%)` | :arrow_down: |
| #javascript | `?` | |
| #python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/components/Menu/LanguagePicker.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9MYW5ndWFnZVBpY2tlci50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...d/src/views/CRUD/csstemplates/CssTemplatesList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY3NzdGVtcGxhdGVzL0Nzc1RlbXBsYXRlc0xpc3QudHN4) | `1.29% <0.00%> (-96.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...uperset-frontend/src/utils/getClientErrorObject.ts](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldENsaWVudEVycm9yT2JqZWN0LnRz) | `0.00% <0.00%> (-89.19%)` | :arrow_down: |
| [.../src/dashboard/components/FilterIndicatorGroup.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlckluZGljYXRvckdyb3VwLmpzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...c/explore/components/controls/withVerification.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy93aXRoVmVyaWZpY2F0aW9uLmpzeA==) | `9.09% <0.00%> (-87.88%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| ... and [650 more](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=footer). Last update [7369039...6c176c3](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #11391: feat: saved queries with execution info
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on a change in pull request #11391:
URL: https://github.com/apache/incubator-superset/pull/11391#discussion_r511876055
##########
File path: tests/sqllab_tests.py
##########
@@ -71,6 +71,36 @@ def test_sql_json(self):
data = self.run_sql("SELECT * FROM unexistant_table", "2")
self.assertLess(0, len(data["error"]))
+ def test_sql_json_to_saved_query_info(self):
+ """
+ SQLLab: Test SQLLab query execution info propagation to saved queries
+ """
+ from freezegun import freeze_time
+
+ self.login("admin")
+
+ sql_statement = "SELECT * FROM birth_names LIMIT 10"
+ examples_db_id = get_example_database().id
+ saved_query = SavedQuery(db_id=examples_db_id, sql=sql_statement)
+ db.session.add(saved_query)
+ db.session.commit()
+
+ with freeze_time("2020-01-01T00:00:00Z"):
+ self.run_sql(sql_statement, "1")
+ saved_query_ = (
+ db.session.query(SavedQuery)
+ .filter(
+ SavedQuery.db_id == examples_db_id, SavedQuery.sql == sql_statement
+ )
+ .one_or_none()
+ )
+ assert saved_query_.rows is not None
+ assert saved_query_.last_run == datetime.now()
+
+ # Rollback changes
+ db.session.delete(saved_query_)
Review comment:
Would look better, yes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11391: feat: saved queries with execution info
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11391:
URL: https://github.com/apache/incubator-superset/pull/11391#issuecomment-714562122
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=h1) Report
> Merging [#11391](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/73690397139440a509eda74740bfd5ac6ed596db?el=desc) will **decrease** coverage by `5.64%`.
> The diff coverage is `65.85%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11391 +/- ##
==========================================
- Coverage 65.75% 60.11% -5.65%
==========================================
Files 838 395 -443
Lines 39714 25011 -14703
Branches 3613 0 -3613
==========================================
- Hits 26115 15036 -11079
+ Misses 13498 9975 -3523
+ Partials 101 0 -101
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `60.11% <65.85%> (-0.80%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ons/585b0b1a7b18\_add\_exec\_info\_to\_saved\_queries.py](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy81ODViMGIxYTdiMThfYWRkX2V4ZWNfaW5mb190b19zYXZlZF9xdWVyaWVzLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <ø> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `70.76% <80.00%> (-3.71%)` | :arrow_down: |
| [superset/models/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF9sYWIucHk=) | `90.14% <84.61%> (-0.56%)` | :arrow_down: |
| [superset/queries/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9kYW8ucHk=) | `100.00% <100.00%> (+100.00%)` | :arrow_up: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.30% <0.00%> (-25.14%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `82.97% <0.00%> (-8.52%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.65% <0.00%> (-8.43%)` | :arrow_down: |
| ... and [470 more](https://codecov.io/gh/apache/incubator-superset/pull/11391/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=footer). Last update [7369039...db5cdde](https://codecov.io/gh/apache/incubator-superset/pull/11391?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org