You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/05/11 07:19:52 UTC
[GitHub] [dubbo-go-pixiu] mark4z opened a new pull request #155: update dubbo-go to v1.5.6 & fmt sth.
mark4z opened a new pull request #155:
URL: https://github.com/apache/dubbo-go-pixiu/pull/155
<!-- Thanks for sending a pull request!
-->
**What this PR does**:
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #151
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #155: update dubbo-go to v1.5.6 & fmt sth.
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #155:
URL: https://github.com/apache/dubbo-go-pixiu/pull/155#issuecomment-823914528
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/155?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#155](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/155?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2dd2b8e) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/c5f9fc40449bc44462d3e96a3668630b0396c04f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c5f9fc4) will **not change** coverage.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/155?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #155 +/- ##
========================================
Coverage 40.60% 40.60%
========================================
Files 35 35
Lines 1692 1692
========================================
Hits 687 687
Misses 903 903
Partials 102 102
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/155?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/registry/consul.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/155/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3JlZ2lzdHJ5L2NvbnN1bC5nbw==) | `78.94% <ø> (ø)` | |
| [pkg/registry/util.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/155/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3JlZ2lzdHJ5L3V0aWwuZ28=) | `0.00% <ø> (ø)` | |
| [pkg/registry/zookeeper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/155/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3JlZ2lzdHJ5L3pvb2tlZXBlci5nbw==) | `55.55% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/155?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/155?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c5f9fc4...2dd2b8e](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/155?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] mark4z closed pull request #155: update dubbo-go to v1.5.6 & fmt sth.
Posted by GitBox <gi...@apache.org>.
mark4z closed pull request #155:
URL: https://github.com/apache/dubbo-go-pixiu/pull/155
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #155: update dubbo-go to v1.5.6 & fmt sth.
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #155:
URL: https://github.com/apache/dubbo-go-pixiu/pull/155#issuecomment-823914528
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/155?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#155](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/155?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0547c78) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/985a285d29025c5e55c0407fc84f32a3b16d2e91?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (985a285) will **not change** coverage.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/155?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #155 +/- ##
========================================
Coverage 40.60% 40.60%
========================================
Files 35 35
Lines 1692 1692
========================================
Hits 687 687
Misses 903 903
Partials 102 102
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/155?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/registry/consul.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/155/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3JlZ2lzdHJ5L2NvbnN1bC5nbw==) | `78.94% <ø> (ø)` | |
| [pkg/registry/util.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/155/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3JlZ2lzdHJ5L3V0aWwuZ28=) | `0.00% <ø> (ø)` | |
| [pkg/registry/zookeeper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/155/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3JlZ2lzdHJ5L3pvb2tlZXBlci5nbw==) | `55.55% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/155?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/155?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [985a285...0547c78](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/155?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter commented on pull request #155: update dubbo-go to v1.5.6 & fmt sth.
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #155:
URL: https://github.com/apache/dubbo-go-pixiu/pull/155#issuecomment-823914528
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/155?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#155](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/155?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (980669a) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/a16efb1ffe394d42dc8ec0f8b77bf3428d5eacd5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a16efb1) will **not change** coverage.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/155?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #155 +/- ##
========================================
Coverage 40.60% 40.60%
========================================
Files 35 35
Lines 1692 1692
========================================
Hits 687 687
Misses 903 903
Partials 102 102
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/155?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/registry/consul.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/155/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3JlZ2lzdHJ5L2NvbnN1bC5nbw==) | `78.94% <ø> (ø)` | |
| [pkg/registry/util.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/155/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3JlZ2lzdHJ5L3V0aWwuZ28=) | `0.00% <ø> (ø)` | |
| [pkg/registry/zookeeper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/155/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3JlZ2lzdHJ5L3pvb2tlZXBlci5nbw==) | `55.55% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/155?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/155?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a16efb1...980669a](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/155?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] AlexStocks commented on a change in pull request #155: update dubbo-go to v1.5.6 & fmt sth.
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #155:
URL: https://github.com/apache/dubbo-go-pixiu/pull/155#discussion_r617969013
##########
File path: go.mod
##########
@@ -3,22 +3,26 @@ module github.com/apache/dubbo-go-pixiu
go 1.14
require (
- github.com/apache/dubbo-go v1.5.5
- github.com/apache/dubbo-go-hessian2 v1.7.0
+ github.com/apache/dubbo-go v1.5.6
+ github.com/apache/dubbo-go-hessian2 v1.9.1
Review comment:
pls update hessian2 version to 1.9.2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] mark4z closed pull request #155: update dubbo-go to v1.5.7-rc1 & fmt sth.
Posted by GitBox <gi...@apache.org>.
mark4z closed pull request #155:
URL: https://github.com/apache/dubbo-go-pixiu/pull/155
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #155: update dubbo-go to v1.5.7-rc1 & fmt sth.
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #155:
URL: https://github.com/apache/dubbo-go-pixiu/pull/155#issuecomment-823914528
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/155?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#155](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/155?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8a6dae2) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/2173648f31aa3d63c7dcf0aeac5986344994fd52?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2173648) will **not change** coverage.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/155?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #155 +/- ##
========================================
Coverage 42.30% 42.30%
========================================
Files 33 33
Lines 1742 1742
========================================
Hits 737 737
Misses 904 904
Partials 101 101
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/155?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/registry/consul.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/155/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3JlZ2lzdHJ5L2NvbnN1bC5nbw==) | `78.94% <ø> (ø)` | |
| [pkg/registry/util.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/155/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3JlZ2lzdHJ5L3V0aWwuZ28=) | `0.00% <ø> (ø)` | |
| [pkg/registry/zookeeper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/155/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3JlZ2lzdHJ5L3pvb2tlZXBlci5nbw==) | `55.55% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/155?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/155?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [2173648...8a6dae2](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/155?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #155: update dubbo-go to v1.5.6 & fmt sth.
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #155:
URL: https://github.com/apache/dubbo-go-pixiu/pull/155#issuecomment-823914528
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/155?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#155](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/155?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (172ad82) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/c5f9fc40449bc44462d3e96a3668630b0396c04f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c5f9fc4) will **not change** coverage.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/155?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #155 +/- ##
========================================
Coverage 40.60% 40.60%
========================================
Files 35 35
Lines 1692 1692
========================================
Hits 687 687
Misses 903 903
Partials 102 102
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/155?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/registry/consul.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/155/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3JlZ2lzdHJ5L2NvbnN1bC5nbw==) | `78.94% <ø> (ø)` | |
| [pkg/registry/util.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/155/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3JlZ2lzdHJ5L3V0aWwuZ28=) | `0.00% <ø> (ø)` | |
| [pkg/registry/zookeeper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/155/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3JlZ2lzdHJ5L3pvb2tlZXBlci5nbw==) | `55.55% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/155?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/155?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c5f9fc4...172ad82](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/155?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #155: update dubbo-go to v1.5.7-rc1 & fmt sth.
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #155:
URL: https://github.com/apache/dubbo-go-pixiu/pull/155#issuecomment-823914528
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/155?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#155](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/155?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f0e7b70) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/5c98b5e42d4303306b73b1cf663de5e47f49700c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5c98b5e) will **not change** coverage.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/155?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #155 +/- ##
========================================
Coverage 43.19% 43.19%
========================================
Files 33 33
Lines 1755 1755
========================================
Hits 758 758
Misses 888 888
Partials 109 109
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/155?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/registry/consul.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/155/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3JlZ2lzdHJ5L2NvbnN1bC5nbw==) | `78.94% <ø> (ø)` | |
| [pkg/registry/util.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/155/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3JlZ2lzdHJ5L3V0aWwuZ28=) | `0.00% <ø> (ø)` | |
| [pkg/registry/zookeeper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/155/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3JlZ2lzdHJ5L3pvb2tlZXBlci5nbw==) | `55.55% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/155?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/155?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [5c98b5e...f0e7b70](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/155?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] AlexStocks commented on a change in pull request #155: update dubbo-go to v1.5.6 & fmt sth.
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #155:
URL: https://github.com/apache/dubbo-go-pixiu/pull/155#discussion_r617969491
##########
File path: go.mod
##########
@@ -3,22 +3,26 @@ module github.com/apache/dubbo-go-pixiu
go 1.14
require (
- github.com/apache/dubbo-go v1.5.5
- github.com/apache/dubbo-go-hessian2 v1.7.0
+ github.com/apache/dubbo-go v1.5.6
+ github.com/apache/dubbo-go-hessian2 v1.9.1
github.com/coreos/etcd v3.3.25+incompatible
github.com/dubbogo/dubbo-go-pixiu-filter v0.1.3
- github.com/dubbogo/go-zookeeper v1.0.2
+ github.com/dubbogo/go-zookeeper v1.0.3
+ github.com/dubbogo/gost v1.11.2
Review comment:
update it to 1.11.7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org