You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Manfred Baedke (JIRA)" <ji...@apache.org> on 2012/10/09 16:13:03 UTC
[jira] [Created] (JCR-3439) PrincipalManagerImpl.CheckedGroup
should implement JackrabbitPrincipal
Manfred Baedke created JCR-3439:
-----------------------------------
Summary: PrincipalManagerImpl.CheckedGroup should implement JackrabbitPrincipal
Key: JCR-3439
URL: https://issues.apache.org/jira/browse/JCR-3439
Project: Jackrabbit Content Repository
Issue Type: Bug
Components: jackrabbit-core
Reporter: Manfred Baedke
Find a detailed discussion and a proposed patch at https://issues.adobe.com/browse/CRX-4225
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (JCR-3439) PrincipalManagerImpl.CheckedGroup
should implement JackrabbitPrincipal
Posted by "Julian Reschke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Julian Reschke updated JCR-3439:
--------------------------------
Description: otherwise org.apache.jackrabbit.api.security.principal.JackrabbitPrincipal won't do the right thing on equals(). (was: (see subject))
> PrincipalManagerImpl.CheckedGroup should implement JackrabbitPrincipal
> ----------------------------------------------------------------------
>
> Key: JCR-3439
> URL: https://issues.apache.org/jira/browse/JCR-3439
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-core
> Reporter: Manfred Baedke
>
> otherwise org.apache.jackrabbit.api.security.principal.JackrabbitPrincipal won't do the right thing on equals().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (JCR-3439) PrincipalManagerImpl.CheckedGroup
should implement JackrabbitPrincipal
Posted by "Julian Reschke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Julian Reschke reopened JCR-3439:
---------------------------------
re-opening as the test class requires JDK 1.6 and thus does not compile in 2.2 and 2.4 when the "proper" JDK is used
> PrincipalManagerImpl.CheckedGroup should implement JackrabbitPrincipal
> ----------------------------------------------------------------------
>
> Key: JCR-3439
> URL: https://issues.apache.org/jira/browse/JCR-3439
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-core
> Affects Versions: 2.2.13, 2.4.3
> Reporter: Manfred Baedke
> Assignee: Julian Reschke
> Fix For: 2.2.14, 2.4.4, 2.6
>
> Attachments: jcr-3439.patch
>
>
> otherwise org.apache.jackrabbit.api.security.principal.JackrabbitPrincipal won't do the right thing on equals().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (JCR-3439)
PrincipalManagerImpl.CheckedGroup should implement JackrabbitPrincipal
Posted by "angela (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485007#comment-13485007 ]
angela edited comment on JCR-3439 at 10/26/12 3:38 PM:
-------------------------------------------------------
what prevents you from creating a test in the principal package space that creates a PrincipalManager instance based on
the regular and in addition a custom test-principal provider. the latter would just expose your test principal and would
not make the ItemBasedPrincipal? IMO that should be really straight forward, shouldn't it?
was (Author: anchela):
what prevents you from creating a test in the principal package space that creates a PrincipalManager instance based on
the regular and in addition a custom test-principal provider. the latter would just expose your test principal and would
not make the ItemBasedPrincipal? IMO that should be really straight forward, wouldn't it?
> PrincipalManagerImpl.CheckedGroup should implement JackrabbitPrincipal
> ----------------------------------------------------------------------
>
> Key: JCR-3439
> URL: https://issues.apache.org/jira/browse/JCR-3439
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-core
> Reporter: Manfred Baedke
>
> otherwise org.apache.jackrabbit.api.security.principal.JackrabbitPrincipal won't do the right thing on equals().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (JCR-3439) PrincipalManagerImpl.CheckedGroup
should implement JackrabbitPrincipal
Posted by "Julian Reschke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Julian Reschke reassigned JCR-3439:
-----------------------------------
Assignee: Julian Reschke
> PrincipalManagerImpl.CheckedGroup should implement JackrabbitPrincipal
> ----------------------------------------------------------------------
>
> Key: JCR-3439
> URL: https://issues.apache.org/jira/browse/JCR-3439
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-core
> Reporter: Manfred Baedke
> Assignee: Julian Reschke
> Attachments: jcr-3439.patch
>
>
> otherwise org.apache.jackrabbit.api.security.principal.JackrabbitPrincipal won't do the right thing on equals().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (JCR-3439) PrincipalManagerImpl.CheckedGroup
should implement JackrabbitPrincipal
Posted by "Julian Reschke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Julian Reschke updated JCR-3439:
--------------------------------
Affects Version/s: 2.2.13
2.4.3
> PrincipalManagerImpl.CheckedGroup should implement JackrabbitPrincipal
> ----------------------------------------------------------------------
>
> Key: JCR-3439
> URL: https://issues.apache.org/jira/browse/JCR-3439
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-core
> Affects Versions: 2.2.13, 2.4.3
> Reporter: Manfred Baedke
> Assignee: Julian Reschke
> Fix For: 2.2.14, 2.4.4, 2.6
>
> Attachments: jcr-3439.patch
>
>
> otherwise org.apache.jackrabbit.api.security.principal.JackrabbitPrincipal won't do the right thing on equals().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (JCR-3439) PrincipalManagerImpl.CheckedGroup
should implement JackrabbitPrincipal
Posted by "Julian Reschke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Julian Reschke updated JCR-3439:
--------------------------------
Description: (see subject) (was: Find a detailed discussion and a proposed patch at https://issues.adobe.com/browse/CRX-4225)
> PrincipalManagerImpl.CheckedGroup should implement JackrabbitPrincipal
> ----------------------------------------------------------------------
>
> Key: JCR-3439
> URL: https://issues.apache.org/jira/browse/JCR-3439
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-core
> Reporter: Manfred Baedke
>
> (see subject)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (JCR-3439) PrincipalManagerImpl.CheckedGroup
should implement JackrabbitPrincipal
Posted by "Julian Reschke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Julian Reschke updated JCR-3439:
--------------------------------
Fix Version/s: 2.6
2.4.4
2.2.14
> PrincipalManagerImpl.CheckedGroup should implement JackrabbitPrincipal
> ----------------------------------------------------------------------
>
> Key: JCR-3439
> URL: https://issues.apache.org/jira/browse/JCR-3439
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-core
> Reporter: Manfred Baedke
> Assignee: Julian Reschke
> Fix For: 2.2.14, 2.4.4, 2.6
>
> Attachments: jcr-3439.patch
>
>
> otherwise org.apache.jackrabbit.api.security.principal.JackrabbitPrincipal won't do the right thing on equals().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (JCR-3439) PrincipalManagerImpl.CheckedGroup
should implement JackrabbitPrincipal
Posted by "Julian Reschke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Julian Reschke resolved JCR-3439.
---------------------------------
Resolution: Fixed
> PrincipalManagerImpl.CheckedGroup should implement JackrabbitPrincipal
> ----------------------------------------------------------------------
>
> Key: JCR-3439
> URL: https://issues.apache.org/jira/browse/JCR-3439
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-core
> Affects Versions: 2.2.13, 2.4.3
> Reporter: Manfred Baedke
> Assignee: Julian Reschke
> Fix For: 2.2.14, 2.4.4, 2.6
>
> Attachments: jcr-3439.patch
>
>
> otherwise org.apache.jackrabbit.api.security.principal.JackrabbitPrincipal won't do the right thing on equals().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (JCR-3439) PrincipalManagerImpl.CheckedGroup
should implement JackrabbitPrincipal
Posted by "Manfred Baedke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Manfred Baedke updated JCR-3439:
--------------------------------
Attachment: jcr-3439.patch
Fix and testcase.
> PrincipalManagerImpl.CheckedGroup should implement JackrabbitPrincipal
> ----------------------------------------------------------------------
>
> Key: JCR-3439
> URL: https://issues.apache.org/jira/browse/JCR-3439
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-core
> Reporter: Manfred Baedke
> Attachments: jcr-3439.patch
>
>
> otherwise org.apache.jackrabbit.api.security.principal.JackrabbitPrincipal won't do the right thing on equals().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JCR-3439) PrincipalManagerImpl.CheckedGroup
should implement JackrabbitPrincipal
Posted by "Julian Reschke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13473113#comment-13473113 ]
Julian Reschke commented on JCR-3439:
-------------------------------------
Proposed changes (thanks Angela):
PrincipalManagerImpl line 214:
- private class CheckedGroup implements Group {
+ private class CheckedGroup implements Group, JackrabbitPrincipal {
Also add tests:
a) principal from ACL equals same principal from principalMgr
b) principal from Authorizable equals same principal from principalMgr
c) ...and vice versa
> PrincipalManagerImpl.CheckedGroup should implement JackrabbitPrincipal
> ----------------------------------------------------------------------
>
> Key: JCR-3439
> URL: https://issues.apache.org/jira/browse/JCR-3439
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-core
> Reporter: Manfred Baedke
>
> otherwise org.apache.jackrabbit.api.security.principal.JackrabbitPrincipal won't do the right thing on equals().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JCR-3439) PrincipalManagerImpl.CheckedGroup
should implement JackrabbitPrincipal
Posted by "angela (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485007#comment-13485007 ]
angela commented on JCR-3439:
-----------------------------
what prevents you from creating a test in the principal package space that creates a PrincipalManager instance based on
the regular and in addition a custom test-principal provider. the latter would just expose your test principal and would
not make the ItemBasedPrincipal? IMO that should be really straight forward, wouldn't it?
> PrincipalManagerImpl.CheckedGroup should implement JackrabbitPrincipal
> ----------------------------------------------------------------------
>
> Key: JCR-3439
> URL: https://issues.apache.org/jira/browse/JCR-3439
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-core
> Reporter: Manfred Baedke
>
> otherwise org.apache.jackrabbit.api.security.principal.JackrabbitPrincipal won't do the right thing on equals().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JCR-3439) PrincipalManagerImpl.CheckedGroup
should implement JackrabbitPrincipal
Posted by "Manfred Baedke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484996#comment-13484996 ]
Manfred Baedke commented on JCR-3439:
-------------------------------------
Unfortunately, it's not obvious how to write a test here, since we need a test environment in which Principals are created that are not ItemsBasedPrincipals.
> PrincipalManagerImpl.CheckedGroup should implement JackrabbitPrincipal
> ----------------------------------------------------------------------
>
> Key: JCR-3439
> URL: https://issues.apache.org/jira/browse/JCR-3439
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-core
> Reporter: Manfred Baedke
>
> otherwise org.apache.jackrabbit.api.security.principal.JackrabbitPrincipal won't do the right thing on equals().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (JCR-3439) PrincipalManagerImpl.CheckedGroup
should implement JackrabbitPrincipal
Posted by "Julian Reschke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Julian Reschke resolved JCR-3439.
---------------------------------
Resolution: Fixed
> PrincipalManagerImpl.CheckedGroup should implement JackrabbitPrincipal
> ----------------------------------------------------------------------
>
> Key: JCR-3439
> URL: https://issues.apache.org/jira/browse/JCR-3439
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-core
> Affects Versions: 2.2.13, 2.4.3
> Reporter: Manfred Baedke
> Assignee: Julian Reschke
> Fix For: 2.2.14, 2.4.4, 2.6
>
> Attachments: jcr-3439.patch
>
>
> otherwise org.apache.jackrabbit.api.security.principal.JackrabbitPrincipal won't do the right thing on equals().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira