You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openjpa.apache.org by Albert Lee <al...@gmail.com> on 2007/07/04 02:22:53 UTC
Re: svn commit: r553010 [1/3] - in /openjpa/trunk: ./ openjpa-examples/src/main/java/hellojpa/ openjpa-examples/src/main/java/relations/ openjpa-jdbc-5/src/main/java/org/apache/openjpa/jdbc/meta/strats/ openjpa-jdbc/src/main/java/org/apache/openjpa/j
Marc,
Thanks for fixing the formatting problems.
Is there a Eclipse code formatter that meets the formating conventions
available for use? I am trying to avoid any future mishaps again.
Albert Lee.
On 7/3/07, mprudhom@apache.org <mp...@apache.org> wrote:
>
> Author: mprudhom
> Date: Tue Jul 3 15:42:39 2007
> New Revision: 553010
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=553010
> Log:
> OPENJPA-244 Fixed some formatting inconsistencies with the patch for
> OPENJPA-244
>
>
>
Re: svn commit: r553010 [1/3] - in /openjpa/trunk: ./ openjpa-examples/src/main/java/hellojpa/ openjpa-examples/src/main/java/relations/ openjpa-jdbc-5/src/main/java/org/apache/openjpa/jdbc/meta/strats/ openjpa-jdbc/src/main/java/org/apache/openjpa/j
Posted by Patrick Linskey <pl...@gmail.com>.
But seriously though, next time, you should just ping someone who uses
eclipse or IntelliJ to do the reformatting. I can't imagine the degree
of boredom that must have set in around file 50 or so.
-Patrick
On 7/4/07, Michael Dick <mi...@gmail.com> wrote:
> I don't think this was a matter of tabs and spaces, from what I can tell by
> visually inspecting Marc's commit it looks like the changes were whitespace
> around variables or casts. For example :
>
> (ClassLoader)AccessController. . .
> (ClassLoader) AccessController. . .
>
> Which I didn't think to look at when I committed Albert's changes. I didn't
> bring them up in Eclipse and run it's formatter on them though.
>
> I've been using Eclipse and what I generally do is create my own formatter,
> based on either Eclipse's conventions or Sun's. The only changes I make are
> to always use spaces. The rest of the defaults match our conventions as far
> as I know. I did go out and check for whitespace like the example above and
> it looks like if I had run the formatter it would have corrected it.
>
> Sorry guys, and thanks for catching it Marc
>
> -Mike
>
>
> On 7/3/07, Jay D. McHugh <ja...@joyfulnoisewebdesign.com> wrote:
> >
> > Whenever I need to make code formatted by Eclipse 'edible' for Apache, I
> > just run it through
> > sed to change the tabs to spaces:
> >
> > sed -i -e "s/\t/ /g" filename.java
> >
> > Or, if I want to change lots of programs and don't feel like fixing them
> > one at a time:
> >
> > sed -i -e 's/\t/ /g" `find . -name *.java`
> >
> > There may be a better way, but I didn't bother to find it.
> >
> > Jay
> >
> > Marc Prud'hommeaux wrote:
> > > Albert-
> > >
> > > Good question ... I just use vim (which makes reformatting code
> > > tedious, to say the least).
> > >
> > > Perhaps one of the Eclipse users will speak up with their handy
> > > formatting tips...
> > >
> > >
> > > On Jul 3, 2007, at 5:22 PM, Albert Lee wrote:
> > >
> > >> Marc,
> > >>
> > >> Thanks for fixing the formatting problems.
> > >>
> > >> Is there a Eclipse code formatter that meets the formating conventions
> > >> available for use? I am trying to avoid any future mishaps again.
> > >>
> > >> Albert Lee.
> > >>
> > >> On 7/3/07, mprudhom@apache.org <mp...@apache.org> wrote:
> > >>>
> > >>> Author: mprudhom
> > >>> Date: Tue Jul 3 15:42:39 2007
> > >>> New Revision: 553010
> > >>>
> > >>> URL: http://svn.apache.org/viewvc?view=rev&rev=553010
> > >>> Log:
> > >>> OPENJPA-244 Fixed some formatting inconsistencies with the patch for
> > >>> OPENJPA-244
> > >>>
> > >>>
> > >>>
> > >
> > >
> > >
> > >
> >
>
--
Patrick Linskey
202 669 5907
Re: svn commit: r553010 [1/3] - in /openjpa/trunk: ./ openjpa-examples/src/main/java/hellojpa/ openjpa-examples/src/main/java/relations/ openjpa-jdbc-5/src/main/java/org/apache/openjpa/jdbc/meta/strats/ openjpa-jdbc/src/main/java/org/apache/openjpa/j
Posted by Michael Dick <mi...@gmail.com>.
I don't think this was a matter of tabs and spaces, from what I can tell by
visually inspecting Marc's commit it looks like the changes were whitespace
around variables or casts. For example :
(ClassLoader)AccessController. . .
(ClassLoader) AccessController. . .
Which I didn't think to look at when I committed Albert's changes. I didn't
bring them up in Eclipse and run it's formatter on them though.
I've been using Eclipse and what I generally do is create my own formatter,
based on either Eclipse's conventions or Sun's. The only changes I make are
to always use spaces. The rest of the defaults match our conventions as far
as I know. I did go out and check for whitespace like the example above and
it looks like if I had run the formatter it would have corrected it.
Sorry guys, and thanks for catching it Marc
-Mike
On 7/3/07, Jay D. McHugh <ja...@joyfulnoisewebdesign.com> wrote:
>
> Whenever I need to make code formatted by Eclipse 'edible' for Apache, I
> just run it through
> sed to change the tabs to spaces:
>
> sed -i -e "s/\t/ /g" filename.java
>
> Or, if I want to change lots of programs and don't feel like fixing them
> one at a time:
>
> sed -i -e 's/\t/ /g" `find . -name *.java`
>
> There may be a better way, but I didn't bother to find it.
>
> Jay
>
> Marc Prud'hommeaux wrote:
> > Albert-
> >
> > Good question ... I just use vim (which makes reformatting code
> > tedious, to say the least).
> >
> > Perhaps one of the Eclipse users will speak up with their handy
> > formatting tips...
> >
> >
> > On Jul 3, 2007, at 5:22 PM, Albert Lee wrote:
> >
> >> Marc,
> >>
> >> Thanks for fixing the formatting problems.
> >>
> >> Is there a Eclipse code formatter that meets the formating conventions
> >> available for use? I am trying to avoid any future mishaps again.
> >>
> >> Albert Lee.
> >>
> >> On 7/3/07, mprudhom@apache.org <mp...@apache.org> wrote:
> >>>
> >>> Author: mprudhom
> >>> Date: Tue Jul 3 15:42:39 2007
> >>> New Revision: 553010
> >>>
> >>> URL: http://svn.apache.org/viewvc?view=rev&rev=553010
> >>> Log:
> >>> OPENJPA-244 Fixed some formatting inconsistencies with the patch for
> >>> OPENJPA-244
> >>>
> >>>
> >>>
> >
> >
> >
> >
>
Re: svn commit: r553010 [1/3] - in /openjpa/trunk: ./ openjpa-examples/src/main/java/hellojpa/
openjpa-examples/src/main/java/relations/ openjpa-jdbc-5/src/main/java/org/apache/openjpa/jdbc/meta/strats/
openjpa-jdbc/src/main/java/org/apache/openjpa/j
Posted by "Jay D. McHugh" <ja...@joyfulnoisewebdesign.com>.
Whenever I need to make code formatted by Eclipse 'edible' for Apache, I
just run it through
sed to change the tabs to spaces:
sed -i -e "s/\t/ /g" filename.java
Or, if I want to change lots of programs and don't feel like fixing them
one at a time:
sed -i -e 's/\t/ /g" `find . -name *.java`
There may be a better way, but I didn't bother to find it.
Jay
Marc Prud'hommeaux wrote:
> Albert-
>
> Good question ... I just use vim (which makes reformatting code
> tedious, to say the least).
>
> Perhaps one of the Eclipse users will speak up with their handy
> formatting tips...
>
>
> On Jul 3, 2007, at 5:22 PM, Albert Lee wrote:
>
>> Marc,
>>
>> Thanks for fixing the formatting problems.
>>
>> Is there a Eclipse code formatter that meets the formating conventions
>> available for use? I am trying to avoid any future mishaps again.
>>
>> Albert Lee.
>>
>> On 7/3/07, mprudhom@apache.org <mp...@apache.org> wrote:
>>>
>>> Author: mprudhom
>>> Date: Tue Jul 3 15:42:39 2007
>>> New Revision: 553010
>>>
>>> URL: http://svn.apache.org/viewvc?view=rev&rev=553010
>>> Log:
>>> OPENJPA-244 Fixed some formatting inconsistencies with the patch for
>>> OPENJPA-244
>>>
>>>
>>>
>
>
>
>
Re: svn commit: r553010 [1/3] - in /openjpa/trunk: ./ openjpa-examples/src/main/java/hellojpa/ openjpa-examples/src/main/java/relations/ openjpa-jdbc-5/src/main/java/org/apache/openjpa/jdbc/meta/strats/ openjpa-jdbc/src/main/java/org/apache/openjpa/j
Posted by Marc Prud'hommeaux <mp...@apache.org>.
Albert-
Good question ... I just use vim (which makes reformatting code
tedious, to say the least).
Perhaps one of the Eclipse users will speak up with their handy
formatting tips...
On Jul 3, 2007, at 5:22 PM, Albert Lee wrote:
> Marc,
>
> Thanks for fixing the formatting problems.
>
> Is there a Eclipse code formatter that meets the formating conventions
> available for use? I am trying to avoid any future mishaps again.
>
> Albert Lee.
>
> On 7/3/07, mprudhom@apache.org <mp...@apache.org> wrote:
>>
>> Author: mprudhom
>> Date: Tue Jul 3 15:42:39 2007
>> New Revision: 553010
>>
>> URL: http://svn.apache.org/viewvc?view=rev&rev=553010
>> Log:
>> OPENJPA-244 Fixed some formatting inconsistencies with the patch for
>> OPENJPA-244
>>
>>
>>