You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jiang Yan Xu <ya...@jxu.me> on 2014/08/06 01:42:09 UTC
Review Request 24355: Added a trailing space to _CheckFatal's output.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24355/
-----------------------------------------------------------
Review request for mesos and Dominic Hamon.
Repository: mesos-git
Description
-------
Added a trailing space to _CheckFatal's output.
- So there is a space between the error message and the additional message appended after the check. e.g. CHECK_SOME(None()) << "Some additional message";
- GLOG CHECK adds this space too: https://code.google.com/p/google-glog/source/browse/trunk/src/glog/logging.h.in#561
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/check.hpp 4b93aa082c9a312a5a7a15193512587088ea3d4c
Diff: https://reviews.apache.org/r/24355/diff/
Testing
-------
make check
Thanks,
Jiang Yan Xu
Re: Review Request 24355: Added a trailing space to _CheckFatal's output.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24355/#review49663
-----------------------------------------------------------
Ship it!
Ship It!
- Dominic Hamon
On Aug. 5, 2014, 4:42 p.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24355/
> -----------------------------------------------------------
>
> (Updated Aug. 5, 2014, 4:42 p.m.)
>
>
> Review request for mesos and Dominic Hamon.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Added a trailing space to _CheckFatal's output.
>
> - So there is a space between the error message and the additional message appended after the check. e.g. CHECK_SOME(None()) << "Some additional message";
> - GLOG CHECK adds this space too: https://code.google.com/p/google-glog/source/browse/trunk/src/glog/logging.h.in#561
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/check.hpp 4b93aa082c9a312a5a7a15193512587088ea3d4c
>
> Diff: https://reviews.apache.org/r/24355/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jiang Yan Xu
>
>