You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Jeremy Levy (JIRA)" <ji...@apache.org> on 2007/12/04 00:02:43 UTC

[jira] Created: (WICKET-1205) CSS relative path written out incorrectly between bookmarked and nonbookmarkable pages

CSS relative path written out incorrectly between bookmarked and nonbookmarkable pages
--------------------------------------------------------------------------------------

                 Key: WICKET-1205
                 URL: https://issues.apache.org/jira/browse/WICKET-1205
             Project: Wicket
          Issue Type: Bug
          Components: wicket
    Affects Versions: 1.3.0-rc1
         Environment: JBoss 4.2 / Tomcat Embedded
            Reporter: Jeremy Levy
            Priority: Minor


When linking from a bookmarked page to a non-bookmarked page the relative link to the CSS page breaks. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (WICKET-1205) Relative path calculations for inline paths in non-bookmarkable pages are incorrect on Tomcat.

Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Vaynberg resolved WICKET-1205.
-----------------------------------

    Resolution: Fixed

> Relative path calculations for inline paths in non-bookmarkable pages are incorrect on Tomcat.
> ----------------------------------------------------------------------------------------------
>
>                 Key: WICKET-1205
>                 URL: https://issues.apache.org/jira/browse/WICKET-1205
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.0-rc1
>         Environment: JBoss 4.2 / Tomcat Embedded
>            Reporter: Jeremy Levy
>            Assignee: Alastair Maw
>             Fix For: 1.3.5
>
>         Attachments: CSSIssueQuickStart.tar.gz, OldUrlFilter.java, WICKET-1205.zip
>
>
> When linking from a bookmarked page to a non-bookmarked page the relative link to the CSS page breaks. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-1205) Relative path calculations for inline paths in non-bookmarkable pages are incorrect on Tomcat.

Posted by "Frank Bille Jensen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Frank Bille Jensen updated WICKET-1205:
---------------------------------------

    Fix Version/s:     (was: 1.3.3)
                   1.3.4

> Relative path calculations for inline paths in non-bookmarkable pages are incorrect on Tomcat.
> ----------------------------------------------------------------------------------------------
>
>                 Key: WICKET-1205
>                 URL: https://issues.apache.org/jira/browse/WICKET-1205
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.0-rc1
>         Environment: JBoss 4.2 / Tomcat Embedded
>            Reporter: Jeremy Levy
>            Assignee: Alastair Maw
>             Fix For: 1.3.4
>
>         Attachments: CSSIssueQuickStart.tar.gz, WICKET-1205.zip
>
>
> When linking from a bookmarked page to a non-bookmarked page the relative link to the CSS page breaks. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-1205) CSS relative path written out incorrectly between bookmarked and nonbookmarkable pages

Posted by "Jeremy Levy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jeremy Levy updated WICKET-1205:
--------------------------------

    Attachment: CSSIssueQuickStart.tar.gz

See attached quickstart project (as netbeans 5.5.1 project) for example.

> CSS relative path written out incorrectly between bookmarked and nonbookmarkable pages
> --------------------------------------------------------------------------------------
>
>                 Key: WICKET-1205
>                 URL: https://issues.apache.org/jira/browse/WICKET-1205
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.0-rc1
>         Environment: JBoss 4.2 / Tomcat Embedded
>            Reporter: Jeremy Levy
>            Priority: Minor
>         Attachments: CSSIssueQuickStart.tar.gz
>
>
> When linking from a bookmarked page to a non-bookmarked page the relative link to the CSS page breaks. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-1205) Relative path calculations for inline paths in non-bookmarkable pages are incorrect on Tomcat.

Posted by "Frank Bille Jensen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Frank Bille Jensen updated WICKET-1205:
---------------------------------------

    Fix Version/s:     (was: 1.3.1)
                   1.3.2

> Relative path calculations for inline paths in non-bookmarkable pages are incorrect on Tomcat.
> ----------------------------------------------------------------------------------------------
>
>                 Key: WICKET-1205
>                 URL: https://issues.apache.org/jira/browse/WICKET-1205
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.0-rc1
>         Environment: JBoss 4.2 / Tomcat Embedded
>            Reporter: Jeremy Levy
>            Assignee: Alastair Maw
>             Fix For: 1.3.2
>
>         Attachments: CSSIssueQuickStart.tar.gz
>
>
> When linking from a bookmarked page to a non-bookmarked page the relative link to the CSS page breaks. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-1205) Relative path calculations for inline paths in non-bookmarkable pages are incorrect on Tomcat.

Posted by "Alastair Maw (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alastair Maw updated WICKET-1205:
---------------------------------

    Fix Version/s:     (was: 1.3.0-final)
                   1.3.0-rc3

> Relative path calculations for inline paths in non-bookmarkable pages are incorrect on Tomcat.
> ----------------------------------------------------------------------------------------------
>
>                 Key: WICKET-1205
>                 URL: https://issues.apache.org/jira/browse/WICKET-1205
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.0-rc1
>         Environment: JBoss 4.2 / Tomcat Embedded
>            Reporter: Jeremy Levy
>            Assignee: Alastair Maw
>             Fix For: 1.3.0-rc3
>
>         Attachments: CSSIssueQuickStart.tar.gz
>
>
> When linking from a bookmarked page to a non-bookmarked page the relative link to the CSS page breaks. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-1205) Relative path calculations for inline paths in non-bookmarkable pages are incorrect on Tomcat.

Posted by "Martijn Dashorst (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martijn Dashorst updated WICKET-1205:
-------------------------------------

    Fix Version/s:     (was: 1.3.4)
                   1.3.5

> Relative path calculations for inline paths in non-bookmarkable pages are incorrect on Tomcat.
> ----------------------------------------------------------------------------------------------
>
>                 Key: WICKET-1205
>                 URL: https://issues.apache.org/jira/browse/WICKET-1205
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.0-rc1
>         Environment: JBoss 4.2 / Tomcat Embedded
>            Reporter: Jeremy Levy
>            Assignee: Alastair Maw
>             Fix For: 1.3.5
>
>         Attachments: CSSIssueQuickStart.tar.gz, OldUrlFilter.java, WICKET-1205.zip
>
>
> When linking from a bookmarked page to a non-bookmarked page the relative link to the CSS page breaks. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-1205) CSS relative path written out incorrectly between bookmarked and nonbookmarkable pages

Posted by "Jeremy Levy (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-1205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12548325 ] 

Jeremy Levy commented on WICKET-1205:
-------------------------------------

Adding comments from: Oliver Lieven

Hi, I encountered this problem a week ago, too, and digged a little into code
and forum. Here's my summary:

the problem seems to be the "/*" filter mapping. If you specify a "/app/*"
filter mapping, relative URLs work just fine.

In my base-page-class (all my pages are derived from it through Wicket's
great markup inheritance) my stylesheet is referenced  in the head-section
by a relative reference like

  <link rel="stylesheet" type="text/css" href="style/myapp.css" />

Checking the generated HTML in the browser (when using "/*" filter mapping)
shows that this reference is modified by Wicket, so that it now reads

  <link rel="stylesheet" type="text/css" href="../style/myapp.css" />

This is an invalid path and addresses a wrong location.

I digged into the code and found that relative stylesheet and image
references where
automatically prepended by "../" by
ServletWebRequest.getRelativePathPrefixToContextRoot().

This seems to work well for the "/app/*" filter mapping, but fails for "/*"
(since theres no parent-directory in between to skip)

I currently decided to use the "/app/*" filter mapping.


Following workarounds came into my mind:

1. use of "absolute" references like "/myapp/style/myapp.css".
  pro:  works, Wicket doesn't modify the absolute paths
  cons: must code the context-path into all style and image references,
which is a "NO GO"

2. use of "/app/*" filter mapping
  pro : works
  cons: after having seen the much nicer "/*" mapping I want to use it :-))

3. in HTML it is possible to add a <base
href="http://localhost:8080/myapp/"/>
  line into the head section, which is used to resolve all relative
references
  pro : would be great, since it allows the use of relative URLs, and it
must
        be configured in just one place (the base-page's head section)
        would also be great to use when using a front end server (Apache),
        since references would be resolved to root context
  cons: since Wicket isn't aware of the <base> tag, relative references
        are still modified and prepended by "../", so no stylesheets/images
were found

4. fix it :-))

Related threads and infos:
- "is it a bug" - use of /* filter mapping -
http://www.nabble.com/is-it-a-bug--%28using-beta-4%29-tf4649929.html#a13284326

- "Wicket behind a frontend proxy" -
http://www.nabble.com/Wicket-behind-a-front-end-proxy-t4776982.html

-
http://cwiki.apache.org/WICKET/best-practices-and-gotchas.html#BestPracticesandGotchas-WicketServletMapping

> CSS relative path written out incorrectly between bookmarked and nonbookmarkable pages
> --------------------------------------------------------------------------------------
>
>                 Key: WICKET-1205
>                 URL: https://issues.apache.org/jira/browse/WICKET-1205
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.0-rc1
>         Environment: JBoss 4.2 / Tomcat Embedded
>            Reporter: Jeremy Levy
>            Priority: Minor
>         Attachments: CSSIssueQuickStart.tar.gz
>
>
> When linking from a bookmarked page to a non-bookmarked page the relative link to the CSS page breaks. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-1205) Relative path calculations for inline paths in non-bookmarkable pages are incorrect on Tomcat.

Posted by "Frank Bille Jensen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Frank Bille Jensen updated WICKET-1205:
---------------------------------------

    Fix Version/s:     (was: 1.3.2)
                   1.3.3

> Relative path calculations for inline paths in non-bookmarkable pages are incorrect on Tomcat.
> ----------------------------------------------------------------------------------------------
>
>                 Key: WICKET-1205
>                 URL: https://issues.apache.org/jira/browse/WICKET-1205
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.0-rc1
>         Environment: JBoss 4.2 / Tomcat Embedded
>            Reporter: Jeremy Levy
>            Assignee: Alastair Maw
>             Fix For: 1.3.3
>
>         Attachments: CSSIssueQuickStart.tar.gz
>
>
> When linking from a bookmarked page to a non-bookmarked page the relative link to the CSS page breaks. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (WICKET-1205) Relative path calculations for inline paths in non-bookmarkable pages are incorrect on Tomcat.

Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Vaynberg resolved WICKET-1205.
-----------------------------------

    Resolution: Won't Fix

this is quiet esoteric and we should not be fixing tomcat weirdness

> Relative path calculations for inline paths in non-bookmarkable pages are incorrect on Tomcat.
> ----------------------------------------------------------------------------------------------
>
>                 Key: WICKET-1205
>                 URL: https://issues.apache.org/jira/browse/WICKET-1205
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.0-rc1
>         Environment: JBoss 4.2 / Tomcat Embedded
>            Reporter: Jeremy Levy
>            Assignee: Alastair Maw
>             Fix For: 1.3.5
>
>         Attachments: CSSIssueQuickStart.tar.gz, OldUrlFilter.java, WICKET-1205.zip
>
>
> When linking from a bookmarked page to a non-bookmarked page the relative link to the CSS page breaks. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (WICKET-1205) CSS relative path written out incorrectly between bookmarked and nonbookmarkable pages

Posted by "Alastair Maw (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alastair Maw reassigned WICKET-1205:
------------------------------------

    Assignee: Alastair Maw

> CSS relative path written out incorrectly between bookmarked and nonbookmarkable pages
> --------------------------------------------------------------------------------------
>
>                 Key: WICKET-1205
>                 URL: https://issues.apache.org/jira/browse/WICKET-1205
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.0-rc1
>         Environment: JBoss 4.2 / Tomcat Embedded
>            Reporter: Jeremy Levy
>            Assignee: Alastair Maw
>            Priority: Minor
>         Attachments: CSSIssueQuickStart.tar.gz
>
>
> When linking from a bookmarked page to a non-bookmarked page the relative link to the CSS page breaks. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-1205) Relative path calculations for inline paths in non-bookmarkable pages are incorrect on Tomcat.

Posted by "Antony Stubbs (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-1205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12711093#action_12711093 ] 

Antony Stubbs commented on WICKET-1205:
---------------------------------------

has anyone got any links to any information / issues on the tomcat side of things? I'd like to follow the trail further....

> Relative path calculations for inline paths in non-bookmarkable pages are incorrect on Tomcat.
> ----------------------------------------------------------------------------------------------
>
>                 Key: WICKET-1205
>                 URL: https://issues.apache.org/jira/browse/WICKET-1205
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.0-rc1
>         Environment: JBoss 4.2 / Tomcat Embedded
>            Reporter: Jeremy Levy
>            Assignee: Alastair Maw
>             Fix For: 1.3.5
>
>         Attachments: CSSIssueQuickStart.tar.gz, OldUrlFilter.java, WICKET-1205.zip
>
>
> When linking from a bookmarked page to a non-bookmarked page the relative link to the CSS page breaks. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-1205) Relative path calculations for inline paths in non-bookmarkable pages are incorrect on Tomcat.

Posted by "Jeremy Levy (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-1205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12549436 ] 

Jeremy Levy commented on WICKET-1205:
-------------------------------------

I am using Tomcat 5.5 embeded in JBoss:

Servlet 2.4; JBoss-4.2.1.GA (build: SVNTag=JBoss_4_2_1_GA date=200707131605)/Tomcat-5.5

> Relative path calculations for inline paths in non-bookmarkable pages are incorrect on Tomcat.
> ----------------------------------------------------------------------------------------------
>
>                 Key: WICKET-1205
>                 URL: https://issues.apache.org/jira/browse/WICKET-1205
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.0-rc1
>         Environment: JBoss 4.2 / Tomcat Embedded
>            Reporter: Jeremy Levy
>            Assignee: Alastair Maw
>             Fix For: 1.3.0-rc3
>
>         Attachments: CSSIssueQuickStart.tar.gz
>
>
> When linking from a bookmarked page to a non-bookmarked page the relative link to the CSS page breaks. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-1205) Relative path calculations for inline paths in non-bookmarkable pages are incorrect on Tomcat.

Posted by "Frank Bille Jensen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Frank Bille Jensen updated WICKET-1205:
---------------------------------------

    Fix Version/s:     (was: 1.3.0-rc3)
                   1.3.1

> Relative path calculations for inline paths in non-bookmarkable pages are incorrect on Tomcat.
> ----------------------------------------------------------------------------------------------
>
>                 Key: WICKET-1205
>                 URL: https://issues.apache.org/jira/browse/WICKET-1205
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.0-rc1
>         Environment: JBoss 4.2 / Tomcat Embedded
>            Reporter: Jeremy Levy
>            Assignee: Alastair Maw
>             Fix For: 1.3.1
>
>         Attachments: CSSIssueQuickStart.tar.gz
>
>
> When linking from a bookmarked page to a non-bookmarked page the relative link to the CSS page breaks. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Reopened: (WICKET-1205) Relative path calculations for inline paths in non-bookmarkable pages are incorrect on Tomcat.

Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Vaynberg reopened WICKET-1205:
-----------------------------------


> Relative path calculations for inline paths in non-bookmarkable pages are incorrect on Tomcat.
> ----------------------------------------------------------------------------------------------
>
>                 Key: WICKET-1205
>                 URL: https://issues.apache.org/jira/browse/WICKET-1205
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.0-rc1
>         Environment: JBoss 4.2 / Tomcat Embedded
>            Reporter: Jeremy Levy
>            Assignee: Alastair Maw
>             Fix For: 1.3.5
>
>         Attachments: CSSIssueQuickStart.tar.gz, OldUrlFilter.java, WICKET-1205.zip
>
>
> When linking from a bookmarked page to a non-bookmarked page the relative link to the CSS page breaks. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-1205) Relative path calculations for inline paths in non-bookmarkable pages are incorrect on Tomcat.

Posted by "Alastair Maw (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-1205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12581712#action_12581712 ] 

Alastair Maw commented on WICKET-1205:
--------------------------------------

Yep. I'm going to look into fixing this this week if at all possible.

> Relative path calculations for inline paths in non-bookmarkable pages are incorrect on Tomcat.
> ----------------------------------------------------------------------------------------------
>
>                 Key: WICKET-1205
>                 URL: https://issues.apache.org/jira/browse/WICKET-1205
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.0-rc1
>         Environment: JBoss 4.2 / Tomcat Embedded
>            Reporter: Jeremy Levy
>            Assignee: Alastair Maw
>             Fix For: 1.3.3
>
>         Attachments: CSSIssueQuickStart.tar.gz
>
>
> When linking from a bookmarked page to a non-bookmarked page the relative link to the CSS page breaks. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-1205) CSS relative path written out incorrectly between bookmarked and nonbookmarkable pages

Posted by "Alastair Maw (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-1205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12549331 ] 

Alastair Maw commented on WICKET-1205:
--------------------------------------

I've downloaded your quickstart (which isn't really a quickstart at all, but I digress...)

I've added a StartJetty to it so I can actually run it. It works just fine, whether I add a context path or not, as expected.

Looks like this might be a Tomcat-specific bug. Am off to investigate further...

> CSS relative path written out incorrectly between bookmarked and nonbookmarkable pages
> --------------------------------------------------------------------------------------
>
>                 Key: WICKET-1205
>                 URL: https://issues.apache.org/jira/browse/WICKET-1205
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.0-rc1
>         Environment: JBoss 4.2 / Tomcat Embedded
>            Reporter: Jeremy Levy
>            Assignee: Alastair Maw
>            Priority: Minor
>         Attachments: CSSIssueQuickStart.tar.gz
>
>
> When linking from a bookmarked page to a non-bookmarked page the relative link to the CSS page breaks. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-1205) Relative path calculations for inline paths in non-bookmarkable pages are incorrect on Tomcat.

Posted by "Alastair Maw (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alastair Maw updated WICKET-1205:
---------------------------------

    Attachment: WICKET-1205.zip

Quickstart to demonstrate that I can't reproduce this.

> Relative path calculations for inline paths in non-bookmarkable pages are incorrect on Tomcat.
> ----------------------------------------------------------------------------------------------
>
>                 Key: WICKET-1205
>                 URL: https://issues.apache.org/jira/browse/WICKET-1205
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.0-rc1
>         Environment: JBoss 4.2 / Tomcat Embedded
>            Reporter: Jeremy Levy
>            Assignee: Alastair Maw
>             Fix For: 1.3.3
>
>         Attachments: CSSIssueQuickStart.tar.gz, WICKET-1205.zip
>
>
> When linking from a bookmarked page to a non-bookmarked page the relative link to the CSS page breaks. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-1205) Relative path calculations for inline paths in non-bookmarkable pages are incorrect on Tomcat.

Posted by "Alastair Maw (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-1205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12583965#action_12583965 ] 

Alastair Maw commented on WICKET-1205:
--------------------------------------

Gah! I've finally figured out what triggers this - it's the presence of an index.html/index.jsp file in your context root. If you remove that, things will work as you expect. Tomcat does something odd here that it shouldn't. I'm off to see if I can figure out a workaround for it.

> Relative path calculations for inline paths in non-bookmarkable pages are incorrect on Tomcat.
> ----------------------------------------------------------------------------------------------
>
>                 Key: WICKET-1205
>                 URL: https://issues.apache.org/jira/browse/WICKET-1205
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.0-rc1
>         Environment: JBoss 4.2 / Tomcat Embedded
>            Reporter: Jeremy Levy
>            Assignee: Alastair Maw
>             Fix For: 1.3.3
>
>         Attachments: CSSIssueQuickStart.tar.gz, WICKET-1205.zip
>
>
> When linking from a bookmarked page to a non-bookmarked page the relative link to the CSS page breaks. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-1205) Relative path calculations for inline paths in non-bookmarkable pages are incorrect on Tomcat.

Posted by "Alastair Maw (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-1205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12583934#action_12583934 ] 

Alastair Maw commented on WICKET-1205:
--------------------------------------

I've tried everything, but I can't reproduce this at all. :-(

Apache Tomcat versions:
5.5.17
5.5.26
6.0.14
6.0.16

Wicket versions:
1.3.0-rc1
1.3.0
1.3.2

I've tried with Tomcat standalone, with a test app deployed as a WAR, and with Tomcat embedded in in a StartTomcat class. I've tried with a root context and a context path of "/foo". I just can't reproduce this. I'm attaching a quickstart project to demonstrate what works.

If anyone can give me a quickstart project ZIP that I can create a WAR from that lets me reproduce this issue, then I will be very glad to fix it for you, but I just can't see how to reproduce this at the moment.

> Relative path calculations for inline paths in non-bookmarkable pages are incorrect on Tomcat.
> ----------------------------------------------------------------------------------------------
>
>                 Key: WICKET-1205
>                 URL: https://issues.apache.org/jira/browse/WICKET-1205
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.0-rc1
>         Environment: JBoss 4.2 / Tomcat Embedded
>            Reporter: Jeremy Levy
>            Assignee: Alastair Maw
>             Fix For: 1.3.3
>
>         Attachments: CSSIssueQuickStart.tar.gz, WICKET-1205.zip
>
>
> When linking from a bookmarked page to a non-bookmarked page the relative link to the CSS page breaks. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-1205) Relative path calculations for inline paths in non-bookmarkable pages are incorrect on Tomcat.

Posted by "Scott Sauyet (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Scott Sauyet updated WICKET-1205:
---------------------------------

    Attachment: OldUrlFilter.java

A possible work-around for those who need the "index.jsp" URL but not the file.

> Relative path calculations for inline paths in non-bookmarkable pages are incorrect on Tomcat.
> ----------------------------------------------------------------------------------------------
>
>                 Key: WICKET-1205
>                 URL: https://issues.apache.org/jira/browse/WICKET-1205
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.0-rc1
>         Environment: JBoss 4.2 / Tomcat Embedded
>            Reporter: Jeremy Levy
>            Assignee: Alastair Maw
>             Fix For: 1.3.4
>
>         Attachments: CSSIssueQuickStart.tar.gz, OldUrlFilter.java, WICKET-1205.zip
>
>
> When linking from a bookmarked page to a non-bookmarked page the relative link to the CSS page breaks. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (WICKET-1205) Relative path calculations for inline paths in non-bookmarkable pages are incorrect on Tomcat.

Posted by "Scott Sauyet (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-1205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12594590#action_12594590 ] 

scott_sauyet edited comment on WICKET-1205 at 5/6/08 7:09 AM:
--------------------------------------------------------------

One possible work-around for those like me who need the URL that includes index.jsp but not the actual file, is to add a servlet filter which simply redirects to the main application.  A more involved version of the attached OldUrlFilter.java allows old bookmarks to easily map to newer version.

There is more discussion of this at http://tinyurl.com/3gcbsa


      was (Author: scott_sauyet):
    A possible work-around for those who need the "index.jsp" URL but not the file.
  
> Relative path calculations for inline paths in non-bookmarkable pages are incorrect on Tomcat.
> ----------------------------------------------------------------------------------------------
>
>                 Key: WICKET-1205
>                 URL: https://issues.apache.org/jira/browse/WICKET-1205
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.0-rc1
>         Environment: JBoss 4.2 / Tomcat Embedded
>            Reporter: Jeremy Levy
>            Assignee: Alastair Maw
>             Fix For: 1.3.4
>
>         Attachments: CSSIssueQuickStart.tar.gz, OldUrlFilter.java, WICKET-1205.zip
>
>
> When linking from a bookmarked page to a non-bookmarked page the relative link to the CSS page breaks. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-1205) CSS relative path written out incorrectly between bookmarked and nonbookmarkable pages

Posted by "Alastair Maw (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-1205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12549339 ] 

Alastair Maw commented on WICKET-1205:
--------------------------------------

On the bundled 5.5.17 Tomcat that comes with Netbeans, deploying the WAR file built by your ant build script fails due to missing log4j and slf4j JARs. If you add these into Tomcat's common/lib folder, the WAR will deploy properly.

I can confirm that I can reproduce this under that environment. Guess I need to get Tomcat going under Eclipse and work out what's going on... :-(

So yes, this is indeed Tomcat-specific. Needs fixing before 1.3.0 final or lots of people will be cross.

(Note to self - crypted/un-crypted URLs makes no difference.)



> CSS relative path written out incorrectly between bookmarked and nonbookmarkable pages
> --------------------------------------------------------------------------------------
>
>                 Key: WICKET-1205
>                 URL: https://issues.apache.org/jira/browse/WICKET-1205
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.0-rc1
>         Environment: JBoss 4.2 / Tomcat Embedded
>            Reporter: Jeremy Levy
>            Assignee: Alastair Maw
>            Priority: Minor
>         Attachments: CSSIssueQuickStart.tar.gz
>
>
> When linking from a bookmarked page to a non-bookmarked page the relative link to the CSS page breaks. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-1205) Relative path calculations for inline paths in non-bookmarkable pages are incorrect on Tomcat.

Posted by "Alastair Maw (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alastair Maw updated WICKET-1205:
---------------------------------

    Fix Version/s: 1.3.0-final
         Priority: Major  (was: Minor)
          Summary: Relative path calculations for inline paths in non-bookmarkable pages are incorrect on Tomcat.  (was: CSS relative path written out incorrectly between bookmarked and nonbookmarkable pages)

> Relative path calculations for inline paths in non-bookmarkable pages are incorrect on Tomcat.
> ----------------------------------------------------------------------------------------------
>
>                 Key: WICKET-1205
>                 URL: https://issues.apache.org/jira/browse/WICKET-1205
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.0-rc1
>         Environment: JBoss 4.2 / Tomcat Embedded
>            Reporter: Jeremy Levy
>            Assignee: Alastair Maw
>             Fix For: 1.3.0-final
>
>         Attachments: CSSIssueQuickStart.tar.gz
>
>
> When linking from a bookmarked page to a non-bookmarked page the relative link to the CSS page breaks. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-1205) Relative path calculations for inline paths in non-bookmarkable pages are incorrect on Tomcat.

Posted by "Vincent van 't Zand (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-1205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12576829#action_12576829 ] 

Vincent van 't Zand commented on WICKET-1205:
---------------------------------------------

We are planning to deploy our Wicket app on Tomcat, because that's our time-proven standard. Not sure how big the impact of this bug will be, because we just started experimenting with Wicket and are still not sure what content is going to be on our Home page. For now the only path we use in Home is for CSS. I use this workaround:

	<style type="text/css">
		@import "style.css";
	</style>

Sure hope there will be a fix soon, because this special case for Home is too error-prone and seems to cause other problems with Tomcat: in order to get the 'authtest' example to work, I have to remove the 'index.html' file from the 'Webapp' directory?!?

This is with Tomcat 5.5.25 running under Eclipse 3.3.1.1 on Mac OS 10.4.11.

> Relative path calculations for inline paths in non-bookmarkable pages are incorrect on Tomcat.
> ----------------------------------------------------------------------------------------------
>
>                 Key: WICKET-1205
>                 URL: https://issues.apache.org/jira/browse/WICKET-1205
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.0-rc1
>         Environment: JBoss 4.2 / Tomcat Embedded
>            Reporter: Jeremy Levy
>            Assignee: Alastair Maw
>             Fix For: 1.3.3
>
>         Attachments: CSSIssueQuickStart.tar.gz
>
>
> When linking from a bookmarked page to a non-bookmarked page the relative link to the CSS page breaks. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-1205) Relative path calculations for inline paths in non-bookmarkable pages are incorrect on Tomcat.

Posted by "Gabor Szokoli (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-1205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12549858 ] 

Gabor Szokoli commented on WICKET-1205:
---------------------------------------

We experience the same problem (and work around it with a /app/ mapping) under Glassfish V2. (I'm not 100% up to date on how far its servlet container has diverged from tomcat.)

> Relative path calculations for inline paths in non-bookmarkable pages are incorrect on Tomcat.
> ----------------------------------------------------------------------------------------------
>
>                 Key: WICKET-1205
>                 URL: https://issues.apache.org/jira/browse/WICKET-1205
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.0-rc1
>         Environment: JBoss 4.2 / Tomcat Embedded
>            Reporter: Jeremy Levy
>            Assignee: Alastair Maw
>             Fix For: 1.3.0-rc3
>
>         Attachments: CSSIssueQuickStart.tar.gz
>
>
> When linking from a bookmarked page to a non-bookmarked page the relative link to the CSS page breaks. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.