[GitHub] [spark] Peng-Lei commented on a change in pull request #33839: [WIP][SPARK-36291][SQL] Refactor second set of 20 in QueryExecutionErrors to use error classes

[GitBox <gi...@apache.org>]

Peng-Lei commented on a change in pull request #33839:
URL: https://github.com/apache/spark/pull/33839#discussion_r697217253



##########
File path: core/src/main/resources/error/error-classes.json
##########
@@ -89,13 +122,31 @@
     "message" : [ "The second argument of '%s' function needs to be an integer." ],
     "sqlState" : "22023"
   },
+  "SHOULD_NOT_CALL_ALIAS_DO_GEN_CODE" : {
+    "message" : [ "Alias.doGenCode should not be called." ]
+  },
+  "SUM_OF_DECIMAL_OVERFLOW" : {
+    "message" : [ "Overflow in sum of decimals." ]
+  },
   "UNABLE_TO_ACQUIRE_MEMORY" : {
     "message" : [ "Unable to acquire %s bytes of memory, got %s" ]
   },
+  "UNEXPECTED_DATATYPE" : {

Review comment:
       Could we try to merge them? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org