You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by Antoine Levy-Lambert <an...@gmx.de> on 2010/02/01 00:17:23 UTC

Re: [PATCH] JUnitTestRunner.filterStack(String) does not flush BufferedWriter

Hello N C,

thanks for reporting this, I have committed a call to FileUtils.close in
a finally block which does the same and might also do it if an exception
happened during this reporting process.

If you are setup to build/compile ant yourself, you can update your
working copy from svn and report whether the change fixes the problem
for you.

Regards,

Antoine

N C wrote:
> --- On Sat, 1/30/10, N C <nc...@yahoo.com> wrote:
>
>   
>> Attached is a patch closing the BufferedWriter.
>>     
>
> I'm not sure the attachment went through...
>
> --- JUnitTestRunner.java.orig   2010-01-30 16:22:58.000000000 -0500
> +++ JUnitTestRunner.java        2010-01-30 16:23:12.000000000 -0500
> @@ -896,6 +896,7 @@
>                      pw.newLine();
>                  }
>              }
> +            pw.close();
>          } catch (Exception e) {
>              return stack; // return the stack unfiltered
>          }
>
>
>       
>
>
>   


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Re: [PATCH] JUnitTestRunner.filterStack(String) does not flush BufferedWriter

Posted by Antoine Levy Lambert <an...@gmx.de>.
Thanks to you too again. We are redoing the next 1.8.0 RC because of 
what you found :-).

Regards,

Antoine

N C wrote:
> --- On Sun, 1/31/10, Antoine Levy-Lambert <an...@gmx.de> wrote:
>   
>> If you are setup to build/compile ant yourself, you can
>> update your working copy from svn and report whether the change fixes
>> the problem for you.
>>     
>
> I've built from r905382.  The problem is resolved in this build.  Thanks.
>
>
>
>       
>
>
>   


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Re: [PATCH] JUnitTestRunner.filterStack(String) does not flush BufferedWriter

Posted by N C <nc...@yahoo.com>.
--- On Sun, 1/31/10, Antoine Levy-Lambert <an...@gmx.de> wrote:
> If you are setup to build/compile ant yourself, you can
> update your working copy from svn and report whether the change fixes
> the problem for you.

I've built from r905382.  The problem is resolved in this build.  Thanks.



      


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org