[GitHub] [incubator-druid] leventov commented on a change in pull request #8359: Logging emitter to publish query and other metric events as valid json objects

[GitBox <gi...@apache.org>]

leventov commented on a change in pull request #8359: Logging emitter to publish query and other metric events as valid json objects
URL: https://github.com/apache/incubator-druid/pull/8359#discussion_r317084647
 
 

 ##########
 File path: server/src/main/java/org/apache/druid/server/log/DefaultRequestLogEventBuilderFactory.java
 ##########
 @@ -32,6 +32,11 @@
   private static final DefaultRequestLogEventBuilderFactory INSTANCE = new DefaultRequestLogEventBuilderFactory();
 
   @JsonCreator
+  public static DefaultRequestLogEventBuilderFactory instance(String ignored)
 
 Review comment:
   Please add a Javadoc comment explaining why this is needed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org