[GitHub] [spark] cloud-fan commented on a change in pull request #27672: [SPARK-30919][SQL] Make interval multiply and divide's overflow behavior consistent with other operations

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #27672: [SPARK-30919][SQL] Make interval multiply and divide's overflow behavior consistent with other operations
URL: https://github.com/apache/spark/pull/27672#discussion_r383145088
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/intervalExpressions.scala
 ##########
 @@ -137,10 +139,23 @@ abstract class IntervalNumOperation(
 }
 
 case class MultiplyInterval(interval: Expression, num: Expression)
-  extends IntervalNumOperation(interval, num, multiplyExact, "multiplyExact")
+  extends IntervalNumOperation(interval, num) {
+
+  override protected def operation(interval: CalendarInterval, num: Double): CalendarInterval = {
+    if (checkOverflow) multiplyExact(interval, num) else multiply(interval, num)
 
 Review comment:
   we shouldn't check the ansi flag for each row.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org