You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/06/15 07:07:23 UTC

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #808: MINIFICPP-1234 - Enable all archive tests on Windows.

adamdebreceni commented on a change in pull request #808:
URL: https://github.com/apache/nifi-minifi-cpp/pull/808#discussion_r439969476



##########
File path: libminifi/test/archive-tests/ManipulateArchiveTests.cpp
##########
@@ -90,9 +89,7 @@ bool run_archive_test(OrderedTestArchive input_archive, OrderedTestArchive outpu
     plan->runNextProcessor();  // ManipulateArchive
     plan->runNextProcessor();  // PutFile 2 (manipulated)
 
-    std::stringstream ss2;
-    ss2 << dir2 << "/" << TEST_ARCHIVE_NAME;
-    std::string output_path = ss2.str();
+    std::string output_path =utils::file::FileUtils::concat_path(dir2, TEST_ARCHIVE_NAME);

Review comment:
       done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org