You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by neykov <gi...@git.apache.org> on 2015/06/25 23:04:20 UTC

[GitHub] incubator-brooklyn pull request: More integration test fixes

GitHub user neykov opened a pull request:

    https://github.com/apache/incubator-brooklyn/pull/719

    More integration test fixes

    * Don't unmanage `BrooklynNode` until the STOP effector and all parent entity tasks complete. Prevents `CancellationException: null` error when the STOP effector is called from another effector (i.e. `STOP_NODE_AND_KILL_APPS`)
    * AutoScaler now has a default min of 1 member
    * Wait for all apps to be running before continuing tests in `BrooklynNodeIntegrationTest` (not just managed)
    * Don't use remote services when a local one will do, avoids quota exceeded failures

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/neykov/incubator-brooklyn fix/integration-tests

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-brooklyn/pull/719.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #719
    
----
commit 00ec0546bc98508dbe807f8ef4e77d544bac1ddc
Author: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Date:   2015-06-23T10:37:55Z

    Fix AutoScaler integration test - MIN_POOL_SIZE is 1 now.

commit af9cf334d7bcd5fb28ef245ac94bd30e28c77548
Author: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Date:   2015-06-24T19:03:56Z

    Wait all apps running in BrooklynNote test

commit fcaa205f95dacc039e6905a6a1bf729d9f8f45f5
Author: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Date:   2015-06-25T18:53:22Z

    Fix BrooklynNode unmanage - wait for parent tasks to complete

commit 9b4f84e8aaf2f1af5281b14e3c00871982a5abae
Author: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Date:   2015-06-25T20:48:37Z

    Avoid the usage of remote services, replace with local server
    
    Remote service echo.jsontest.com has low quota leading to failing tests when exceeded. Replace with a local server, returning the same repsonse. As a bonus the test can be run as a unit test.
    Also remove code duplication, move common code to TestHttpServer.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: More integration test fixes

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-brooklyn/pull/719


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: More integration test fixes

Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/719#issuecomment-115650362
  
    nice - merging


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---