You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "panbingkun (via GitHub)" <gi...@apache.org> on 2023/09/01 02:45:38 UTC
[GitHub] [spark] panbingkun opened a new pull request, #42764: [SPARK-45043][BUILD] Upgrade `scalafmt` to 3.7.13
panbingkun opened a new pull request, #42764:
URL: https://github.com/apache/spark/pull/42764
### What changes were proposed in this pull request?
The pr aims to upgrade `scalafmt` from 3.7.5 to 3.7.13.
### Why are the changes needed?
1.The newest version include some bug fixed, eg:
- FormatWriter: accumulate align shift correctly (https://github.com/scalameta/scalafmt/pull/3615)
- Indents: ignore fewerBraces if indentation is 1 (https://github.com/scalameta/scalafmt/pull/3592)
- RemoveScala3OptionalBraces: handle infix on rbrace (https://github.com/scalameta/scalafmt/pull/3576)
2.The full release notes:
https://github.com/scalameta/scalafmt/releases/tag/v3.7.13
https://github.com/scalameta/scalafmt/releases/tag/v3.7.12
https://github.com/scalameta/scalafmt/releases/tag/v3.7.11
https://github.com/scalameta/scalafmt/releases/tag/v3.7.10
https://github.com/scalameta/scalafmt/releases/tag/v3.7.9
https://github.com/scalameta/scalafmt/releases/tag/v3.7.8
https://github.com/scalameta/scalafmt/releases/tag/v3.7.7
https://github.com/scalameta/scalafmt/releases/tag/v3.7.6
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Pass GA.
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen closed pull request #42764: [SPARK-45043][BUILD] Upgrade `scalafmt` to 3.7.13
Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen closed pull request #42764: [SPARK-45043][BUILD] Upgrade `scalafmt` to 3.7.13
URL: https://github.com/apache/spark/pull/42764
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #42764: [SPARK-45043][BUILD] Upgrade `scalafmt` to 3.7.13
Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen commented on PR #42764:
URL: https://github.com/apache/spark/pull/42764#issuecomment-1703831312
I think this is fine to update plugins in general. Some stuff like this doesn't seem like it does anything for Spark, so isn't that important. As long as we're not generating a whole lot of PRs, it's OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on pull request #42764: [SPARK-45043][BUILD] Upgrade `scalafmt` to 3.7.13
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #42764:
URL: https://github.com/apache/spark/pull/42764#issuecomment-1703844726
> I think this is fine to update plugins in general. Some stuff like this doesn't seem like it does anything for Spark, so isn't that important. As long as we're not generating a whole lot of PRs, it's OK
Okay, I see👌🏻
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #42764: [SPARK-45043][BUILD] Upgrade `scalafmt` to 3.7.13
Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen commented on PR #42764:
URL: https://github.com/apache/spark/pull/42764#issuecomment-1703831412
Merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org