You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2017/05/17 17:03:38 UTC
Review Request 59344: Make libprocess flags global.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59344/
-----------------------------------------------------------
Review request for mesos and Benjamin Mahler.
Bugs: MESOS-7401
https://issues.apache.org/jira/browse/MESOS-7401
Repository: mesos
Description
-------
Since we will need to check the libprocess flags while receiving
messages, hoist them out of initialize() and make them a static
global.
Diffs
-----
3rdparty/libprocess/src/process.cpp 96ce7dbc486a2f1d55d2238a8a102bf024b12b1c
Diff: https://reviews.apache.org/r/59344/diff/1/
Testing
-------
make check (Fedora 25)
Thanks,
James Peach
Re: Review Request 59344: Make libprocess flags global.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59344/#review176356
-----------------------------------------------------------
Ship it!
3rdparty/libprocess/src/process.cpp
Lines 562 (patched)
<https://reviews.apache.org/r/59344/#comment249746>
`s/ */* /`
- Benjamin Mahler
On May 17, 2017, 5:03 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59344/
> -----------------------------------------------------------
>
> (Updated May 17, 2017, 5:03 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-7401
> https://issues.apache.org/jira/browse/MESOS-7401
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since we will need to check the libprocess flags while receiving
> messages, hoist them out of initialize() and make them a static
> global.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp 96ce7dbc486a2f1d55d2238a8a102bf024b12b1c
>
>
> Diff: https://reviews.apache.org/r/59344/diff/2/
>
>
> Testing
> -------
>
> make check (Fedora 25)
>
>
> Thanks,
>
> James Peach
>
>