You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by yoonjs2 <gi...@git.apache.org> on 2016/06/12 07:50:52 UTC
[GitHub] zeppelin pull request #999: Fix navigation link of documentation for storage...
GitHub user yoonjs2 opened a pull request:
https://github.com/apache/zeppelin/pull/999
Fix navigation link of documentation for storage using anchor.
### What is this PR for?
In documentation about storage, a custom hashtag navigation used to nav to each paragraph but scrolling is not working properly (it cannot fully scroll to headers of paragraph) when clicking each menu at nav bar.
But after PR #995 by @AhyoungRyu, custom hashtag nav can be changed into anchor.js style so I fixed nav for documentation to use this anchor feature to make it scroll properly.
### What type of PR is it?
Bug Fix, Documentation
### Todos
* [ ] - Merge with #995 after #995 has merged into master branch
### How should this be tested?
1. Apply this patch
2. Build docs site using jekyll and browse localhost:4000
3. Click top nav -> Click "More" -> Click "Git storage", "S3 Storage", and so on.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yoonjs2/incubator-zeppelin fix-navigation-for-storage-doc
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/999.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #999
----
commit 5665dcfb7dce4805d917efee01bef7acd3f170ab
Author: Jesang Yoon <yo...@kanizsalab.com>
Date: 2016-01-17T15:20:03Z
Fix wrong HTML tags, indention and space between paragraph and tables. Remove unnecessary spaces.
commit 5b091e4b0e7e1417744cde1c81f5a44d3330ba25
Author: Jesang Yoon <yo...@kanizsalab.com>
Date: 2016-01-17T15:20:03Z
Fix wrong HTML tags, indention and space between paragraph and tables. Remove unnecessary spaces.
commit 4d1503ab21e0d374fc9800deb3cba1ab6d6cf3df
Author: Jesang Yoon <yo...@kanizsalab.com>
Date: 2016-01-17T15:54:21Z
Merge remote-tracking branch 'origin/master'
# Conflicts:
# docs/interpreter/cassandra.md
commit 5f0a6e083fef58032f53c7e3aa1888748c785884
Author: Jesang Yoon <yo...@kanizsalab.com>
Date: 2016-01-17T15:54:21Z
Merge remote-tracking branch 'origin/master'
# Conflicts:
# docs/interpreter/cassandra.md
commit 079480f984c378b44c3f08a3671feb4a2d5f9853
Author: Jesang Yoon <yo...@kanizsalab.com>
Date: 2016-01-17T15:55:51Z
Merge remote-tracking branch 'origin/master'
commit af55811b5406ee58857de5bd6a477c197be075f0
Author: Jesang Yoon <yo...@kanizsalab.com>
Date: 2016-01-17T18:45:48Z
Merge remote-tracking branch 'origin/master'
# Conflicts:
# docs/interpreter/cassandra.md
commit 781954b82c54b25fa491ba24dd72d5c294639d69
Author: Jesang Yoon <yo...@kanizsalab.com>
Date: 2016-01-17T18:49:23Z
Interpreter documentation merge with commit #578
commit db8b4daa8c10ce5a2baa2e0f8c52a6ea556b31b9
Author: Jesang Yoon <yo...@kanizsalab.com>
Date: 2016-01-17T18:50:50Z
Merge remote-tracking branch 'upstream/master'
commit eba0315380bc6d88defd958e0fb945bf00eb682a
Author: Jesang Yoon <yo...@kanizsalab.com>
Date: 2016-01-19T01:57:24Z
Merge remote-tracking branch 'upstream/master'
commit 3d9e5b3187b4e5c4523bd18bf7a5ffb8f1ef19cf
Author: Jesang Yoon <yo...@kanizsalab.com>
Date: 2016-03-14T14:58:43Z
Merge remote-tracking branch 'upstream/master'
# Conflicts:
# docs/interpreter/cassandra.md
# docs/interpreter/spark.md
# docs/manual/interpreters.md
commit aac4cd446a66038bae80d11339ee6fcdf8b3104b
Author: Jesang Yoon <yo...@kanizsalab.com>
Date: 2016-03-14T15:19:32Z
Add documentation for explaining enable HTTP basic authentication served by NGINX
commit 4b2223a2591c1f77941d0781f5609c4bcbfcb27a
Author: Jesang Yoon <yo...@kanizsalab.com>
Date: 2016-03-14T15:25:18Z
Make path to cert and key for HTTPS Ambigious
commit 35a6679baca5412f5f08e8f25f9ed15bf85e0325
Author: Jesang Yoon <yo...@kanizsalab.com>
Date: 2016-03-15T01:58:44Z
Merge branch 'master' of https://github.com/apache/incubator-zeppelin
commit 90219f737c2b0a9787c2dc0c618ff796900dc693
Author: Jesang Yoon <yo...@kanizsalab.com>
Date: 2016-03-21T06:04:42Z
Merge branch 'master' of https://github.com/apache/incubator-zeppelin
# Conflicts:
# docs/security/authentication.md
commit 6d04fa7a4d8da7b115ed0c90f626c04be7e7acc6
Author: Jesang Yoon <yo...@kanizsalab.com>
Date: 2016-04-09T17:22:36Z
Merge branch 'master' of https://github.com/apache/incubator-zeppelin
commit 6a5a3c8528643087000263a31e1bc1f70077da2b
Author: Jesang Yoon <yo...@kanizsalab.com>
Date: 2016-04-18T04:44:06Z
Merge branch 'master' of https://github.com/apache/incubator-zeppelin
commit 7525167b1894a759f4d83e890794067bc247ab10
Author: Jesang Yoon <yo...@kanizsalab.com>
Date: 2016-05-08T14:48:51Z
Merge branch 'master' of https://github.com/apache/incubator-zeppelin
commit 79472d10eeff79adbabe2773ca5c35e634bcc09d
Author: Jesang Yoon <yo...@kanizsalab.com>
Date: 2016-05-17T05:05:43Z
Update master branch from upstream
commit e874a129f09853c7c8a68792a1d5697784e65f63
Author: Jesang Yoon <yo...@kanizsalab.com>
Date: 2016-06-12T02:34:49Z
Merge branch 'master' of https://github.com/apache/incubator-zeppelin
# Conflicts:
# dev/merge_zeppelin_pr.py
# docs/quickstart/explorezeppelinui.md
# zeppelin-server/src/main/java/org/apache/zeppelin/rest/LoginRestApi.java
# zeppelin-web/.jshintrc
# zeppelin-web/src/app/notebook/notebook.controller.js
# zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js
# zeppelin-web/src/components/navbar/navbar.controller.js
# zeppelin-web/src/components/navbar/navbar.html
commit d3a2d502429872c3d32deb15b6ecf49431ce696d
Author: Jesang Yoon <yo...@kanizsalab.com>
Date: 2016-06-12T07:31:57Z
Apply patch from #995 to enable anchor.js feature
commit ff0860570d06d0770b8c5e26ed1ead257b81964d
Author: Jesang Yoon <yo...@kanizsalab.com>
Date: 2016-06-12T07:32:35Z
Fix links for storage documentation using anchors
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #999: Fix navigation link of documentation for storage using ...
Posted by minahlee <gi...@git.apache.org>.
Github user minahlee commented on the issue:
https://github.com/apache/zeppelin/pull/999
I just tried #1004 and it scroll to expected position. Since #1004 is using a lot of anchor, would you mind to close this pr so we can reduce burden of changing every anchor that is used in #1004?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #999: Fix navigation link of documentation for storage using ...
Posted by yoonjs2 <gi...@git.apache.org>.
Github user yoonjs2 commented on the issue:
https://github.com/apache/zeppelin/pull/999
@minahlee No problem :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #999: Fix navigation link of documentation for storage...
Posted by yoonjs2 <gi...@git.apache.org>.
Github user yoonjs2 closed the pull request at:
https://github.com/apache/zeppelin/pull/999
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---