You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hc.apache.org by "Sebb (JIRA)" <ji...@apache.org> on 2013/11/25 03:13:35 UTC

[jira] [Resolved] (HTTPCORE-364) IOSessionImpl.getLocalAddress() creates unnecessary copy of channel

     [ https://issues.apache.org/jira/browse/HTTPCORE-364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sebb resolved HTTPCORE-364.
---------------------------

       Resolution: Fixed
    Fix Version/s: 4.3.1

URL: http://svn.apache.org/r1545087
Log:
HTTPCORE-364: IOSessionImpl.getLocalAddress() creates unnecessary copy of channel

Modified:
    httpcomponents/httpcore/trunk/RELEASE_NOTES.txt
    httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/reactor/IOSessionImpl.java


> IOSessionImpl.getLocalAddress() creates unnecessary copy of channel
> -------------------------------------------------------------------
>
>                 Key: HTTPCORE-364
>                 URL: https://issues.apache.org/jira/browse/HTTPCORE-364
>             Project: HttpComponents HttpCore
>          Issue Type: Improvement
>            Reporter: Sebb
>            Priority: Minor
>             Fix For: 4.3.1
>
>
> IOSessionImpl.getLocalAddress() copies the final field channel into a local variable also called channel. This seems completely unnecessary; the statement could be dropped. (If channel were mutablle, the statement would make sense).
> Similarly for getRemoteAddress()



--
This message was sent by Atlassian JIRA
(v6.1#6144)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org