Re: [PR] [FLINK-35931][table] Add the built-in functions REGEXP_COUNT & REGEXP_EXTRACT_ALL & REGEXP_INSTR & REGEXP_SUBSTR [flink]

["lincoln-lil (via GitHub)" <gi...@apache.org>]

lincoln-lil commented on code in PR #25137:
URL: https://github.com/apache/flink/pull/25137#discussion_r1722647521


##########
docs/data/sql_functions.yml:
##########
@@ -344,7 +342,44 @@ string:
       not exceed the number of the defined groups.
 
       E.g. REGEXP_EXTRACT('foothebar', 'foo(.*?)(bar)', 2)" returns "bar".
+  - sql: REGEXP_EXTRACT_ALL(str, regex[, extractIndex])
+    table: str.regexpExtractAll(regex[, extractIndex])
+    description: |
+      Extracts all the substrings in str that match the regex expression and correspond to the regex group extractIndex.
+      
+      regex may contain multiple groups. extractIndex indicates which regex group to extract and starts from 1, also the default value if not specified. And 0 means matching the entire regular expression.

Review Comment:
   nit: 'And 0 means ...' -> '0 means ...' ?



##########
flink-python/pyflink/table/expression.py:
##########
@@ -1225,6 +1236,45 @@ def regexp_extract(self,
         else:
             return _ternary_op("regexpExtract")(self, regex, extract_index)
 
+    def regexp_extract_all(self, regex, extract_index=None) -> 'Expression':
+        """
+        Extracts all the substrings in str that match the regex expression and correspond to the
+        regex group extract_index.
+        regex may contain multiple groups. extract_index indicates which regex group to extract and
+        starts from 1, also the default value if not specified. And 0 means matching the entire

Review Comment:
   ditto



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org