You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/05/30 07:54:40 UTC
[GitHub] [pulsar] dockerzhang opened a new pull request #7113: set pulsar-all docker image config one time
dockerzhang opened a new pull request #7113:
URL: https://github.com/apache/pulsar/pull/7113
<!--
### Contribution Checklist
- Name the pull request in the form "[Issue XYZ][component] Title of the pull request", where *XYZ* should be replaced by the actual issue number.
Skip *Issue XYZ* if there is no associated github issue for this pull request.
Skip *component* if you are unsure about which is the best component. E.g. `[docs] Fix typo in produce method`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
Fixes https://github.com/apache/pulsar/issues/7112
### Motivation
It is redundant to modify at 8 places for using pulsar-all image which existed private repositories.
### Modifications
use one pulsar-all docker image config to avoid repeated configs in helm chart.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie commented on pull request #7113: set pulsar-all docker image config one time
Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #7113:
URL: https://github.com/apache/pulsar/pull/7113#issuecomment-636570582
@dockerzhang: Currently the helm chart is designed to allow configuring different images for different components. This change breaks the flexibility. If you want to introduce a common image, that is fine. But we should also add the functionality to allow overwriting images for individual components.
Also, can you send the pull request to https://github.com/apache/pulsar-helm-chart.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] dockerzhang closed pull request #7113: set pulsar-all docker image config one time
Posted by GitBox <gi...@apache.org>.
dockerzhang closed pull request #7113:
URL: https://github.com/apache/pulsar/pull/7113
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie commented on pull request #7113: set pulsar-all docker image config one time
Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #7113:
URL: https://github.com/apache/pulsar/pull/7113#issuecomment-637182704
@dockerzhang - I think it is not only about flexibility. It is more about operability in production. The problem of using one single image is - if you update the image and re-deploy the helm chart, you will trigger the updates on all components. For some of the components like zookeeper, you probably don't need to deploy it every time there is a new version.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] dockerzhang commented on pull request #7113: set pulsar-all docker image config one time
Posted by GitBox <gi...@apache.org>.
dockerzhang commented on pull request #7113:
URL: https://github.com/apache/pulsar/pull/7113#issuecomment-636584118
@jiazhai @sijie If we build components image separately in the future, it's the best way to configuring components using different image.
pulsar has built all components in pulsar-all, and if we will still use it. i think it's better to make easy for configuration but not flexibility.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jiazhai commented on pull request #7113: set pulsar-all docker image config one time
Posted by GitBox <gi...@apache.org>.
jiazhai commented on pull request #7113:
URL: https://github.com/apache/pulsar/pull/7113#issuecomment-636482388
@dockerzhang, thanks for help on this issue. current way may be easier for user to config different components using different image
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org