You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by omerhadari <gi...@git.apache.org> on 2017/07/23 18:27:15 UTC

[GitHub] storm pull request #2236: STORM-2652: fix error in open method of JmsSpout

GitHub user omerhadari opened a pull request:

    https://github.com/apache/storm/pull/2236

    STORM-2652: fix error in open method of JmsSpout

    I changed the casting to `Number` instead of `Integer`
    since it is actually a `Long`, and it caused a `ClassCastException`
    to be thrown. Now it is referred to as a `Number` so that it won't
    happen again.
    Also resolved style issues in `JmsSpout`. Added javadoc, renamed
    fields etc...
    
    This is essentially the same as #2234 but compatible with the 1.x-branch
    
    @srdo 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/omerhadari/storm bugfix/fix-configuration-cast-exception-1.x

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/2236.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2236
    
----
commit c9afcb3353918498c32dfb66554ab613c6f9ede6
Author: Omer Hadari <ha...@gmail.com>
Date:   2017-07-21T07:21:23Z

    STORM-2652: fix error in open method of JmsSpout
    
    I changed the casting to `Number` instead of `Integer`
    since it is actually a `Long`, and it caused a `ClassCastException`
    to be thrown. Now it is referred to as a `Number` so that it won't
    happen again.
    Also resolved style issues in `JmsSpout`. Added javadoc, renamed
    fields etc...

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #2236: STORM-2652: fix error in open method of JmsSpout

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/storm/pull/2236


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #2236: STORM-2652: fix error in open method of JmsSpout

Posted by srdo <gi...@git.apache.org>.
Github user srdo commented on the issue:

    https://github.com/apache/storm/pull/2236
  
    Thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---