You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Santhosh Edukulla <sa...@citrix.com> on 2014/02/13 13:57:30 UTC
Review Request 18074: Added few changes for CLOUDSTACK-5674
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18074/
-----------------------------------------------------------
Review request for cloudstack and Girish Shilamkar.
Bugs: CLOUDSTACK-5674
https://issues.apache.org/jira/browse/CLOUDSTACK-5674
Repository: cloudstack-git
Description
-------
Added few changes and clean up for 5674
Diffs
-----
tools/marvin/marvin/cloudstackTestClient.py 4d05eaf
tools/marvin/marvin/config/test_data.py PRE-CREATION
tools/marvin/marvin/marvinPlugin.py 3a97404
Diff: https://reviews.apache.org/r/18074/diff/
Testing
-------
Thanks,
Santhosh Edukulla
Re: Review Request 18074: Added few changes for CLOUDSTACK-5674
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18074/#review34475
-----------------------------------------------------------
Commit 1eb98e135b0bdd6a00f10c5bbf98e2947334a31d in branch refs/heads/marvin from Girish Shilamkar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=1eb98e1 ]
CLOUDSTACK-5674: Fix a missing closing bracket.
- ASF Subversion and Git Services
On Feb. 13, 2014, 12:57 p.m., Santhosh Edukulla wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18074/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2014, 12:57 p.m.)
>
>
> Review request for cloudstack and Girish Shilamkar.
>
>
> Bugs: CLOUDSTACK-5674
> https://issues.apache.org/jira/browse/CLOUDSTACK-5674
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Added few changes and clean up for 5674
>
>
> Diffs
> -----
>
> tools/marvin/marvin/cloudstackTestClient.py 4d05eaf
> tools/marvin/marvin/config/test_data.py PRE-CREATION
> tools/marvin/marvin/marvinPlugin.py 3a97404
>
> Diff: https://reviews.apache.org/r/18074/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Santhosh Edukulla
>
>
Re: Review Request 18074: Added few changes for CLOUDSTACK-5674
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18074/#review34472
-----------------------------------------------------------
Commit 2d93d83b44927e0ede7c0a5440bf5f472cc8d11a in branch refs/heads/marvin from Girish Shilamkar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=2d93d83 ]
CLOUDSTACK-5674: Added missing import for FAILED
- ASF Subversion and Git Services
On Feb. 13, 2014, 12:57 p.m., Santhosh Edukulla wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18074/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2014, 12:57 p.m.)
>
>
> Review request for cloudstack and Girish Shilamkar.
>
>
> Bugs: CLOUDSTACK-5674
> https://issues.apache.org/jira/browse/CLOUDSTACK-5674
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Added few changes and clean up for 5674
>
>
> Diffs
> -----
>
> tools/marvin/marvin/cloudstackTestClient.py 4d05eaf
> tools/marvin/marvin/config/test_data.py PRE-CREATION
> tools/marvin/marvin/marvinPlugin.py 3a97404
>
> Diff: https://reviews.apache.org/r/18074/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Santhosh Edukulla
>
>
Re: Review Request 18074: Added few changes for CLOUDSTACK-5674
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18074/#review34468
-----------------------------------------------------------
Commit aa2831231cb82773dcf4460a9b29985782d90ebe in branch refs/heads/marvin from Girish Shilamkar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=aa28312 ]
CLOUDSTACK-5674: apiclient was used before it was created. Fixed it.
- ASF Subversion and Git Services
On Feb. 13, 2014, 12:57 p.m., Santhosh Edukulla wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18074/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2014, 12:57 p.m.)
>
>
> Review request for cloudstack and Girish Shilamkar.
>
>
> Bugs: CLOUDSTACK-5674
> https://issues.apache.org/jira/browse/CLOUDSTACK-5674
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Added few changes and clean up for 5674
>
>
> Diffs
> -----
>
> tools/marvin/marvin/cloudstackTestClient.py 4d05eaf
> tools/marvin/marvin/config/test_data.py PRE-CREATION
> tools/marvin/marvin/marvinPlugin.py 3a97404
>
> Diff: https://reviews.apache.org/r/18074/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Santhosh Edukulla
>
>
Re: Review Request 18074: Added few changes for CLOUDSTACK-5674
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18074/#review34462
-----------------------------------------------------------
Commit f0eb184d8a5bf3412190468641fa3d887cfe7bb1 in branch refs/heads/marvin from Girish Shilamkar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=f0eb184 ]
CLOUDSTACK-5674: Fix get_domain and remove dependency on ostype in get_template
- ASF Subversion and Git Services
On Feb. 13, 2014, 12:57 p.m., Santhosh Edukulla wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18074/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2014, 12:57 p.m.)
>
>
> Review request for cloudstack and Girish Shilamkar.
>
>
> Bugs: CLOUDSTACK-5674
> https://issues.apache.org/jira/browse/CLOUDSTACK-5674
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Added few changes and clean up for 5674
>
>
> Diffs
> -----
>
> tools/marvin/marvin/cloudstackTestClient.py 4d05eaf
> tools/marvin/marvin/config/test_data.py PRE-CREATION
> tools/marvin/marvin/marvinPlugin.py 3a97404
>
> Diff: https://reviews.apache.org/r/18074/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Santhosh Edukulla
>
>
Re: Review Request 18074: Added few changes for CLOUDSTACK-5674
Posted by Girish Shilamkar <gi...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18074/#review34457
-----------------------------------------------------------
Ship it!
Ship It!
- Girish Shilamkar
On Feb. 13, 2014, 12:57 p.m., Santhosh Edukulla wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18074/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2014, 12:57 p.m.)
>
>
> Review request for cloudstack and Girish Shilamkar.
>
>
> Bugs: CLOUDSTACK-5674
> https://issues.apache.org/jira/browse/CLOUDSTACK-5674
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Added few changes and clean up for 5674
>
>
> Diffs
> -----
>
> tools/marvin/marvin/cloudstackTestClient.py 4d05eaf
> tools/marvin/marvin/config/test_data.py PRE-CREATION
> tools/marvin/marvin/marvinPlugin.py 3a97404
>
> Diff: https://reviews.apache.org/r/18074/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Santhosh Edukulla
>
>
Re: Review Request 18074: Added few changes for CLOUDSTACK-5674
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18074/#review34464
-----------------------------------------------------------
Commit f3a77c79e8ce5b6c1448737520a5c3e159e5337d in branch refs/heads/marvin from Girish Shilamkar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=f3a77c7 ]
CLOUDSTACK-5674: cls.fail does not work in setUpClass fixed it with assert.
- ASF Subversion and Git Services
On Feb. 13, 2014, 12:57 p.m., Santhosh Edukulla wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18074/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2014, 12:57 p.m.)
>
>
> Review request for cloudstack and Girish Shilamkar.
>
>
> Bugs: CLOUDSTACK-5674
> https://issues.apache.org/jira/browse/CLOUDSTACK-5674
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Added few changes and clean up for 5674
>
>
> Diffs
> -----
>
> tools/marvin/marvin/cloudstackTestClient.py 4d05eaf
> tools/marvin/marvin/config/test_data.py PRE-CREATION
> tools/marvin/marvin/marvinPlugin.py 3a97404
>
> Diff: https://reviews.apache.org/r/18074/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Santhosh Edukulla
>
>
Re: Review Request 18074: Added few changes for CLOUDSTACK-5674
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18074/#review34453
-----------------------------------------------------------
Commit c0d8b9e334021f398cbb0dfb5c2aca86b7717bea in branch refs/heads/marvin from Santhosh Edukulla
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=c0d8b9e ]
CLOUDSTACK-5674: getZoneForTests should return None if zone is "NA" in test_data.py
- ASF Subversion and Git Services
On Feb. 13, 2014, 12:57 p.m., Santhosh Edukulla wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18074/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2014, 12:57 p.m.)
>
>
> Review request for cloudstack and Girish Shilamkar.
>
>
> Bugs: CLOUDSTACK-5674
> https://issues.apache.org/jira/browse/CLOUDSTACK-5674
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Added few changes and clean up for 5674
>
>
> Diffs
> -----
>
> tools/marvin/marvin/cloudstackTestClient.py 4d05eaf
> tools/marvin/marvin/config/test_data.py PRE-CREATION
> tools/marvin/marvin/marvinPlugin.py 3a97404
>
> Diff: https://reviews.apache.org/r/18074/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Santhosh Edukulla
>
>