[GitHub] [cloudstack] vishesh92 commented on a diff in pull request #7368: UI: Add filtering by state in systemvms, router and storagepool

["vishesh92 (via GitHub)" <gi...@apache.org>]

vishesh92 commented on code in PR #7368:
URL: https://github.com/apache/cloudstack/pull/7368#discussion_r1148834843


##########
server/src/main/java/com/cloud/api/query/QueryManagerImpl.java:
##########
@@ -2607,6 +2608,14 @@ private Pair<List<StoragePoolJoinVO>, Integer> searchForStoragePoolsInternal(Lis
                 throw new InvalidParameterValueException("Invalid scope type: " + cmd.getScope());
             }
         }
+        StoragePoolStatus state = null;
+        if (cmd.getState() != null && EnumUtils.isValidEnumIgnoreCase(StoragePoolStatus.class, cmd.getState())) {

Review Comment:
   @harikrishna-patnala `EnumUtils.getEnumIgnoreCase` returns `null` if the value is invalid. I have added a check for that instead. Let me know if this looks good.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org