You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Matt Benson (JIRA)" <de...@myfaces.apache.org> on 2011/05/19 21:25:48 UTC
[jira] [Created] (EXTVAL-133) tests in
test-modules/core-tests/src/test/java/org/apache/myfaces/extensions/validator/test/core/stage
should customize servletContext as part of setup
tests in test-modules/core-tests/src/test/java/org/apache/myfaces/extensions/validator/test/core/stage should customize servletContext as part of setup
-------------------------------------------------------------------------------------------------------------------------------------------------------
Key: EXTVAL-133
URL: https://issues.apache.org/jira/browse/EXTVAL-133
Project: MyFaces Extensions Validator
Issue Type: Test
Affects Versions: 2.0.5
Reporter: Matt Benson
these tests work in trunk, but when running them against https://svn.apache.org/repos/asf/myfaces/extensions/validator/branches/branch_for_jsf_2_0, they fail because the DefaultELHelper requests the ProjectStage so that it is cached before the testcase has the chance to add the "javax.faces.PROJECT_STAGE" init parameter. The attached patch continues to test successfully against trunk _and_ works for JSF 2.0.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (EXTVAL-133) tests in
test-modules/core-tests/src/test/java/org/apache/myfaces/extensions/validator/test/core/stage
should customize servletContext as part of setup
Posted by "Rudy De Busscher (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/EXTVAL-133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13040188#comment-13040188 ]
Rudy De Busscher commented on EXTVAL-133:
-----------------------------------------
Verified the test modules on the branch20. Did the following things
- Copied classes fro trunk to the branch
- Changed POM files so that 2.0 versions of dependencies are used (test20, JSF 2.0, ...)
- Applied patch on this issue
- Running against a MyFacesTest with issues 50 and 53 fixed
-> Everything works except the CustomProjectStageTestCase. Probably because the tweak (as mentioned in the description) isn't in the patch.
> tests in test-modules/core-tests/src/test/java/org/apache/myfaces/extensions/validator/test/core/stage should customize servletContext as part of setup
> -------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: EXTVAL-133
> URL: https://issues.apache.org/jira/browse/EXTVAL-133
> Project: MyFaces Extensions Validator
> Issue Type: Test
> Affects Versions: 2.0.5
> Reporter: Matt Benson
> Assignee: Rudy De Busscher
> Attachments: EXTVAL-133.patch.txt
>
>
> these tests work in trunk, but when running them against https://svn.apache.org/repos/asf/myfaces/extensions/validator/branches/branch_for_jsf_2_0, they fail because the DefaultELHelper requests the ProjectStage so that it is cached before the testcase has the chance to add the "javax.faces.PROJECT_STAGE" init parameter. The attached patch continues to test successfully against trunk _and_ (with the minor tweak of a custom ProjectStageResolver for the CustomProjectStageTestCase) works for JSF 2.0 .
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (EXTVAL-133) tests in
test-modules/core-tests/src/test/java/org/apache/myfaces/extensions/validator/test/core/stage
should customize servletContext as part of setup
Posted by "Matt Benson (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/EXTVAL-133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13037035#comment-13037035 ]
Matt Benson edited comment on EXTVAL-133 at 5/20/11 7:50 PM:
-------------------------------------------------------------
MYFACESTEST-50 is a prerequisite to successful testing of https://svn.apache.org/repos/asf/myfaces/extensions/validator/branches/branch_for_jsf_2_0
was (Author: mbenson):
MYFACESTEST-52 is a prerequisite to successful testing of https://svn.apache.org/repos/asf/myfaces/extensions/validator/branches/branch_for_jsf_2_0
> tests in test-modules/core-tests/src/test/java/org/apache/myfaces/extensions/validator/test/core/stage should customize servletContext as part of setup
> -------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: EXTVAL-133
> URL: https://issues.apache.org/jira/browse/EXTVAL-133
> Project: MyFaces Extensions Validator
> Issue Type: Test
> Affects Versions: 2.0.5
> Reporter: Matt Benson
> Assignee: Rudy De Busscher
> Attachments: EXTVAL-133.patch.txt
>
>
> these tests work in trunk, but when running them against https://svn.apache.org/repos/asf/myfaces/extensions/validator/branches/branch_for_jsf_2_0, they fail because the DefaultELHelper requests the ProjectStage so that it is cached before the testcase has the chance to add the "javax.faces.PROJECT_STAGE" init parameter. The attached patch continues to test successfully against trunk _and_ (with the minor tweak of a custom ProjectStageResolver for the CustomProjectStageTestCase) works for JSF 2.0 .
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (EXTVAL-133) tests in
test-modules/core-tests/src/test/java/org/apache/myfaces/extensions/validator/test/core/stage
should customize servletContext as part of setup
Posted by "Rudy De Busscher (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/EXTVAL-133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rudy De Busscher updated EXTVAL-133:
------------------------------------
Resolution: Fixed
Fix Version/s: 1.2.5
2.0.5
Status: Resolved (was: Patch Available)
> tests in test-modules/core-tests/src/test/java/org/apache/myfaces/extensions/validator/test/core/stage should customize servletContext as part of setup
> -------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: EXTVAL-133
> URL: https://issues.apache.org/jira/browse/EXTVAL-133
> Project: MyFaces Extensions Validator
> Issue Type: Test
> Affects Versions: 2.0.5
> Reporter: Matt Benson
> Assignee: Rudy De Busscher
> Fix For: 2.0.5, 1.2.5
>
> Attachments: EXTVAL-133-with-tweak.patch.txt, EXTVAL-133.patch.txt
>
>
> these tests work in trunk, but when running them against https://svn.apache.org/repos/asf/myfaces/extensions/validator/branches/branch_for_jsf_2_0, they fail because the DefaultELHelper requests the ProjectStage so that it is cached before the testcase has the chance to add the "javax.faces.PROJECT_STAGE" init parameter. The attached patch continues to test successfully against trunk _and_ (with the minor tweak of a custom ProjectStageResolver for the CustomProjectStageTestCase) works for JSF 2.0 .
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (EXTVAL-133) tests in
test-modules/core-tests/src/test/java/org/apache/myfaces/extensions/validator/test/core/stage
should customize servletContext as part of setup
Posted by "Rudy De Busscher (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/EXTVAL-133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13040188#comment-13040188 ]
Rudy De Busscher edited comment on EXTVAL-133 at 5/27/11 11:26 AM:
-------------------------------------------------------------------
Verified the test modules on the branch20. Did the following things
- Copied classes fro trunk to the branch
- Changed POM files so that 2.0 versions of dependencies are used (test20, JSF 2.0, ...)
- Applied patch on this issue
- No use of the ExtValMockApplicationFactory (commented out in the setFactories in AbstractExValTestCase)
- Running against a MyFacesTest with issues 50 and 53 fixed
-> Everything works except the CustomProjectStageTestCase. Probably because the tweak (as mentioned in the description) isn't in the patch.
was (Author: rdebusscher):
Verified the test modules on the branch20. Did the following things
- Copied classes fro trunk to the branch
- Changed POM files so that 2.0 versions of dependencies are used (test20, JSF 2.0, ...)
- Applied patch on this issue
- Running against a MyFacesTest with issues 50 and 53 fixed
-> Everything works except the CustomProjectStageTestCase. Probably because the tweak (as mentioned in the description) isn't in the patch.
> tests in test-modules/core-tests/src/test/java/org/apache/myfaces/extensions/validator/test/core/stage should customize servletContext as part of setup
> -------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: EXTVAL-133
> URL: https://issues.apache.org/jira/browse/EXTVAL-133
> Project: MyFaces Extensions Validator
> Issue Type: Test
> Affects Versions: 2.0.5
> Reporter: Matt Benson
> Assignee: Rudy De Busscher
> Attachments: EXTVAL-133.patch.txt
>
>
> these tests work in trunk, but when running them against https://svn.apache.org/repos/asf/myfaces/extensions/validator/branches/branch_for_jsf_2_0, they fail because the DefaultELHelper requests the ProjectStage so that it is cached before the testcase has the chance to add the "javax.faces.PROJECT_STAGE" init parameter. The attached patch continues to test successfully against trunk _and_ (with the minor tweak of a custom ProjectStageResolver for the CustomProjectStageTestCase) works for JSF 2.0 .
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (EXTVAL-133) tests in
test-modules/core-tests/src/test/java/org/apache/myfaces/extensions/validator/test/core/stage
should customize servletContext as part of setup
Posted by "Matt Benson (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/EXTVAL-133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matt Benson updated EXTVAL-133:
-------------------------------
Status: Patch Available (was: Open)
> tests in test-modules/core-tests/src/test/java/org/apache/myfaces/extensions/validator/test/core/stage should customize servletContext as part of setup
> -------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: EXTVAL-133
> URL: https://issues.apache.org/jira/browse/EXTVAL-133
> Project: MyFaces Extensions Validator
> Issue Type: Test
> Affects Versions: 2.0.5
> Reporter: Matt Benson
>
> these tests work in trunk, but when running them against https://svn.apache.org/repos/asf/myfaces/extensions/validator/branches/branch_for_jsf_2_0, they fail because the DefaultELHelper requests the ProjectStage so that it is cached before the testcase has the chance to add the "javax.faces.PROJECT_STAGE" init parameter. The attached patch continues to test successfully against trunk _and_ works for JSF 2.0.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (EXTVAL-133) tests in
test-modules/core-tests/src/test/java/org/apache/myfaces/extensions/validator/test/core/stage
should customize servletContext as part of setup
Posted by "Matt Benson (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/EXTVAL-133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13040261#comment-13040261 ]
Matt Benson commented on EXTVAL-133:
------------------------------------
Yes, I actually intended this issue as more a stepping-stone to a full-fledged "test extval on the 2.0 branch" issue, wherein I could submit the tweak as a patch against trunk. However, I can also submit the 2.0 version of the patch.
> tests in test-modules/core-tests/src/test/java/org/apache/myfaces/extensions/validator/test/core/stage should customize servletContext as part of setup
> -------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: EXTVAL-133
> URL: https://issues.apache.org/jira/browse/EXTVAL-133
> Project: MyFaces Extensions Validator
> Issue Type: Test
> Affects Versions: 2.0.5
> Reporter: Matt Benson
> Assignee: Rudy De Busscher
> Attachments: EXTVAL-133.patch.txt
>
>
> these tests work in trunk, but when running them against https://svn.apache.org/repos/asf/myfaces/extensions/validator/branches/branch_for_jsf_2_0, they fail because the DefaultELHelper requests the ProjectStage so that it is cached before the testcase has the chance to add the "javax.faces.PROJECT_STAGE" init parameter. The attached patch continues to test successfully against trunk _and_ (with the minor tweak of a custom ProjectStageResolver for the CustomProjectStageTestCase) works for JSF 2.0 .
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (EXTVAL-133) tests in
test-modules/core-tests/src/test/java/org/apache/myfaces/extensions/validator/test/core/stage
should customize servletContext as part of setup
Posted by "Matt Benson (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/EXTVAL-133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13037033#comment-13037033 ]
Matt Benson edited comment on EXTVAL-133 at 5/20/11 7:48 PM:
-------------------------------------------------------------
This and related issues are prerequisites to successful testing of https://svn.apache.org/repos/asf/myfaces/extensions/validator/branches/branch_for_jsf_2_0
was (Author: mbenson):
prerequisite to successful testing of https://svn.apache.org/repos/asf/myfaces/extensions/validator/branches/branch_for_jsf_2_0
> tests in test-modules/core-tests/src/test/java/org/apache/myfaces/extensions/validator/test/core/stage should customize servletContext as part of setup
> -------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: EXTVAL-133
> URL: https://issues.apache.org/jira/browse/EXTVAL-133
> Project: MyFaces Extensions Validator
> Issue Type: Test
> Affects Versions: 2.0.5
> Reporter: Matt Benson
> Assignee: Rudy De Busscher
> Attachments: EXTVAL-133.patch.txt
>
>
> these tests work in trunk, but when running them against https://svn.apache.org/repos/asf/myfaces/extensions/validator/branches/branch_for_jsf_2_0, they fail because the DefaultELHelper requests the ProjectStage so that it is cached before the testcase has the chance to add the "javax.faces.PROJECT_STAGE" init parameter. The attached patch continues to test successfully against trunk _and_ (with the minor tweak of a custom ProjectStageResolver for the CustomProjectStageTestCase) works for JSF 2.0 .
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (EXTVAL-133) tests in
test-modules/core-tests/src/test/java/org/apache/myfaces/extensions/validator/test/core/stage
should customize servletContext as part of setup
Posted by "Matt Benson (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/EXTVAL-133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13037033#comment-13037033 ]
Matt Benson edited comment on EXTVAL-133 at 5/20/11 7:49 PM:
-------------------------------------------------------------
MYFACESTEST-52 is a prerequisite to successful testing of https://svn.apache.org/repos/asf/myfaces/extensions/validator/branches/branch_for_jsf_2_0 _without_ ExtValMockApplication
was (Author: mbenson):
This and related issues are prerequisites to successful testing of https://svn.apache.org/repos/asf/myfaces/extensions/validator/branches/branch_for_jsf_2_0
> tests in test-modules/core-tests/src/test/java/org/apache/myfaces/extensions/validator/test/core/stage should customize servletContext as part of setup
> -------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: EXTVAL-133
> URL: https://issues.apache.org/jira/browse/EXTVAL-133
> Project: MyFaces Extensions Validator
> Issue Type: Test
> Affects Versions: 2.0.5
> Reporter: Matt Benson
> Assignee: Rudy De Busscher
> Attachments: EXTVAL-133.patch.txt
>
>
> these tests work in trunk, but when running them against https://svn.apache.org/repos/asf/myfaces/extensions/validator/branches/branch_for_jsf_2_0, they fail because the DefaultELHelper requests the ProjectStage so that it is cached before the testcase has the chance to add the "javax.faces.PROJECT_STAGE" init parameter. The attached patch continues to test successfully against trunk _and_ (with the minor tweak of a custom ProjectStageResolver for the CustomProjectStageTestCase) works for JSF 2.0 .
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira