You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/03 08:16:10 UTC

[GitHub] [apisix] membphis commented on a change in pull request #2869: fix: start server failure

membphis commented on a change in pull request #2869:
URL: https://github.com/apache/apisix/pull/2869#discussion_r534888151



##########
File path: Makefile
##########
@@ -86,6 +86,8 @@ run: default
 ifeq ("$(wildcard logs/nginx.pid)", "")
 	mkdir -p logs
 	$(OR_EXEC) -p $$PWD/ -c $$PWD/conf/nginx.conf
+else ifeq ("$(shell lsof -p $(shell cat logs/nginx.pid))", "")
+	$(OR_EXEC) -p $$PWD/ -c $$PWD/conf/nginx.conf

Review comment:
       `nginx.pid exists but there's no corresponding process`
   
   We should add this tip in both `Makefile` and `bin/apisix`, it is more user-friendly.
   
   I created a new issue https://github.com/apache/apisix/issues/2948 , welcome to fix this issue.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org