You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by gi...@apache.org on 2018/05/24 01:24:42 UTC
[2/2] mesos git commit: Added isolator logs for volume/secret
isolator and container logger.
Added isolator logs for volume/secret isolator and container logger.
Review: https://reviews.apache.org/r/67241
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/cb193f52
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/cb193f52
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/cb193f52
Branch: refs/heads/1.4.x
Commit: cb193f5216bd69393e670f2b7916d9bf2b275266
Parents: 6144242
Author: Gilbert Song <so...@gmail.com>
Authored: Mon May 21 16:42:53 2018 -0700
Committer: Gilbert Song <so...@gmail.com>
Committed: Wed May 23 18:24:13 2018 -0700
----------------------------------------------------------------------
src/slave/containerizer/mesos/io/switchboard.cpp | 10 ++++++++--
src/slave/containerizer/mesos/isolators/volume/secret.cpp | 5 ++++-
2 files changed, 12 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/mesos/blob/cb193f52/src/slave/containerizer/mesos/io/switchboard.cpp
----------------------------------------------------------------------
diff --git a/src/slave/containerizer/mesos/io/switchboard.cpp b/src/slave/containerizer/mesos/io/switchboard.cpp
index 63d3cf8..d36ec79 100644
--- a/src/slave/containerizer/mesos/io/switchboard.cpp
+++ b/src/slave/containerizer/mesos/io/switchboard.cpp
@@ -295,19 +295,25 @@ Future<Option<ContainerLaunchInfo>> IOSwitchboard::_prepare(
const ContainerConfig& containerConfig,
const ContainerIO& loggerIO)
{
+ bool requiresServer = IOSwitchboard::requiresServer(containerConfig);
+
// On windows, we do not yet support running an io switchboard
// server, so we must error out if it is required.
#ifdef __WINDOWS__
- if (IOSwitchboard::requiresServer(containerConfig)) {
+ if (requiresServer) {
return Failure(
"IO Switchboard server is not supported on windows");
}
#endif
+ LOG(INFO) << "Container logger module finished preparing container "
+ << containerId << "; IOSwitchboard server is "
+ << (requiresServer ? "" : "not") << " required";
+
bool hasTTY = containerConfig.has_container_info() &&
containerConfig.container_info().has_tty_info();
- if (!IOSwitchboard::requiresServer(containerConfig)) {
+ if (!requiresServer) {
CHECK(!containerIOs.contains(containerId));
containerIOs[containerId] = loggerIO;
http://git-wip-us.apache.org/repos/asf/mesos/blob/cb193f52/src/slave/containerizer/mesos/isolators/volume/secret.cpp
----------------------------------------------------------------------
diff --git a/src/slave/containerizer/mesos/isolators/volume/secret.cpp b/src/slave/containerizer/mesos/isolators/volume/secret.cpp
index ee9366f..322faf8 100644
--- a/src/slave/containerizer/mesos/isolators/volume/secret.cpp
+++ b/src/slave/containerizer/mesos/isolators/volume/secret.cpp
@@ -290,7 +290,10 @@ Future<Option<ContainerLaunchInfo>> VolumeSecretIsolatorProcess::prepare(
}
return collect(futures)
- .then([launchInfo]() -> Future<Option<ContainerLaunchInfo>> {
+ .then([launchInfo, containerId](
+ const list<Nothing>& results) -> Future<Option<ContainerLaunchInfo>> {
+ LOG(INFO) << results.size() << " secrets have been resolved for "
+ << "container " << containerId;
return launchInfo;
});
}