You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/09/06 15:27:49 UTC
[GitHub] [incubator-eventmesh] horoc opened a new issue, #1231: [Enhancement] Extraction non-null check logic to common method
horoc opened a new issue, #1231:
URL: https://github.com/apache/incubator-eventmesh/issues/1231
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/eventmesh/issues?q=is%3Aissue) and found no similar issues.
### Enhancement Request
<img width="1113" alt="image" src="https://user-images.githubusercontent.com/63457588/188673566-37a44646-d921-4214-8d9f-8dd20231bf0b.png">
There are many non-null check logic with the conditional operator, it will easily cause a line to be too long to pass the style check, and also affect the readability of project.
<img width="1305" alt="image" src="https://user-images.githubusercontent.com/63457588/188674657-7361c236-f1e4-4024-b6bc-2a7cdd03c5b7.png">
### Describe the solution you'd like
We can extract all these check logic to a static method like ```getOrDefault``` to avoid using conditional operator.
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] xwm1992 closed issue #1231: [Enhancement] Extract non-null check logic to common method
Posted by GitBox <gi...@apache.org>.
xwm1992 closed issue #1231: [Enhancement] Extract non-null check logic to common method
URL: https://github.com/apache/incubator-eventmesh/issues/1231
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org