You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2015/05/15 12:46:31 UTC

Review Request 34264: Ambari should configure NameNode to terminate on OutOfMemoryError.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34264/
-----------------------------------------------------------

Review request for Ambari and Vitalyi Brodetskyi.


Bugs: AMBARI-11162
    https://issues.apache.org/jira/browse/AMBARI-11162


Repository: ambari


Description
-------

It is dangerous for the NameNode to keep running if it encounters
`OutOfMemoryError`. There is some legacy code in the RPC handling layer that
catches `OutOfMemoryError`, and we're not going to be able to revert this
code. Instead, we can kill it externally by setting a JVM option. We would
like Ambari to configure the NameNode to run with this option:

    
    
    
    -XX:OnOutOfMemoryError="kill -9 %p"
    

This can be set in `HADOOP_NAMENODE_OPTS` in hadoop-env.sh.


Diffs
-----

  ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/configuration/hadoop-env.xml 108805f 

Diff: https://reviews.apache.org/r/34264/diff/


Testing
-------

mvn clean test


Thanks,

Andrew Onischuk


Re: Review Request 34264: Ambari should configure NameNode to terminate on OutOfMemoryError.

Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34264/#review83915
-----------------------------------------------------------

Ship it!


Ship It!

- Vitalyi Brodetskyi


On Травень 15, 2015, 10:46 до полудня, Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34264/
> -----------------------------------------------------------
> 
> (Updated Травень 15, 2015, 10:46 до полудня)
> 
> 
> Review request for Ambari and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-11162
>     https://issues.apache.org/jira/browse/AMBARI-11162
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> It is dangerous for the NameNode to keep running if it encounters
> `OutOfMemoryError`. There is some legacy code in the RPC handling layer that
> catches `OutOfMemoryError`, and we're not going to be able to revert this
> code. Instead, we can kill it externally by setting a JVM option. We would
> like Ambari to configure the NameNode to run with this option:
> 
>     
>     
>     
>     -XX:OnOutOfMemoryError="kill -9 %p"
>     
> 
> This can be set in `HADOOP_NAMENODE_OPTS` in hadoop-env.sh.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/configuration/hadoop-env.xml 108805f 
> 
> Diff: https://reviews.apache.org/r/34264/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>