You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/10/27 22:31:33 UTC
[GitHub] [incubator-mxnet] access2rohit opened a new pull request #19433: updating License for dlpack for v1.8 release
access2rohit opened a new pull request #19433:
URL: https://github.com/apache/incubator-mxnet/pull/19433
## Description ##
update `dlpack`'s LICENSE
## Checklist ##
### Essentials ###
- [X] Changes are complete (i.e. I finished coding on this PR)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu edited a comment on pull request #19433: updating License for dlpack for v1.8 release
Posted by GitBox <gi...@apache.org>.
leezu edited a comment on pull request #19433:
URL: https://github.com/apache/incubator-mxnet/pull/19433#issuecomment-718299577
It's great to be consistent with the existing MXNet License file but my point is that such consistent inclusion will be very hard to keep updated at every release and isn't needed according to the ASF licensing howto and TVM's practice: The howto states "In LICENSE, add a pointer to the dependency's license within the distribution and a short note summarizing its licensing" and does not require the inclusion of copyright statements.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] josephevans commented on pull request #19433: updating License for dlpack for v1.8 release
Posted by GitBox <gi...@apache.org>.
josephevans commented on pull request #19433:
URL: https://github.com/apache/incubator-mxnet/pull/19433#issuecomment-719119033
This change is already included in #19440, you can close this PR. Thanks @access2rohit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] access2rohit closed pull request #19433: updating License for dlpack for v1.8 release
Posted by GitBox <gi...@apache.org>.
access2rohit closed pull request #19433:
URL: https://github.com/apache/incubator-mxnet/pull/19433
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] sandeep-krishnamurthy commented on pull request #19433: updating License for dlpack for v1.8 release
Posted by GitBox <gi...@apache.org>.
sandeep-krishnamurthy commented on pull request #19433:
URL: https://github.com/apache/incubator-mxnet/pull/19433#issuecomment-717606595
Thank you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] access2rohit commented on pull request #19433: updating License for dlpack for v1.8 release
Posted by GitBox <gi...@apache.org>.
access2rohit commented on pull request #19433:
URL: https://github.com/apache/incubator-mxnet/pull/19433#issuecomment-717579338
@samskalicky @leezu Can you review ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on pull request #19433: updating License for dlpack for v1.8 release
Posted by GitBox <gi...@apache.org>.
leezu commented on pull request #19433:
URL: https://github.com/apache/incubator-mxnet/pull/19433#issuecomment-718265323
There is no need to update the copyright notice. TVM doesn't include copyright notice (https://github.com/apache/incubator-tvm/blob/39cd612cdbf9a2443b5561b90b4b4a55996274f1/LICENSE#L203-L240) and it's not mentioned in the https://infra.apache.org/licensing-howto.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] access2rohit commented on pull request #19433: updating License for dlpack for v1.8 release
Posted by GitBox <gi...@apache.org>.
access2rohit commented on pull request #19433:
URL: https://github.com/apache/incubator-mxnet/pull/19433#issuecomment-718286638
> There is no need to update the copyright notice. TVM doesn't include copyright notice (https://github.com/apache/incubator-tvm/blob/39cd612cdbf9a2443b5561b90b4b4a55996274f1/LICENSE#L203-L240) and it's not mentioned in the https://infra.apache.org/licensing-howto.html
Its not for TVM it is for dlpack which is MXNet's direct dependecy. I made this PR to be consistent with what already exists in the MXNet's LICENSE file
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19433: updating License for dlpack for v1.8 release
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19433:
URL: https://github.com/apache/incubator-mxnet/pull/19433#issuecomment-717579145
Hey @access2rohit , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [clang, windows-cpu, windows-gpu, centos-cpu, unix-cpu, centos-gpu, edge, miscellaneous, website, unix-gpu, sanity]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on pull request #19433: updating License for dlpack for v1.8 release
Posted by GitBox <gi...@apache.org>.
leezu commented on pull request #19433:
URL: https://github.com/apache/incubator-mxnet/pull/19433#issuecomment-718299577
It's great to be consistent with the existing MXNet License file but my point is that such consistent inclusion will be very hard to keep updated at every release and isn't needed according to the ASF licensing howto and TVM's practice: The howto states "In LICENSE, add a pointer to the dependency's license within the distribution and a short note summarizing its licensing" and does not require the inclusion of copyright statements.
I
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org